Received-SPF: pass (google.com: domain of linux-kernel+bounces-81900-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 11:24:31 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Serge Semin <fancer.lancer@gmail.com>, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev
Subject: Re: [PATCH v3 1/5] PCI: dwc: Refactor dw_pcie_edma_find_chip() API
Message-ID: <Zdy7PxDO7d8YIKG2@lizhi-Precision-Tower-5810>
References: <20240226-dw-hdma-v3-0-cfcb8171fc24@linaro.org>
 <20240226-dw-hdma-v3-1-cfcb8171fc24@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226-dw-hdma-v3-1-cfcb8171fc24@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qinck6f5h/1eJeDar/X32IMyzHgib+2FYBd85rQaQNW0olUVstVh5XmYg6ym?=
 =?us-ascii?Q?xet0TMU0ep/d281sPJLQv1BQIywJCJMtjWUVB1Fskpl2H03lDilJghGQcDso?=
 =?us-ascii?Q?orvrB8dNKoR8rsf9s3/xHIAjFYCETloDi2/CsizY05EMBcVq2Mq20G+h31G8?=
 =?us-ascii?Q?GGKsONYnqveuGimxaS/QrusP8d20oGPjb5W+YPEqIHw0BCtVHRkvawCIdOxY?=
 =?us-ascii?Q?1C6T+oVRxqQcYjHawqv1HIBE98U03F75y/jIReTutLl62n1xeui3hla78G5/?=
 =?us-ascii?Q?KxrDQZ8SdHpPgVG3WKGor1yaA3+C91hAzw02Ia2rUZDekKGiPeXY+ZJeBHr6?=
 =?us-ascii?Q?/TjYOFGmSrWvigTXqjkkGOc8DF0dy4w5YdUkEY14OS2gQSISv/hP2rYy0nYN?=
 =?us-ascii?Q?1VS+a0r3Ovmcgvx+l59hb3jAJDruyS2SWaajP+1PNvcAZZrXiq9iLuK9fPui?=
 =?us-ascii?Q?89kqIxMa6NuFlBJFpHNnzFykPzY++BI0WhbqLZduTZtyuJ5E3zwBi6OfQpvo?=
 =?us-ascii?Q?6V4+EgIjdBc+R3hM9kUi7FMcpZxqgrgkkwMbs48OJO4TmIXJ193zNEEdaQk+?=
 =?us-ascii?Q?pcf1hYc7XL98q3AVgTSPq8IoJjZwcEaRTZjfI7DlQwuYmWae/nB4tunaWDrg?=
 =?us-ascii?Q?FB86r/h9uoegt/jVtVs/FWAWpwVfracs2fLa3IdL2dinMdzMXvzJOrH2J1KC?=
 =?us-ascii?Q?mKSH4nfj1zsQblDQYeLzesWngVCR0piBMcOvr6WMyiKA4ReqIv/ipSU8N6gm?=
 =?us-ascii?Q?180ESLBLOlFEekWPnycSjpGK3dK6HLzUJSy88tRMcLd2UPpycAmUVoNhAbZ5?=
 =?us-ascii?Q?bznH4VoeRwTr7BnXI+gZ9ku9Vx5RqP7uW2TNcYI6WuYkMwDJx+lRcd81S1QM?=
 =?us-ascii?Q?/hZcIx2vr6EkLXFvEYiO2wv+JRR4m0QVVlxdNr6aWC6LktI5yg/bBQpqcGkm?=
 =?us-ascii?Q?AOafnUj4proPKsQ6x24n+AR/RAFkuZswdk64UNkNX94Qxs4TpfvDsxREV2ar?=
 =?us-ascii?Q?6WnX/p0qbR9bpCz0z2YKnNdKTcW30Y/18IQghByG4JjnMfWJphvpXSZegAn1?=
 =?us-ascii?Q?QYphz596uZuVbTj3cuP+HIGc4mRRM2+eEhyP7LYYayLEeLBR2Hy8SD/kVPgY?=
 =?us-ascii?Q?om+z3s+LAqMXEhE6CzQgS3ACZEOr9IOgim5sSFtJUguDyFsDRIlv7DSMHg65?=
 =?us-ascii?Q?Er3IjbyCz7nu7jSe8rJTiVB6cF+kclq4fnAmByq3OqJO+Luf0NuJJifAETny?=
 =?us-ascii?Q?4efBaHu5r9nSJsW+8PqsvEweQUvg9/cVO6o4lenvdbKuOBW/aWuBqPHiA/z2?=
 =?us-ascii?Q?i2LhC8k4+6VieHQAvBuYZ8aQil4Kf5tShZ4RhkTCjBNUjdKnwciXvKfl8RBI?=
 =?us-ascii?Q?66TcBL2/2QyCza4ueTnPcOUGp+esz2bzcMyzn/5ibsBze8u15jSA4KXHvuPR?=
 =?us-ascii?Q?mo3qaPDHZXeoNd0/5cV1qKCB7oXADhQZ9iN0bmBTFPpReubkgv1QaqeU4pqF?=
 =?us-ascii?Q?KoVL8cdnU8sCKUP7OJI/6LXvvbpw3AVUGmz1qLwjtMZdKJuIfRx37O5bQH9t?=
 =?us-ascii?Q?3qNrHazTdZbKfiAlJdv/Mj+944U8oT9Tufb961s6?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5661e94-98c7-4ba0-0b1a-08dc36e76f4e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 16:24:41.3918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3UKRAIeI++ncYlDtYxm/4Iz7qR8R8VbmQQM111sk6XzX7VA0+W+cHsRVLeeOLYQdajpGVp9W3fPc8gbyPHSTnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9866

On Mon, Feb 26, 2024 at 05:07:26PM +0530, Manivannan Sadhasivam wrote:
> In order to add support for Hyper DMA (HDMA), let's refactor the existing
> dw_pcie_edma_find_chip() API by moving the common code to separate
> functions.
> 
> No functional change.
> 
> Suggested-by: Serge Semin <fancer.lancer@gmail.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/controller/dwc/pcie-designware.c | 52 +++++++++++++++++++++-------
>  1 file changed, 39 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 250cf7f40b85..193fcd86cf93 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -880,7 +880,17 @@ static struct dw_edma_plat_ops dw_pcie_edma_ops = {
>  	.irq_vector = dw_pcie_edma_irq_vector,
>  };
>  
> -static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
> +static void dw_pcie_edma_init_data(struct dw_pcie *pci)
> +{
> +	pci->edma.dev = pci->dev;
> +
> +	if (!pci->edma.ops)
> +		pci->edma.ops = &dw_pcie_edma_ops;
> +
> +	pci->edma.flags |= DW_EDMA_CHIP_LOCAL;
> +}
> +
> +static int dw_pcie_edma_find_mf(struct dw_pcie *pci)
>  {
>  	u32 val;
>  
> @@ -900,24 +910,27 @@ static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
>  	else
>  		val = dw_pcie_readl_dbi(pci, PCIE_DMA_VIEWPORT_BASE + PCIE_DMA_CTRL);
>  
> -	if (val == 0xFFFFFFFF && pci->edma.reg_base) {
> -		pci->edma.mf = EDMA_MF_EDMA_UNROLL;
> -
> -		val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
> -	} else if (val != 0xFFFFFFFF) {
> -		pci->edma.mf = EDMA_MF_EDMA_LEGACY;
> +	/* Set default mapping format here and update it below if needed */
> +	pci->edma.mf = EDMA_MF_EDMA_LEGACY;
>  
> +	if (val == 0xFFFFFFFF && pci->edma.reg_base)
> +		pci->edma.mf = EDMA_MF_EDMA_UNROLL;
> +	else if (val != 0xFFFFFFFF)
>  		pci->edma.reg_base = pci->dbi_base + PCIE_DMA_VIEWPORT_BASE;
> -	} else {
> +	else
>  		return -ENODEV;
> -	}
>  
> -	pci->edma.dev = pci->dev;
> +	return 0;
> +}
>  
> -	if (!pci->edma.ops)
> -		pci->edma.ops = &dw_pcie_edma_ops;
> +static int dw_pcie_edma_find_channels(struct dw_pcie *pci)
> +{
> +	u32 val;
>  
> -	pci->edma.flags |= DW_EDMA_CHIP_LOCAL;
> +	if (pci->edma.mf == EDMA_MF_EDMA_LEGACY)
> +		val = dw_pcie_readl_dbi(pci, PCIE_DMA_VIEWPORT_BASE + PCIE_DMA_CTRL);
> +	else
> +		val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
>  
>  	pci->edma.ll_wr_cnt = FIELD_GET(PCIE_DMA_NUM_WR_CHAN, val);
>  	pci->edma.ll_rd_cnt = FIELD_GET(PCIE_DMA_NUM_RD_CHAN, val);
> @@ -930,6 +943,19 @@ static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
>  	return 0;
>  }
>  
> +static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
> +{
> +	int ret;
> +
> +	dw_pcie_edma_init_data(pci);
> +
> +	ret = dw_pcie_edma_find_mf(pci);
> +	if (ret)
> +		return ret;
> +
> +	return dw_pcie_edma_find_channels(pci);
> +}
> +
>  static int dw_pcie_edma_irq_verify(struct dw_pcie *pci)
>  {
>  	struct platform_device *pdev = to_platform_device(pci->dev);
> 
> -- 
> 2.25.1
>