Received-SPF: pass (google.com: domain of linux-kernel+bounces-81947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 17:53:33 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Catalin Popescu <catalin.popescu@leica-geosystems.com>,
	hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de
Subject: Re: [PATCH net-next v2] net: phy: dp83826: disable WOL at init
Message-ID: <13a68356-235e-4945-8cf7-5b7a42b0bf46@lunn.ch>
References: <20240226162339.696461-1-catalin.popescu@leica-geosystems.com>
 <Zdy+Y8Mqs22yRrre@shell.armlinux.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zdy+Y8Mqs22yRrre@shell.armlinux.org.uk>

On Mon, Feb 26, 2024 at 04:37:55PM +0000, Russell King (Oracle) wrote:
> On Mon, Feb 26, 2024 at 05:23:39PM +0100, Catalin Popescu wrote:
> > Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> > introduced a regression in that WOL is not disabled by default for DP83826.
> > WOL should normally be enabled through ethtool.
> > 
> > Fixes: d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> > Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> 
> It seems rather interesting that WoL is disabled in the config_init()
> method - because this will be called when the PHY is attached to its
> network driver (reasonable I guess) but also at resume time - which
> means one can't just set the WoL mode once and that status will be
> preserved.
> 
> Maybe Andrew can clarify, but I thought once WoL was configured, that
> configuration should remain until the system is rebooted.

Yes, i noticed this as well.

d1d77120bc28 does change the behaviour, clearing WoL was dropped. As
you say, WoL was probably broken before d1d77120bc28 and it will still
be broken after this patch, so no real change there :-)

Catalin as a followup, could you please look at suspend/resume via
WoL. As Russell pointed out, if the machine is woken from suspend, we
expect the WoL settings to be kept. So WoL should be cleared on boot,
but not resume.

    Andrew