Received-SPF: pass (google.com: domain of linux-kernel+bounces-81948-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 11:53:23 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Minghuan Lian <minghuan.Lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v8 03/10] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup()
 API for drivers supporting PERST#
Message-ID: <ZdzCA262QssACk7+@lizhi-Precision-Tower-5810>
References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org>
 <20240224-pci-dbi-rework-v8-3-64c7fd0cfe64@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240224-pci-dbi-rework-v8-3-64c7fd0cfe64@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TiOammgPzRweGYingOgx4yXymRKsT3gBR4yNBfmYIwKJsHorNIEL/uRJ9CWw?=
 =?us-ascii?Q?xCnfl+QXKly3B6JWDEPRjTgau1w7UZBwAQq+D2XJg1IbT4YjBNQtNZVEUPaU?=
 =?us-ascii?Q?z+xu+ZTrP9aD/o23lIgUfa8YEgo9CYQmEpSmqPxrdHAIW9pZ/FvQNGn5O8zi?=
 =?us-ascii?Q?FGdpDK/I4BeTe5eu9pmhimbbbwzhXC0+SoGeeUbBNsYaFQH8/+boVyboRoMe?=
 =?us-ascii?Q?v1h2tFCe9X420QP1IlKm2e2GGHcrknvl3+yDE2GQV1AyMCnC8+3xnf+xOY2z?=
 =?us-ascii?Q?KjUE5lmW97YXeT4IK//UTLSnlBD//zDH53oKqdm6Rdr1cFfQPKYIQB2VJkmG?=
 =?us-ascii?Q?2wXKgH6McCLi2g0y/WSaWqT/Xs15/aSAa2+dPzxH5bZp3EoIRD7bMR1IV0Hr?=
 =?us-ascii?Q?e+xihS4eVgS2z7ubDXM22tAIcJo50D5G+5CmLDQo5yiOaNn77vU5wVq1DZ6v?=
 =?us-ascii?Q?UugH4SkiPBrdJRHC+aLjEXG1ZqqdNZFN4PRb2avibp78/JJm0+PL/h1M6vF3?=
 =?us-ascii?Q?S6bhyJVNdZ2YRpFnHKwjIQtCfV8TfJzlPN7xl7IB+xmFxOlZ+BVYPPQY64WA?=
 =?us-ascii?Q?7D4EW8auqYIIIpGO8misKh0HqLt4J1ulVLfVNBXCNXXGsfoVCh7FzsSAIYs8?=
 =?us-ascii?Q?8/e3JwDI2oJ20sXbCmploi/zyB/LVWnphsDrKgm0Gpgwf9lKM2Rj2kZzACqw?=
 =?us-ascii?Q?snU4qXnmMyGXPuohblyB45xVl0Omqdd6LOBZDJtZ3aMhZgEXLwWrAlVaoO3h?=
 =?us-ascii?Q?n4/yA/zpBIA1SOYMSELbpDTp2z+DM4sP2TBfMybbDKlm7BI0Iib0Pv4jum5h?=
 =?us-ascii?Q?b/XIzQWbnItXsY35oWjQL1V7cwE3wJ4IYjVo0WO+Vqb4GqS60zaq3rlCwPgc?=
 =?us-ascii?Q?Kc3E3TD8XjLPmRF3jv4b/2vMDUiaJ+AgVpNuRep/tJU8EvLBRyRMvBVeSwTi?=
 =?us-ascii?Q?awSwsXCKKzVz4JkNCnxSKp460HrrQUdjs057/nDCO/8CDTTnmaMFPyWSQz0Y?=
 =?us-ascii?Q?yhbTMY8xFCOdzOqvVZpjWIMVFlRpanYFIGLmNzUTJQV8y+OWfSCFD0tB8/i+?=
 =?us-ascii?Q?rcRC4+X2ImQBzrL6odT8ZVrZsjoJH7un/aSI6BsDS4sKbSww57b8qsjhYsQe?=
 =?us-ascii?Q?kl7Gx0LLynWGdP8W4pUtcoXopjcenCluwZV55LsMn00si29Daa7ot5+doPHE?=
 =?us-ascii?Q?3mnivY8BQFHzAFK2XKjmcrkDqK7cwwfjpX6qqBnSo0C4OvL+fJ6czx+7pcfW?=
 =?us-ascii?Q?LuB9cONxOGPYT61CDT6pmHrODa/LUqGNBD+NPyJXjyimzmlrJnhblMuY3nZa?=
 =?us-ascii?Q?cL4iXgR2LtdFy4/Cn9WWHSeVz1HyqCzQXz4wy3iHfuAEr3YIDDTFXs0z1eoo?=
 =?us-ascii?Q?i4XMfaFp2gAdidgNPkQdBdMwSwZxmTtAVV1E/KyR0CbQOZM2BxDZVHoSqugj?=
 =?us-ascii?Q?OC4ytrHJOceWNRFPsbtf0bU1VJcGQNqjVruL6ViRBDjxqH3OJzJg1Je0N+AO?=
 =?us-ascii?Q?CPFT50H6lxDCiIu4h1b+hwLZvob1+j+qbDb9zKP1FNwcJqVhmSPctZjh67SY?=
 =?us-ascii?Q?wphA3fXWHqCV2NwozzU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65731e56-445d-40cf-b62f-08dc36eb795c
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 16:53:36.2196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r8SlVvmA0qDpNjWzdNn5PU4keeywoAnkRK7d7yk+ytLUEtqyGCxTKmgXvJPzm8gTAcjuw+lBAe6+13aa0/7INQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7867

On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote:
> For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some
> of the DWC resources like eDMA should be cleaned up during the PERST#
> assert time.
> 
> So let's introduce a dw_pcie_ep_cleanup() API that could be called by these
> drivers to cleanup the DWC specific resources. Currently, it just removes
> eDMA.
> 
> Reported-by: Niklas Cassel <cassel@kernel.org>
> Closes: https://lore.kernel.org/linux-pci/ZWYmX8Y%2F7Q9WMxES@x1-carbon
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/controller/dwc/pcie-designware-ep.c | 11 +++++++++--
>  drivers/pci/controller/dwc/pcie-designware.h    |  5 +++++
>  drivers/pci/controller/dwc/pcie-qcom-ep.c       |  1 +
>  drivers/pci/controller/dwc/pcie-tegra194.c      |  2 ++
>  4 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 2b11290aab4c..1205bfba8310 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -564,12 +564,19 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no,
>  	return 0;
>  }
>  
> -void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)
> +void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep)
>  {
>  	struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> -	struct pci_epc *epc = ep->epc;
>  
>  	dw_pcie_edma_remove(pci);
> +}
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_cleanup);
> +
> +void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)
> +{
> +	struct pci_epc *epc = ep->epc;
> +
> +	dw_pcie_ep_cleanup(ep);
>  
>  	pci_epc_mem_free_addr(epc, ep->msi_mem_phys, ep->msi_mem,
>  			      epc->mem->window.page_size);
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index 61465203bb60..351d2fe3ea4d 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -672,6 +672,7 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep);
>  int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep);
>  void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep);
>  void dw_pcie_ep_deinit(struct dw_pcie_ep *ep);
> +void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep);
>  int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no);
>  int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,
>  			     u8 interrupt_num);
> @@ -705,6 +706,10 @@ static inline void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)
>  {
>  }
>  
> +static inline void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep)
> +{
> +}
> +
>  static inline int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no)
>  {
>  	return 0;
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index 36e5e80cd22f..59b1c0110288 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> @@ -507,6 +507,7 @@ static void qcom_pcie_perst_assert(struct dw_pcie *pci)
>  		return;
>  	}
>  
> +	dw_pcie_ep_cleanup(&pci->ep);
>  	qcom_pcie_disable_resources(pcie_ep);
>  	pcie_ep->link_status = QCOM_PCIE_EP_LINK_DISABLED;
>  }
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 7afa9e9aabe2..68bfeed3429b 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1715,6 +1715,8 @@ static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie)
>  	if (ret)
>  		dev_err(pcie->dev, "Failed to go Detect state: %d\n", ret);
>  
> +	dw_pcie_ep_cleanup(&pcie->pci.ep);
> +
>  	reset_control_assert(pcie->core_rst);
>  
>  	tegra_pcie_disable_phy(pcie);
> 
> -- 
> 2.25.1
>