Received: by 2002:ab2:644:0:b0:1ec:cbc4:63fb with SMTP id 4csp1152873lqn; Mon, 26 Feb 2024 09:07:01 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUsXt+/IiyLJnyjKqvPjms0JxFXW3FkAI+8oj7BX/ojRwJfdSjdLSwzJ3h+EcYC0I2UkrbZ1zsDnoXfvrUxsoM+6iupJz3sfJ6xufjZGw== X-Google-Smtp-Source: AGHT+IEHgAuqPJ9i+TuEfG29rwrHjRHVNEP9qpk2At8vgjHXM+GchEUz2mXHRJDJnY1etUfrrfE+ X-Received: by 2002:a05:6a20:6f8f:b0:19e:9b19:96c0 with SMTP id gv15-20020a056a206f8f00b0019e9b1996c0mr10938889pzb.7.1708967221391; Mon, 26 Feb 2024 09:07:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708967221; cv=pass; d=google.com; s=arc-20160816; b=BdaRU4dwmzqXuy7G9MKWw2+vkwG4bSYRlxX3uruUdZbIJwUWiH4dreqLOq3kz08JEi fML0j39WCPfs+RR2fJlhXOg6lxiZqo27djXHtRCJTTR5B03PC3EaaZ8Y8dNdn+pHvi4a WtFbLA9zWYwzVb3yag6dnUmyNyEsHr4IexrEeQEtKnyjv1kZUXAWtmIypfG8eSK2xq3l M9hnSUcVnrgAjim8EH4jjNGM+by8iGBSakI5zhHdPTLVJqYX0Xy8X3JuIfFjhy3lYIyD IC5ZQwmvD5JnwSg6iSiCP/tFMkeVsb0NaPEthpRy8Arpu9GZ48O7rB/0O0UQpkhvmvtW D4gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=BnzV55OD4paSLHHWMOLT6h78Hihtp+PS6WGkHp75ykY=; fh=NzJjl4FDts+kUom7+0B/MPZv97IDo4KvUt3EiWDtI54=; b=CAmRclliYn3lweVJjLBKMo1EoOoeKzHQfHqWyF1sgE4Cjsu9ZrykIyRe/Y1iniDqbK gtx3GDO+Na6Y1hc+pMX81EEec5OSFZiTV/5C6xhQxbRqg3q3MY0wK1l3JrX/TY3uXLsX nd2SzJyCk/eA0hqT//xUt8uBSfM4iQducbwHELqZZbQ2kRthn+T+iK+QkeL/GM0x7RsZ WSwrZGIQ+slL6OrlIRDSOm6nNbOtSSZTT1BcELvaYFD4nukLDZjdBP2aADjyHK7AuEXO trrsAWaa8wspZcS2+FApFeidKUaqtsGvNxDGIgsf24Mo/O4PBRoQa0tjIqYJs8hiUX69 T95A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=S2sBvFy2; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-81984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n18-20020a056a000d5200b006e08cf5f5f8si3941981pfv.3.2024.02.26.09.07.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:07:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=S2sBvFy2; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-81984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 634112888A3 for ; Mon, 26 Feb 2024 17:04:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F49F12EBE8; Mon, 26 Feb 2024 16:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S2sBvFy2" Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D387612EBE1; Mon, 26 Feb 2024 16:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708966467; cv=none; b=lzOgyYOuVNUhImG4zncjYKo/5gnSb70JiZx2krxIgpHbkM2BWxG4KL1JcZwwvWaGmQ0sKq92MHc3SbeFRPOw65xDMGp4lZQXEq9LWPWFcRQc9OIFJ32vz5vQOU4ZUPzO9XmHhspettgjYH0ex+jvGXCLOTVt8G6W1FdlQa5Boa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708966467; c=relaxed/simple; bh=FdvcmEth3nWDGT8wTmWx6XZvqkMjHNWouvLS/wNZZ3U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iwU3kP1ALWLJZ08euri4dA4DTnSbQ8+ywVIYg76N4IFf00yKRL3vJInJpxfgRoikQ6o2IoRqG1Qt3GcCvfEiAMcJYsJl9JrU0HA2CGkXK+3jhg5rVr8IUR23roEE4K5mHBk+l8Bx6gdDMPZuyYsA7xl+n+GRqbl0f45ogSG9pO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S2sBvFy2; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-412a74ebdfbso6046535e9.3; Mon, 26 Feb 2024 08:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708966464; x=1709571264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BnzV55OD4paSLHHWMOLT6h78Hihtp+PS6WGkHp75ykY=; b=S2sBvFy2/8gQK9+VVsjlCCqmxWbp14oAnd03rWTljcDgD8rf7wbXQAdt/TvcYxcyCA zqH2xgjZuogVISnKFldefkMWU+6ULw+4rnIiD9l5iVdUil/qu46+p5ve5S7ElhsZIfo2 s+YtNl+EL88GD47Ic0cnlzVoV1/5pn5Ocw46lp32QqYrO9qJ5GHLNnN7aXRD7cPX/uxn VJ4a12iBGINbDLTFW4xtYOdeEwj5IdvVX3OUEyT/9+iqJkhVe1qaIDTJvStsn+DoIwua Z5CDJrRB959d0OyikaKezKronjnH2khuMmDGuONdkyJSEbh/Hm8scrJpuoAEmuj7V1Rx p2qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708966464; x=1709571264; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BnzV55OD4paSLHHWMOLT6h78Hihtp+PS6WGkHp75ykY=; b=XLTjTiMYcshQKsfTC5weYMnHh+66ENlJk39M9ZW3f95p0XQq9SH/Cz5WOYEqzf1m12 Yz/bKmFyLyg//cDczq/UBRbUfSCj8EFDdgpF2v3NyBEgHZLwxjMU/Qn0SYu8vHtpxkbb S9o+Oj6j6fVxLkXrJQpv7T/IUkj1KQbLOADELPnh3voXxR17J1HD3MNlJaRQlPHNedWu VTamAVr3uXYYwlGax/b2zG8GlVo91goQV0SPSWIrrQkVZvAsb2cnsh6+Jt4qitdJoqr0 F9I7M9JoGIbzoQKMYD9kZeq0tjRWTx03COZ4hFRwFNDFlkcjMRX3agsPCLsDYsSmR+I1 gYcw== X-Forwarded-Encrypted: i=1; AJvYcCVM4AJ6WZqWWrYOc5EizXCPjXNC04o09iWS0S2vcHk2juSFBtctc8c5pXqmuyfCyIS/NNkwbuWZnYZbeevyCYCx7b+TMZ/EJeU1C0VNGRnyc4Vh7iGSzxG4fhLondRJLc6RYceTEMfN X-Gm-Message-State: AOJu0YyjNCG9a2bjfy/+rRKquzqoCLPNM6oNKrXoE7GiL5KWqXMbW6ap gTFh+RYdQZUlFW9J+vbt5XnwHn5O9SXx4pmkAqaSA1SXaVngJVL4 X-Received: by 2002:a05:600c:5d3:b0:412:8e82:9a5c with SMTP id p19-20020a05600c05d300b004128e829a5cmr5815167wmd.38.1708966464121; Mon, 26 Feb 2024 08:54:24 -0800 (PST) Received: from [192.168.20.170] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.gmail.com with ESMTPSA id f14-20020adff98e000000b0033cf60e268fsm8792121wrr.116.2024.02.26.08.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 08:54:23 -0800 (PST) Message-ID: <01a93bfd-c1a0-4b1f-b941-6c0d3de316f9@gmail.com> Date: Mon, 26 Feb 2024 17:54:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] clk: qcom: gcc-ipq5018: fix 'enable_reg' offset of 'gcc_gmac0_sys_clk' Content-Language: hu To: Kathiravan Thirumoorthy , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Gokul Sriram Palanisamy , Varadarajan Narayanan , Sricharan Ramabadhran Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240225-gcc-ipq5018-register-fixes-v1-0-3c191404d9f0@gmail.com> <20240225-gcc-ipq5018-register-fixes-v1-1-3c191404d9f0@gmail.com> <1ba0fe63-1892-4042-9e5f-b1cd18e760b8@quicinc.com> From: Gabor Juhos In-Reply-To: <1ba0fe63-1892-4042-9e5f-b1cd18e760b8@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 2024. 02. 26. 10:53 keltezéssel, Kathiravan Thirumoorthy írta: > > > On 2/25/2024 11:02 PM, Gabor Juhos wrote: >> The value of the 'enable_reg' field in the 'gcc_gmac0_sys_clk' >> clock definition seems wrong as it is greater than the >> 'max_register' value defined in the regmap configuration. >> Additionally, all other gmac specific branch clock definitions >> within the driver uses the same value both for the 'enable_reg' >> and for the 'halt_reg' fields. >> >> Due to the lack of documentation the correct value is not known. >> Looking into the downstream driver does not help either, as that >> uses the same (presumably wrong) value [1]. >> >> Nevertheless, change the 'enable_reg' field of 'gcc_gmac0_sys_clk' >> to use the value from the 'halt_reg' field so it follows the pattern >> used in other gmac clock definitions. The change is based on the >> assumption that the register layout of this clock is the same >> as the other gmac clocks. >> >> 1. >> https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4.r4/drivers/clk/qcom/gcc-ipq5018.c?ref_type=heads#L1889 > > > Reviewed-by: Kathiravan Thirumoorthy Thank you for the review! Regards, Gabor