Received: by 2002:ab2:644:0:b0:1ec:cbc4:63fb with SMTP id 4csp1158744lqn; Mon, 26 Feb 2024 09:14:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWB1J0Zsl48CSmYbJnouuvmTbbqL5/hQLod218IzyrHFy5SPJTxz45wYPRYaUOZXsdAMsnWp8A9MbBjL29Mtn7hwN1WFGAUYJwgK9i+rA== X-Google-Smtp-Source: AGHT+IFs4+CeSEVy5BCD5txW00a2rkgcK6oE8orLcoDM4UJ66v9xvD0Zkrl1FBfwZZB3HGWkIY2b X-Received: by 2002:a05:6512:3f4:b0:512:be4d:96d9 with SMTP id n20-20020a05651203f400b00512be4d96d9mr4374262lfq.5.1708967696561; Mon, 26 Feb 2024 09:14:56 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l11-20020a1709060e0b00b00a4324ec76f7si1523336eji.555.2024.02.26.09.14.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:14:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82018-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=LKdY0dNo; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-82018-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82018-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 46A4C1F2B605 for ; Mon, 26 Feb 2024 17:14:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 847AA1353F0; Mon, 26 Feb 2024 17:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LKdY0dNo" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A87912C55E; Mon, 26 Feb 2024 17:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967106; cv=none; b=rWofvR3vCtn64VyRba/A3o7UiNiZgFQZHJpsZUS8nGeXgyxoC1uwgfad2SEP4+pyns/EzHQPOWYtvZhV7a/xxajXNS9hs1EBVjzo++fmf8gUw7LsxM5uYPQKvn4tw0ZcNC+L8A53g7cwSfoiE6FoyfmxCffHrsiFoLZ3/SbLB6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967106; c=relaxed/simple; bh=MRsBgIxlb/4Wq6P8y8ODlq2nplU2xHNAakSQBx9Hqe8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uKcxylM0baurjMTspuJgLs8rLUsnndXcxDqgFlBgvco8j5dSd5A+/au5VtGVby5OcsaBKnnDKh3HEj/huOxkao0xINjYLfvEaERwcqhVJg7OS1YQplfk1xqbWLyjTOTGYC2sG3v/l0hDpfLzdOTTEQYYuwC6eB6MLSa0bvVX9ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LKdY0dNo; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708967106; x=1740503106; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MRsBgIxlb/4Wq6P8y8ODlq2nplU2xHNAakSQBx9Hqe8=; b=LKdY0dNo8EuSYIzbvJLkRlnZqXGkRLZ3Dl4j9E2hsG/MxJytbTBg3dDT m5R3Wnq3dIyEDgvi5wGRoPV6Z+3tXtapKt3POC/zPPOGJwcVh//gfNYA+ x27NCGZpVa3JJXafjlZq+YRpoWNnGcQTx/TpS/Hk0IE4A9OeW3jotdQWU /p7oov2nWbSL+3VrdV9Y+m2WTs/MHU9SQHgUP7UjZXDJDu3S3CaaoXTVz 5wNn+6Vp0r7juVh3pXLj/B+C48QHJ0qJWuJB2exnejijq/0wZ+7Me5C5k /Dny1RYE1mFB7QBCdQ+BxvasE+gNOGE372ItLRcYyV11Wq2JNxKC5cwlF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="13905916" X-IronPort-AV: E=Sophos;i="6.06,186,1705392000"; d="scan'208";a="13905916" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 09:05:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="913882130" X-IronPort-AV: E=Sophos;i="6.06,186,1705392000"; d="scan'208";a="913882130" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 09:05:00 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1reePR-00000007k7J-2SR5; Mon, 26 Feb 2024 19:04:57 +0200 Date: Mon, 26 Feb 2024 19:04:57 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin van der Gracht , Paul Burton Subject: Re: [PATCH v3 9/9] auxdisplay: Add driver for MAX695x 7-segment LED controllers Message-ID: References: <20240219170337.2161754-1-andriy.shevchenko@linux.intel.com> <20240219170337.2161754-10-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 26, 2024 at 05:01:46PM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 19, 2024 at 6:03 PM Andy Shevchenko > wrote: > > Add initial driver for the MAX6958 and MAX6959 7-segment LED > > controllers. .. > LGTM, so > Reviewed-by: Geert Uytterhoeven As per discussion, let consider maximum digits as a next feature coming later on. I'll take this tag, tell me if I shouldn't. Thank you! -- With Best Regards, Andy Shevchenko