Received: by 2002:ab2:644:0:b0:1ec:cbc4:63fb with SMTP id 4csp1161325lqn; Mon, 26 Feb 2024 09:18:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVX6p62noMlh9Ajor6rIWzLI/j4COm755RjwNK2WPEqalPmLKx4JU7G4ge8+Ud4XPRiAGlvnJwWW26QZjEi6exytxBY3BLMwmN7/4Ikcg== X-Google-Smtp-Source: AGHT+IF+hDpeCWxZyHojqqJgjhAFSOB/SyJHKG6COntixMrRvt5fp3EjC5Y9OHYwxQgSpFLIWddH X-Received: by 2002:a17:902:e752:b0:1dc:2d63:9bf6 with SMTP id p18-20020a170902e75200b001dc2d639bf6mr9826110plf.4.1708967916308; Mon, 26 Feb 2024 09:18:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708967916; cv=pass; d=google.com; s=arc-20160816; b=Io91k68kcojHA6HrcxBSHmc2KxmMQh5107QIvEQfuA6SEVGYqTCR6agEkN8ayuhkAk aSw02KvEid0RxPPKsVA1KdpK1DYPSxwLWgnYdwLYXmkoN9YlJpdoXxP48lX6WtYHn4uV f0df5QXTYxamLbF+bd2R7zaVOiYLXczLt7Z037xVVurf5esw4dShzdjrVZvbqf1JJtvK 3VbT9BTV4o0BbK/mbN+5px/RBdCz7+Vs5wpJrkoXsXAY/BhtOpB7t2vs3jnDh8Ku9l1E p04gWl5pgxpaTyC/DmyqaHVoX70Y7O/8jDOcBwKaeGv4APpIRIDgTwVFq88EY47kuw6j oQlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=I/hQUuxQxkgRF4bShVLMfZoPBj+Cztno3mv4Ida72ys=; fh=AROQU2KCH7NyZd+GSF5Ja6si3COSfc75C77I0os5n1k=; b=kS+04fCsVbnobhpaTRPL0u+KUX5MsOjiOkJfd8CkaGl/oeW4PVIsZ4eubtHyGhW25+ up6P+fZMyaaWgxQX8fvAufvn5KHwSdFHPLrFpK8rWQ8Qn2eUSbCxfbbcQly3UKWaly7V QHCCd0RlLfS6LAnNRo3GfudaO0icq9t+pEkFn2x2bZNfbzjeeUBvX+0bM4k5fR8t3Pn6 7AnHIJTRx0VJpgu6EohkvfmGjoc73uhGt49hqlQrUtlFHAlzIXfF/oMnjLd34YJSRX+G T0BZBopXl/s3jEt/h/EUElHxgdjiFOboR1xK5jMMELF5QfHuZzEzxUxyJvZVgWvK+y/+ sIow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lqm7Mvls; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=ociJqUVZ; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-82024-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82024-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p6-20020a170902ebc600b001dbb13a5b17si4042229plg.117.2024.02.26.09.18.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:18:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82024-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lqm7Mvls; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=ociJqUVZ; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-82024-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82024-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 00450291A17 for ; Mon, 26 Feb 2024 17:16:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D70213699E; Mon, 26 Feb 2024 17:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="lqm7Mvls"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="eRSBuzih"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="ociJqUVZ"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="u94fmCMp" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D6E12FB14; Mon, 26 Feb 2024 17:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967279; cv=none; b=i/VU6hUKLGyiCpeNMkhrBBj34oHk9en+nNbLFxyPOBJkbiw/AurZSH/aMh3KB3JOMiAsXZO4zknC+0NIpy2/VA8ph1TqSQBITuQX072x63nN0sA9rJPtV9FZHfDk7Jqa/YTIddudaWNfswSgrvSm1KAx2HDgYKCWzzr8OLYckcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967279; c=relaxed/simple; bh=Ghx+uTZbpHULPvh6J03M80Ievm3SPeqKg1tWQqLgkC0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VCG7T1KBwcBNBqyggVtI4P84natCsXV21woqOwUfhRxg0z5tZkeVynLJDFodFNbTQsj9RRYd6vjnm5l2wJtGgjoyrDSkpqlnyCNxmgSyxOR9drhm3SxyLHLNTnyTn2E4eg5pSLr6ifQU5angjI63Ymg3NGBer4j0FmUYanGDeFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=lqm7Mvls; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=eRSBuzih; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=ociJqUVZ; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=u94fmCMp; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EF93D22118; Mon, 26 Feb 2024 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708967275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/hQUuxQxkgRF4bShVLMfZoPBj+Cztno3mv4Ida72ys=; b=lqm7MvlsGMdOnV7A0DCBCbAnV9wVNi5sPkxcsjnwm2TAhHzd8yzvwP15LeL6zBp8IXkj5O prSheJklKGpTJ+aJQCX4tR4QzX2mn6cVUXIXWux9eBpu9v4ldmLgGy9ACqLYj6ubdQlNQI nEvhzpAuRiEYzN4D2nVMa8/AcLOqr4A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708967275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/hQUuxQxkgRF4bShVLMfZoPBj+Cztno3mv4Ida72ys=; b=eRSBuzihPxqq1qI7IGAwNDlGPDFZsp+5LrwDwZP3mNyRuPHOIwE5kJ1xirGZsg/vWFNFVY biRDN3OHE/W5sYAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708967274; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/hQUuxQxkgRF4bShVLMfZoPBj+Cztno3mv4Ida72ys=; b=ociJqUVZaiwOnBmsJApQrVY4NKPWiDHcA5fWKOpgbgF8u/X37yRgEV03Je0LR/cpuUh4gg 4xxXqFcnLMohgek80IiWqkkj7rgbHOiecdSK3MxD7nSEmhpghcM02lBglw3nANYNZPXew4 93jPhYxYQ5w7D/TlaBV/VKqkou/DNe8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708967274; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/hQUuxQxkgRF4bShVLMfZoPBj+Cztno3mv4Ida72ys=; b=u94fmCMpbUXFk4iD2JqDbDSQ8FuX0yXq4xZ/oLuHtIUtWTgurgpOaxcHwOU1mpLCtzWfcV BJbGD51qmCdM5gCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4DA5C13A58; Mon, 26 Feb 2024 17:07:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qbR1EmrF3GW7GgAAD6G6ig (envelope-from ); Mon, 26 Feb 2024 17:07:54 +0000 Message-ID: Date: Mon, 26 Feb 2024 18:07:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 15/36] lib: introduce support for page allocation tagging Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-16-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240221194052.927623-16-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ociJqUVZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u94fmCMp X-Spamd-Result: default: False [1.20 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.00)[43.76%]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_GT_50(0.00)[74]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linux.dev,suse.com,cmpxchg.org,suse.de,stgolabs.net,infradead.org,oracle.com,i-love.sakura.ne.jp,lwn.net,manifault.com,redhat.com,arm.com,kernel.org,arndb.de,linutronix.de,linux.intel.com,kernel.dk,soleen.com,google.com,gmail.com,chromium.org,linuxfoundation.org,linaro.org,goodmis.org,linux.com,lge.com,bytedance.com,akamai.com,android.com,vger.kernel.org,lists.linux.dev,kvack.org,googlegroups.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: 1.20 X-Rspamd-Queue-Id: EF93D22118 X-Spam-Level: * X-Spam-Flag: NO X-Spamd-Bar: + On 2/21/24 20:40, Suren Baghdasaryan wrote: > Introduce helper functions to easily instrument page allocators by > storing a pointer to the allocation tag associated with the code that > allocated the page in a page_ext field. > > Signed-off-by: Suren Baghdasaryan > Co-developed-by: Kent Overstreet > Signed-off-by: Kent Overstreet The static key usage seems fine now. Even if the page_ext overhead is still always paid when compiled in, you mention in the cover letter there's a plan for boot-time toggle later, so Reviewed-by: Vlastimil Babka