Received-SPF: pass (google.com: domain of linux-kernel+bounces-82045-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 12:20:41 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Minghuan Lian <minghuan.Lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic
 dw_pcie_ep_linkdown() API to handle LINK_DOWN event
Message-ID: <ZdzIada1H95ike0t@lizhi-Precision-Tower-5810>
References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org>
 <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?huUkPVnpUyh0aM7Vpj2zyAhlYXP9oDGxLgnQakr5kwp6+PrtNJcZgr9X23pK?=
 =?us-ascii?Q?hVnA25mASHnuFlwCgKl6JSSwNEZ1d1yO0swFP4MkFnJLtzdPbphNU5e2PyAm?=
 =?us-ascii?Q?h+hDDV16wtTNLGHanPczqU48HCwpvr3d5Mg3zKEHRqLvmjLaJVHyIUa6VzTj?=
 =?us-ascii?Q?IIE1RqJd6Z2FbxoriEifwaKAaDcVh/8yhKRNjg7wr4zSxu4B5NCbGUH9b/m3?=
 =?us-ascii?Q?1OPkFypFd1hM8XAqrmE/65b0XJm05iz8SQoyJieJBxuPdnwvo+Id9fd3nl1Y?=
 =?us-ascii?Q?q7mx0SHLmnyW2l/UXIhfSOUmkXUxVI0yS7ydFtLwPEJzdJDJr4LBwK/LYfLg?=
 =?us-ascii?Q?0THzYQhdr+WTJh4+NO8Hva0x76dJCjrkPGtT39Swufnne6bgv8ir4VflqIOj?=
 =?us-ascii?Q?3e+Wah4YZoolwqk+OAnQSD3AHAbJ3NP6exM01Geg5QgKZFp/pibIrQHlMf0d?=
 =?us-ascii?Q?6ogPbEcH3MSo8gIuSAblZ9cQg5AeE6NEe1cCIXHqECVjcpZmPq+bz6eBN67z?=
 =?us-ascii?Q?XhP5Ob86xDYh4L32olVwaFGydJWzBqjnwsvR5mIGp0v7NB1dpPyOrmS+RdDa?=
 =?us-ascii?Q?KJfmIZ5EL4gVwH0SNQ5rs2YDh84dmOmWpmIjpW8SW2/h60fP5VWLyH52EES7?=
 =?us-ascii?Q?xUSrqgDKCe/u00J7pzbcBksepMNmcu8HkDEMiuC+ohw5+oqWveOcCrmAN4tQ?=
 =?us-ascii?Q?/HknUCE2p+KGgMpw1dDQAb5XbEywwLT+yCtaZG7U/VxYAS1fbLL6J/P9jdz0?=
 =?us-ascii?Q?codhTa9biX2PQGs+7i3wl94pWo5e8IvioX/wH1RNstFzCE5IFQPcmrkpPy1O?=
 =?us-ascii?Q?avFmBFGCUdmn011Z+/pJaHFViMe6JQltyk4j+kdSJRsCyyaQ7yLyLHPdoq6z?=
 =?us-ascii?Q?a3xaZ104PuGgNXN8/ccS3+Nnxi0babGJHqkE5j8cqudraGT57HM2BQ3MZ0GI?=
 =?us-ascii?Q?kPT+4LfRtLJbjXptcYUs4TxFjRVrUmngjnajzJEirGJYnCTE++Wk1JULwyLR?=
 =?us-ascii?Q?TwK6BLf/a/5KKPRscvDT6kzidXm4PtifEIcJworBd8CU4Mro6nfc0bUY9v4m?=
 =?us-ascii?Q?r2JOHMq4uxnIehng/ptQJotqzb0H7rXKpGT2j8cLTPFFGvA/72bYVqDnc+9Q?=
 =?us-ascii?Q?y7uLOQB1A3efwQWhNbRni2JvfSXo4HYqwsVDnLdXBe19kqAJID90ZV53Pwy1?=
 =?us-ascii?Q?40h4BEhLwowiJb2Uz0nDNYHUJhpGbZNbBGt+m/cFJBCwIImOQAF+onMG7O2G?=
 =?us-ascii?Q?Ctm1um6iIi3HIEb87CCF6BbXR1AEY4UcNxi+F/8a4caQiXPCQh593AJox2E+?=
 =?us-ascii?Q?UzyapEuOd6Wxsf5c3uLXt/OlARWh5BamX9x4PQlA9K1+UQrgAifwTWA2GCgq?=
 =?us-ascii?Q?B6UnL14AM2v7s9hNrnzzpfOw/97oVRJ4GHkzaj/y2qvQE9ZZ4mkkopTDaNyf?=
 =?us-ascii?Q?7Z00WNmLQLpJQJajl2F21gwI2waxzfrBYzD71yc70CSt9AG9TahFvUpk0EO4?=
 =?us-ascii?Q?ycbdqbePzWz+RDpf3rYMOEViStEJjbOoQegDkzRblO0mC7tvCeZAmutqhpV4?=
 =?us-ascii?Q?jNayz6POCTBY252sc+vQzviT/YYU5NqzV6GtZtoh?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d231346e-b3db-442b-2a29-08dc36ef47a7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 17:20:50.9066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5qpDnloZGEdT1Wvh/qeTeurLfC/mYowsPCz603QEEtOFGsmbZQgZKFm+rZtpqnHIk4xKO/0F/OTenSFpkrx0pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8032

On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote:
> Now that the API is available, let's make use of it. It also handles the
> reinitialization of DWC non-sticky registers in addition to sending the
> notification to EPF drivers.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index 2fb8c15e7a91..4e45bc4bca45 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
>  	if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) {
>  		dev_dbg(dev, "Received Linkdown event\n");
>  		pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN;
> -		pci_epc_linkdown(pci->ep.epc);
> +		dw_pcie_ep_linkdown(&pci->ep);

Suppose pci_epc_linkdown() will call dw_pcie_ep_linkdown() ?
why need direct call dw_pcie_ep_linkdown() here?

Frank

>  	} else if (FIELD_GET(PARF_INT_ALL_BME, status)) {
>  		dev_dbg(dev, "Received BME event. Link is enabled!\n");
>  		pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED;
> 
> -- 
> 2.25.1
>