Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757697AbYABF7V (ORCPT ); Wed, 2 Jan 2008 00:59:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754706AbYABF7D (ORCPT ); Wed, 2 Jan 2008 00:59:03 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:49502 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754485AbYABF7A (ORCPT ); Wed, 2 Jan 2008 00:59:00 -0500 Date: Tue, 1 Jan 2008 22:00:06 -0800 From: Greg KH To: Alan Stern Cc: Andreas Mohr , Ingo Molnar , Alexey Dobriyan , Andrew Morton , David Woodhouse , "Eric W. Biederman" , Linus Torvalds , "Rafael J. Wysocki" , Pavel Machek , kernel list , netdev , Pavel Emelyanov , "Denis V. Lunev" , USB list Subject: Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage Message-ID: <20080102060006.GA27693@kroah.com> References: <20071231052500.GB4187@kroah.com> <20071231192643.GA25341@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071231192643.GA25341@kroah.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 39 On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: > On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > > On Sun, 30 Dec 2007, Greg KH wrote: > > > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > > he wrote debugfs in the first place! :-) > > > > > > Oh crap, sorry, I did mess that up :( Ok, no, I didn't write that patch, I'm getting very confused here. In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. In the -mm tree there is a patch, from Tony Jones, that moves some debug code out of sysfs and into debugfs where it belongs. It does it for both the ehci and ohci USB host controller drivers, and this is the code that is incorrect if CONFIG_DEBUGFS is not enabled. So, for the 2.6.24 release, nothing needs to be changed, all is good, and there is no regression. Right? Or am I still confused about this whole thing? I will go fix up Tony's patches in the -mm tree that do not handle the error return values from debugfs properly, but that is not such a rush, as Tony is on vacation for a few weeks, and those patches are going to be going in only after 2.6.24 is out. Hm, I wonder if this means I can go back to drinking more holiday wine... :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/