Received-SPF: pass (google.com: domain of linux-kernel+bounces-82073-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240223205535.307307-1-jaegeuk@kernel.org> <20240223205535.307307-2-jaegeuk@kernel.org>
 <68e95cb8-9bf5-4849-befc-bbbe8becfd68@kernel.org>
In-Reply-To: <68e95cb8-9bf5-4849-befc-bbbe8becfd68@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Mon, 26 Feb 2024 09:33:33 -0800
Message-ID: <CACOAw_yXZM6MsPpMYWeDSsOgehGSR3=OQc3aOjfMSF8xvn3RpQ@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 2/5] f2fs: fix write pointers all the time
To: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 25, 2024 at 6:49=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/2/24 4:55, Jaegeuk Kim wrote:
> > Even if the roll forward recovery stopped due to any error, we have to =
fix
> > the write pointers in order to mount the disk from the previous checkpo=
int.
>
> Jaegeuk,
>
> IIUC, we may lost warm node chain once we allocate new section for all lo=
gs,
> should we give some notification in log to indicate such condition that
> filesystem doesn't process a full recovery flow?
>
> Thanks,
>
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >   fs/f2fs/recovery.c | 2 +-
> >   fs/f2fs/super.c    | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> > index b3baec666afe..8bbecb5f9323 100644
> > --- a/fs/f2fs/recovery.c
> > +++ b/fs/f2fs/recovery.c
> > @@ -913,7 +913,7 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sb=
i, bool check_only)
> >        * and the f2fs is not read only, check and fix zoned block devic=
es'
> >        * write pointer consistency.
> >        */
> > -     if (!err && fix_curseg_write_pointer && !f2fs_readonly(sbi->sb) &=
&
> > +     if (fix_curseg_write_pointer && !f2fs_readonly(sbi->sb) &&
> >                       f2fs_sb_has_blkzoned(sbi)) {
> >               err =3D f2fs_fix_curseg_write_pointer(sbi);

We might overwrite the previous err value here with a new err from
f2fs_fix_curseg_write_pointer().

> >               if (!err)
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 2e41142d07c0..4d03ce1109ad 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -4673,7 +4673,7 @@ static int f2fs_fill_super(struct super_block *sb=
, void *data, int silent)
> >        * If the f2fs is not readonly and fsync data recovery succeeds,
> >        * check zoned block devices' write pointer consistency.
> >        */
> > -     if (!err && !f2fs_readonly(sb) && f2fs_sb_has_blkzoned(sbi)) {
> > +     if (!f2fs_readonly(sb) && f2fs_sb_has_blkzoned(sbi)) {
> >               err =3D f2fs_check_write_pointer(sbi);

ditto

> >               if (err)
> >                       goto free_meta;
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel