Received-SPF: pass (google.com: domain of linux-kernel+bounces-82036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <cb0c185c-54f8-4b43-856f-685cc5ed3fc4@oracle.com>
Date: Mon, 26 Feb 2024 17:13:44 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, masahiroy@kernel.org
References: <20240222145819.96646-1-john.g.garry@oracle.com>
 <Zddt-U-6SdxkxqmD@bombadil.infradead.org>
 <51483aaf-d64a-4eee-b256-ab126483ad6c@oracle.com>
 <Zdy9gKO5Q6K4IE8J@bombadil.infradead.org>
 <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZdzGF9bxLn3Slbgi@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Z1dWajIxTHM1TE1WVnlhZXp5SVUzS0lMSExkN3VDcElHQ3J0VnFXMGVtWDlk?=
 =?utf-8?B?ZDg0QmtjLy80ay95ejBLZjVuQk9VWi9lLzdJNjF0M09QK2FFZzMyb09sTjQ0?=
 =?utf-8?B?SVJpMG0vcys0Ky9LYXpBS0wxcHlTUFVtb25tN3RRejB0Tkx0bXhFR3JjaGR2?=
 =?utf-8?B?Z3JqUlFSY0R0VUFoclE3MnRvTUh1TUZ3K1hUNEJTazlwTmdNaUFXWVBZckZR?=
 =?utf-8?B?OVMweXVCRjZxWHJFQXRBalJmVzdQR0J1K1BPUGRJZXl2cW1hVkVPNVNiRjM0?=
 =?utf-8?B?aFVQcGtXdUE5dVpIQUtwUlhoVDczYkxIWXJQTVN5WnozWkFTUWx5T0NTdURO?=
 =?utf-8?B?dGgzSFdHb0hONm9aQ3R3VUdtdDNSUUw2SlZsM2ZzRjRabTVIdjJ1cWM2WWh0?=
 =?utf-8?B?TGRPVEE4dHR6b1RPUnhkUWFTTElSczd3ZmYraWFKcVhwUUthMzFJT0ZSM0Vm?=
 =?utf-8?B?TnVYOUd5ZlhyRGxGVU5XcTRpVjJ6VkYrUXhmU3RMYzExTGtSM21tVmYwb3VZ?=
 =?utf-8?B?WnN5TzAwUW9Qc1FWa0hPclAxNlRxcDkxMVRIKzg3TXorMFNWcWxuNmZ4YVJ2?=
 =?utf-8?B?Q2JIeGN1Y1dnMm85NkNXZXZlalNNcFBOdkVJd3VLZUtobzV5bDlpL2xBWlZC?=
 =?utf-8?B?cEtxdTlSV0VnSkRydVJlczExVTBuYzE2OTllMGM0c1Z2VFUxZ3RvYzZBMDN4?=
 =?utf-8?B?TE5DNFluUjhsNzhtdUZraFc3aUc3S0tLZ0NqRUZKWDF1WlMxRW1kTkNETDVW?=
 =?utf-8?B?Y2wyS3hsakdKUmNzckdER0c0WS9YV0s0UHJqdmU4WmkyK0VBeDc3ZHpmUk9R?=
 =?utf-8?B?VVRaVWlxdHczU0dXQmNNbmdYU0RXM2tCUkpPSmNoSVdzSEo5T3RNYjB1VjlW?=
 =?utf-8?B?R2tzWWxpM3Fxdm05TS9tQlpWYWMrMzN6Zlp6bFIwYXRNMEgzcUlyTW5SVXJP?=
 =?utf-8?B?WFVqZVFxYUY2aVFraFYvOTNvbEtEd0lLV1g5WTRzaTVLMVo5aFA2OEVBYUlE?=
 =?utf-8?B?cFJQTytBR3F1a0owTG1RYS9xZDAzSlNtcUVTK2dhYjJoMGFjaDNYd0dpRTcx?=
 =?utf-8?B?KzFrTmFqWWozeVRIRG5ldWsyUXdtK3poNjlBRG9RWWRsczRKdlRZMTdWZVFT?=
 =?utf-8?B?aitOOXM3ZWQ1QUpDMVc5MTU0WDdsbklhYy95VnI4MERQdjdiMnFGMjBsVnNL?=
 =?utf-8?B?SGJLK3dXWWhoMndraHdUWVUzWFRaL0JndGg1c0xmRHJEWkQ1M1BLbU40V0tV?=
 =?utf-8?B?RE9jSFZFRU1XQVl0dll3WnFqWUo0MnpQeTdRbG53WHpLQ1ArUGZBSXdDNFMv?=
 =?utf-8?B?V2FNcm94eFlxRmFGWXF4S0krV1dJbmFkeVdPT2o4WlY4VGhXVlZxZ2lOMUFG?=
 =?utf-8?B?TWRmVHJxQXk4TnhsWnQvOHYxL3FGQmRzRTRCYjk3UVlhdUtnMk5VeTBTVGI5?=
 =?utf-8?B?S2xhMFhXRFlnZ3dLVE13OXZwWmJIMENkQVNkNDFKNldJNlZMZ3hncnI1M1pQ?=
 =?utf-8?B?cGhBdUdRWXNWL2Fqc0M1V0JKWE1aZlJ3YW92RW9TeTM5dm1UeFRFRFduZi9x?=
 =?utf-8?B?TlpPN2MxZWF4cTZseGVYODBZWXlqejFwM3VBZmpiUTF6bk1HY0UvOGNOU1Bu?=
 =?utf-8?B?RThaMTNoaFExQTBHWXNCRndjeW5iWGxFWWF0dGt3a2tkWER5YlVOZFFXMDAw?=
 =?utf-8?B?UUU4c1NIRU5KVjl3RzVub25maXpodHJJdHF2QW83bkVXd3hnU0E0aFg0dG1n?=
 =?utf-8?B?UjZZN2ZtOTRLZ0dQcDdpZ3MxMFhGbDd6cStZbzB0ZU00RElDTENSOXdWZ0dQ?=
 =?utf-8?B?OU0wc1hQNkI5eU93YXVQaVdYU1hXa3BITUdMYXlnN0ZKdlZXMEprYVo5MFNS?=
 =?utf-8?B?MUkwQmsyWk5xa0xZK0VQMnBjclRmdDdCc2d6YWlEK2g5VmZIY2VhaUROYXdS?=
 =?utf-8?B?Q21HMGtiS3lxditqSlF1Y1MvUGpCUDZUaHNVMk1tbEhYL284K0VuL2tQOHh6?=
 =?utf-8?B?cFVNZ3cvOFQ4cCtzVUQybEQ2Q0ZISmg0QWVGZVhVei9XYk96SGFNV2pxQ0hH?=
 =?utf-8?B?aWczQ2ZlYWhXdDByR012MmtOMTdvR21FR1M5dU9sUkJ0Wkg0OGhwcFhUMEFK?=
 =?utf-8?B?MU5yY0tRaUZmT0Z2cnVEb0FCaEI2VHh6ZC84U2xwcDdKOWVVQ0hCb0FmTkJm?=
 =?utf-8?B?Z2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vRMobYM5yhLRoy7AkzxpKeJul5+rgUdWGCIUihuapmucJGdvx/q321Wnvr79ijhtIF98nvVIrDoCAH4ZBhxj84tJNMtb3fJ1URczJpbSgHDbZZKVO/GaNoeGBKxeiuuNdbRF36YGgbflMcC7LmZ1Q7UW4srkkP8td/tco3jVc3Ia1KpUVv7sUK207QIdwJVEg4wP2KPRTzLztrLbblunTl5Ld0yLGvtuc5WslouwnMBW+wZpNlpSwQYtnPTmzv+JDdrUrWqXPhE3DTl0d372yE4JKmLhQW1yIs5+L+VjzW2bzzWvulI2XXCN+TOkaKL7uUCH7VCk32k+Ug5OSIghO4zlhcIapk8gAcGvaewSLWm7R+VeKRKRc2Tv68PqUbkBPxZOiZ/b1gVqAUNfFQRCOClpsLNr9WV3HhNmIR6odjy5MBFaj/DLs1sbhO+cRUPND42mRd+hByzQj2xKGWLxz8wEc00DjvlTepGdUWDtFdpELhVRLmrTRZOBA53mn4MRSpNNQSYdL9aundexhurUZAAnlFNKYjzq0I5gr6bOtpJZep+7tEpgJceUlZMAJ7SLyJ4FMPPOp/Nl12gLPx5K2OK5/fphdBzOoC3DrjWtmk4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c8e2893-9927-44ef-f159-08dc36ee4baf
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 17:13:48.1652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJt1rWqoe7IPqI6cmkP7XlcXmqhpCkC/AQFmmgpSVjbieBtDnVi1k6zLoYlaoZikpUIRyDRi44VJal3SM39khw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4818
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402260131
X-Proofpoint-GUID: JA7KV-dm6XGiKaCpwkcv3aJWXaiKBu36
X-Proofpoint-ORIG-GUID: JA7KV-dm6XGiKaCpwkcv3aJWXaiKBu36

On 26/02/2024 17:10, Luis Chamberlain wrote:
>>> I am running this now, but it does not seem stable on a v6.8-rc5 baseline. I
>>> am seeing hangs. Are there any known issues?
>> I tested next-20240108 and so no issues.
>>
>> Lemme upgrade.
>>
>> Note you also need /lib/udev/rules.d/50-firmware.rules removed if
>> you have it.

I have this:
ubuntu@jgarry-ubuntu-bm5-instance-20230215-1843:~/mnt/linux2$ more 
/lib/udev/rules.d/50-firmware.rules
# stub for immediately telling the kernel that userspace firmware loading
# failed; necessary to avoid long timeouts with 
CONFIG_FW_LOADER_USER_HELPER=y
SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1"

So I can remove it.

> I don't see any hung tasks on next-20240226. Perhaps its with your
> config that it is triggered.
OK, I'll check again when I get a chance, but I am not so keen on 
checking linux-next in general.

Cheers,
John