Received-SPF: pass (google.com: domain of linux-kernel+bounces-82102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 11:50:28 -0600
From: David Vernet <void@manifault.com>
To: peterz@infradead.org
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	bsegall@google.com, bristot@redhat.com, vschneid@redhat.com,
	kernel-team@meta.com
Subject: Re: [PATCH v3 0/3] sched/fair: Simplify and optimize
 update_sd_pick_busiest()
Message-ID: <20240226175028.GA1903@maniforge>
References: <20240206043921.850302-1-void@manifault.com>
 <20240216194440.GA1682@maniforge>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mg56jdseInclq6ef"
Content-Disposition: inline
In-Reply-To: <20240216194440.GA1682@maniforge>
User-Agent: Mutt/2.2.12 (2023-09-09)


--mg56jdseInclq6ef
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 16, 2024 at 01:44:40PM -0600, David Vernet wrote:
> Hello Peter, hello Ingo,
>=20
> Friendly ping. Is there anything else required for this to land?

Hello,

Sending another ping.

Thanks,
David

>=20
> Thanks,
> David
>=20
> >=20
> > - In update_sd_lb_stats(), we're using a goto to skip a single if check.
> >   Let's remove the goto and just add another condition to the if.
> >=20
> > - In update_sd_pick_busiest(), only update a group_misfit_task group to
> >   be the busiest if it has strictly more load than the current busiest
> >   task, rather than >=3D the load.
> >=20
> > - When comparing the current struct sched_group with the yet-busiest
> >   domain in update_sd_pick_busiest(), if the two groups have the same
> >   group type, we're currently doing a bit of unnecessary work for any
> >   group >=3D group_misfit_task. We're comparing the two groups, and then
> >   returning only if false (the group in question is not the busiest).
> >   Othewise, we break, do an extra unnecessary conditional check that's
> >   vacuously false for any group type > group_fully_busy, and then always
> >   return true. This patch series has us instead simply return directly
> >   in the switch statement, saving some bytes in load_balance().
> >=20
> > ---
> >=20
> > v1: https://lore.kernel.org/lkml/20240202070216.2238392-1-void@manifaul=
t.com/
> > v2: https://lore.kernel.org/all/20240204044618.46100-1-void@manifault.c=
om/
> >=20
> > v2 -> v3:
> > - Add Vincent's Reviewed-by tags
> > - Fix stale commit summary sentence (Vincent)
> >=20
> > v1 -> v2 changes:
> >=20
> > - Split the patch series into separate patches (Valentin)
> > - Update the group_misfit_task busiest check to use strict inequality
> >=20
> > David Vernet (3):
> >   sched/fair: Remove unnecessary goto in update_sd_lb_stats()
> >   sched/fair: Do strict inequality check for busiest misfit task group
> >   sched/fair: Simplify some logic in update_sd_pick_busiest()
> >=20
> >  kernel/sched/fair.c | 19 ++++---------------
> >  1 file changed, 4 insertions(+), 15 deletions(-)
> >=20
> > --=20
> > 2.43.0
> >=20


--mg56jdseInclq6ef
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRBxU1So5MTLwphjdFZ5LhpZcTzZAUCZdzPZAAKCRBZ5LhpZcTz
ZNLIAQDT4f2WD1kjAIU1o2RGVd8W1WymVhO8TWz2J+WkU3QTrAD/UO9eSFBZARPn
lNCNqBk+RnThm4SvjVfhFV7OKSMA1gc=
=nOVC
-----END PGP SIGNATURE-----

--mg56jdseInclq6ef--