Received-SPF: pass (google.com: domain of linux-kernel+bounces-82103-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 09:51:07 -0800
From: Isaku Yamahata <isaku.yamahata@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v18 002/121] x86/virt/tdx: Export SEAMCALL functions
Message-ID: <20240226175107.GB177224@ls.amr.corp.intel.com>
References: <cover.1705965634.git.isaku.yamahata@intel.com>
 <88bcf53760c42dafb14cd9a92bf4f9243f597bbe.1705965634.git.isaku.yamahata@intel.com>
 <CABgObfYo0OaSXUYjQbn188y8JOAZGzD56TabdyENXAW6_Ca0Hw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABgObfYo0OaSXUYjQbn188y8JOAZGzD56TabdyENXAW6_Ca0Hw@mail.gmail.com>

On Thu, Feb 08, 2024 at 02:30:40PM +0100,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On Tue, Jan 23, 2024 at 12:54 AM <isaku.yamahata@intel.com> wrote:
> >
> > From: Kai Huang <kai.huang@intel.com>
> >
> > KVM will need to make SEAMCALLs to create and run TDX guests.  Export
> > SEAMCALL functions for KVM to use.
> >
> > Also add declaration of SEAMCALL functions to <asm/asm-prototypes.h> to
> > support CONFIG_MODVERSIONS=y.
> >
> > Signed-off-by: Kai Huang <kai.huang@intel.com>
> 
> I thought you were going to introduce builtin functions for SEAMCALLs
> needed by KVM, instead?

After I talked with Kai, I concluded to use the common function.
Probably for TDH.VP.ENTER, we'd like to use customized version to avoid
shuffling registers between struct tdx_module_args and KVM regs.  We can do it
later as optimization.
-- 
Isaku Yamahata <isaku.yamahata@linux.intel.com>