Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1461456rbb; Mon, 26 Feb 2024 09:58:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUbybIz7YVnQZC/y8X1OibWpIUgVQ/EqrK6nDNCnNxx7kHjl5lvVsFQSOyKSVmKpp9eeAvoYsbypqAa2DQ6X8AQ2DvoMjVgN6pK38DoRA== X-Google-Smtp-Source: AGHT+IE/IklfHXW2PpANWZSdZZ+lssP/DHHYKAy6UfS4lzAxq3ganb0C4z6FiSM6JaWop4gNUB14 X-Received: by 2002:ac8:5e08:0:b0:42e:4ed2:af4a with SMTP id h8-20020ac85e08000000b0042e4ed2af4amr8910702qtx.56.1708970300463; Mon, 26 Feb 2024 09:58:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708970300; cv=pass; d=google.com; s=arc-20160816; b=x0M3XgUMmqaWrkhXCgdH0jdZS4HPS0rcd0K4oSNZeI362IZMBdonAiFISkw5D5PJmO xBGvTX2cqqVeC6elpEbTspwJN9FDapmHKuy+TtfzmNWpMdWS0Ai9yqyTjp8FNTKwRJiG ovE6bcYyPKqsg4x3fHlQMCNlv9bYBZnqqBT7WU4x04YJX+WgrqEV9S6c6lfottdYBiGL Q9n1Bmj3kabPUDuqanWxRJhBWhckihlFm/Rnl4EUMknsg5Y7xQljfB7aa+gkg1ZpFTYY ose+dL5uL9u+0ic+G0qhp6qYWGbjkTGjSRzKk0oKwzwrzWnTl2uGZPpeb7CuwuUZ2c0t JTDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=PZQB8VCMnuRX8YdIqkn9P7hy9yYKe5YSv5Zi9Dt4DDI=; fh=lfXJ6puOi9CI09JW944m7qpUf7wYj83PjcZHlxHeG9M=; b=llMw/VW/j9OCYSRQNLNzXi8fO+FqvbzaqQQ8P+bxpNLJ637lzcsmK3B5CsWPvIeAiY 4QNtpLuwETF5Gukc13fGU6wpj9CteTyOXKBCbil4lIE+2sngccixU7GFgPVUvpuPW3At jRRAJZhSaZ3OJOioD2Mu+zJmHgDgjgdyMWYOJfyaqLHWjCV7c6AxiYw2w5K/W3Ry4dRd 8bzymtiXZ9gldZcgo3XhmldV8DsR5ybfGmwViK62lrDhP2yLBh3169Re6Vnk22cIiDr1 +1mnjOsEYYmyxMvN59XGCGw5bpEBCZxVqkPpkzGW2N3BbhCnGfZO9ByQppkK+NEPhxDJ QGLg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KnVScf5Q; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82110-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82110-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t19-20020ac87393000000b0042de7c0399bsi5423741qtp.181.2024.02.26.09.58.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:58:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82110-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KnVScf5Q; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82110-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82110-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3ADF11C2868A for ; Mon, 26 Feb 2024 17:58:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 31B3312EBE9; Mon, 26 Feb 2024 17:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KnVScf5Q" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5058F12C815; Mon, 26 Feb 2024 17:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708970292; cv=none; b=Lzkt90LDxsDZulFS+GHICudMXJGJhwF5vDGrPYC8QJpxkL2wUVuL88qGxZlhK4APRKuR1i4ZqD+/INC/Mee+dqCFTS8ab4ClWIDRPhHM3hxAZLpyMakpqIKpfHHhBp58T8OYFKIbcXeDymTXw7t65jZtdOu5DHMOzvrwqOCx3+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708970292; c=relaxed/simple; bh=mXtVnnZU5KldRH/xAQBuuqOy4rYUXPWyBCIe0Ahw4DY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h2UJydDXFW7o+mfSOwiytSMs+oelAiTAPuCtRW2qZnTQri8g30rMJL0QpUa/Ru10LFYn5M0XtrGdnpWm7CCk+Yct0DSviGiFIvRIpnCeceD/OGT4GjAG3SpeF5Ahzz0HCPLv5fUu643gwkfKYI+WP76X8EBom1pZJ5rEff1Wttk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KnVScf5Q; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6668C433C7; Mon, 26 Feb 2024 17:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708970291; bh=mXtVnnZU5KldRH/xAQBuuqOy4rYUXPWyBCIe0Ahw4DY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KnVScf5Ql39ByDTDraRO5HJefp1ts2WNx7YSyg0S473pWGzF+mUaYmexthRZAvHRG MXnsLGH1IZSftf29Pq1zDBIGpMW16NEjMuTDdbdnocr0Z4jLwo++AH5420p4XkbLck muptFsm3DmCIUHMjeaVNJB1ou69kCgFcvxQWZLCp0sN39JESkafDLiKs/J6OB1xhRD yLqoAgb1h7bYehmhJg34m64npHE9AW7yAI/C3Xo8mVbEs+kaE4Uy2EPK5Tc0Y8bBQ8 p3vc6PjkQNWScqRv47Kl+eo+2G0KvqZEdOKnn/zbQ3Jf1RQXFXv0fWdINNF8uePaXt 13AXreIPxRUEQ== Date: Mon, 26 Feb 2024 17:58:06 +0000 From: Simon Horman To: "Matthieu Baerts (NGI0)" Cc: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Westphal , Kishen Maloor , Shuah Khan , Peter Krystad , Christoph Paasch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path Message-ID: <20240226175806.GI13129@kernel.org> References: <20240223-upstream-net-20240223-misc-fixes-v1-0-162e87e48497@kernel.org> <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223-upstream-net-20240223-misc-fixes-v1-10-162e87e48497@kernel.org> On Fri, Feb 23, 2024 at 05:14:20PM +0100, Matthieu Baerts (NGI0) wrote: > From: Paolo Abeni > > The mptcp diag interface already experienced a few locking bugs > that lockdep and appropriate coverage have detected in advance. > > Let's add a test-case triggering the relevant code path, to prevent > similar issues in the future. > > Be careful to cope with very slow environments. > > Note that we don't need an explicit timeout on the mptcp_connect > subprocess to cope with eventual bug/hang-up as the final cleanup > terminating the child processes will take care of that. > > Signed-off-by: Paolo Abeni > Reviewed-by: Matthieu Baerts (NGI0) > Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman