Received-SPF: pass (google.com: domain of linux-kernel+bounces-82116-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <62200490-6dcb-4c35-b358-b9c63e580787@amd.com>
Date: Mon, 26 Feb 2024 12:02:33 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH 3/4] selftests/resctrl: Add support for MBM and MBA tests
 on AMD
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: fenghua.yu@intel.com, shuah@kernel.org,
 LKML <linux-kernel@vger.kernel.org>, linux-kselftest@vger.kernel.org,
 =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>,
 peternewman@google.com, eranian@google.com
References: <cover.1708637563.git.babu.moger@amd.com>
 <cc22790173de9978a6485baca5bc96a8ad8e05a4.1708637563.git.babu.moger@amd.com>
 <6f611a0a-f2ef-1017-07c0-5d805abb80d4@linux.intel.com>
 <efab7efe-d043-448e-bc7e-4a756b4f3367@amd.com>
 <fd71d5f7-08b8-4042-b94a-e81cc68c975b@amd.com>
 <9f814712-7189-424b-9af2-67f565dc35f2@intel.com>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <9f814712-7189-424b-9af2-67f565dc35f2@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d1Y1SFZjZ0hlUS9ESGlsYUxSa3k2N3V6a1lpNDQ1Z2lKcnR3UUMvcWkrSzF4?=
 =?utf-8?B?V2xvVWtNQ1UxQ0pPSEhkTEp1elp2QWFNNHZqbUtTbVBDQ2dPQlQrdWZiZGdQ?=
 =?utf-8?B?MkVRc1EwYmVycmxYNk9pME4yNTh3N1k5V09jamI4d3FpWHlQSVZjK0R6dzBh?=
 =?utf-8?B?b2k5Sjh6S2hrR1p1bWpQa3ByVFVSSmtqRFpwNkFNaUt1TVBwTWhIMSticHVQ?=
 =?utf-8?B?S3g0MjBjZllvQ0EyclNFUDJnV1lNNVA5a0IvODlJa1VvU0pTYWFBS0h3RW55?=
 =?utf-8?B?cU9qbnlzZ1BTVTM4dTdBQUF5UkM2aHN4ZzBwTDFsQ3Vxd0U2QlFrd1RBaFov?=
 =?utf-8?B?NFBvMHpWZ1hGZWF2SlEzU3k5dDd1b3VTeFBlTHhpN2NxWktDbUNubXRRVUhC?=
 =?utf-8?B?THY1UXBIU1R4UmVBRFY4WGk0ZUNDcmlvaDVVeEdZN1RDK3NXOEdXRFpNZkZK?=
 =?utf-8?B?a2ZMMWEyQzJqYkNiWDJRR2cvMFBKRHp4eERrNEJ1VkltdzNHVWUxL3hNM1JV?=
 =?utf-8?B?b0lHTU5BaURBenRJYzVOUnNKZlNqVHhCSlBFTkwrY290YXlRbXJGckhMTml0?=
 =?utf-8?B?RHJyWjZrK1NxVmdlditUY1RBMnBwci83UmdkWlFrL3o0b2gxYjZuNDdGSVZo?=
 =?utf-8?B?MjQ4SHlqMDhIeGJBTDliS2lBY1VlejFKRy9MdGpNTkZCNGhXdkszVGN4cUdn?=
 =?utf-8?B?L2RZZ0FjSzlCOUxtSGlWTXdia2VJTy9tU0lnQ1Izbk0zcnhiRXcwb1I5WFFD?=
 =?utf-8?B?OVcrUStSNFRzSktuK2hVTHd3SGlTRTV6TjhlOUZ6NHBEUHBIZjg1QzVYTjFL?=
 =?utf-8?B?ZTFRWDhwVTEvai9rTi9RMlhJTStxajdDcFljbkk0cXN5Y0NVZytHN2xyUElM?=
 =?utf-8?B?bktNOHd0YStPS3ViOGlsdGJGUE5MNWJ5UUdVTllIMEQ4bk13ZGh4a3FUYUhP?=
 =?utf-8?B?SU85YlhDZFdXOHdMbDdsczJidlNjK0ppZENuR2toU3ZwL3FIS0lmQlUvWERP?=
 =?utf-8?B?cG83dTNPT25PSUN2aWdWVE5YOE1GV3BOaVlKTHprZkZEbXVoR1hHOEY5bFR5?=
 =?utf-8?B?eldwbUF4eGpJZmpvN3UvTnVmQ043c2tHV3lVZXJ3U1oxMTZ1dUdqTWNPSDBo?=
 =?utf-8?B?OXpCQ2ZkQytVYUhsT0FSRVYvUGFEaTVDSFZnTUVtQXd0TElJdmtDRDFrdjdv?=
 =?utf-8?B?NXhQWFdBRU04VkZBMEFCVHRZRzkyYmM2UkFLSXoxUE5NNXhzckhBT2VxTyto?=
 =?utf-8?B?R1JQMFRPTGNHKzVXSjV3YkZPWDVUcXVuUWNEN1ovQjVwVjJFd2ZDNTc4R1ln?=
 =?utf-8?B?MDExUWtFcWJFcFZ6eHBYR3dQOElTTVd4RHdvVHdGT3MwY1VOZWRRYmdhVWVL?=
 =?utf-8?B?SlQ3NElvZkk1R0hQVTFick0vckhZVFIyU1RXZEE5a2RpMDQ4TzdtN0I4b2t5?=
 =?utf-8?B?aDNYOXZyL2R2cFpYQ3lCbXluK0ZsNUl4WEhQUnJYR1d1SDYrdG8wWFpyVm9G?=
 =?utf-8?B?aUF5em1ZVmdXZk9NcVJ0czhqYmRJaW9tMGxWUXJTZVlSVi9Eb1pERUtoT3Ft?=
 =?utf-8?B?SnVhTzZjcFpXU2p3TDFiamVOd3JuVkFvUDFpYURxNjIvUTNvblJIc2hwTS8v?=
 =?utf-8?B?bWpDdEJ6NmNVVGx0RzZXWlFISzUyZmkxN21YQko3aEJpc3R1MHBxVGVic2lU?=
 =?utf-8?B?NlUwdHRQWjIva3hrbUVtOVdSTmtEaDBpYUd5a3ZWczdVTXJ0U0xUTkNEelZ3?=
 =?utf-8?B?Y3pIcGttb2tVVkcrb2orV1RteUlRRWpZK2xhb3I3N01nYllCV0ZucGhraHBW?=
 =?utf-8?B?Z2RRcW1tUkIxWDBNVC8yVEFjRUw0Sm0wdkZVWFdqSDJveUJ3UDJtSkdKZFJF?=
 =?utf-8?B?SkQ4L0FyV3J1U2JyOU4yWFZqN3A3Q0FzYVhhSzZ5cVRIcC9RbnV5RGNKNWR6?=
 =?utf-8?B?cExvQmpXUU9tMzd0VDdtSk9zWUdaUlBrZ2h1MzY5V2RqMjliZXFQdmhqZmFO?=
 =?utf-8?B?NUZrNklNcjVvTFZVSDY5WjRYaVBUY1NscW1nSXhCYlpmUG5MaDkrczR2UXJk?=
 =?utf-8?B?T2hZQjdsTjNoclMxRE1PRncrOXpDSDRpWW9EckdnMXd0SGxGbkpCRVpHM1p5?=
 =?utf-8?Q?y9h0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c63e459-371d-4457-193c-08dc36f51c73
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 18:02:35.3368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgL7Jc49W3KC53bXXRstJoX+ElaZM6F3YYdUXMKCdVGoAHcPxGf+Qt7Yi2qfdB2G
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8093

Hi Reinette

On 2/23/24 16:39, Reinette Chatre wrote:
> Hi Babu,
> 
> On 2/23/2024 11:47 AM, Moger, Babu wrote:
>> On 2/23/24 13:30, Moger, Babu wrote:
>>> On 2/23/24 04:53, Ilpo Järvinen wrote:
>>>> On Thu, 22 Feb 2024, Babu Moger wrote:
>>>>> @@ -131,8 +130,7 @@ static void run_mba_test(const char * const *benchmark_cmd, int cpu_no)
>>>>>  	}
>>>>>  
>>>>>  	if (!validate_resctrl_feature_request("MB", NULL) ||
>>>>> -	    !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes") ||
>>>>> -	    (get_vendor() != ARCH_INTEL)) {
>>>>> +	    !validate_resctrl_feature_request("L3_MON", "mbm_local_bytes")) {
>>>>>  		ksft_test_result_skip("Hardware does not support MBA or MBA is disabled\n");
>>>>>  		goto cleanup;
>>>>>  	}
>>>>
>>>> These need to be rebased as this code moved into per test files with the 
>>>> generic test framework. The .vendor_specific field is the new way to make 
>>>> tests limited to particular vendors.
>>>
>>> Hmm. I picked the latest code from tip/master. Where is the latest code
>>> now? Is it yet to be submitted?
>>>
>>> I can wait for your code to merge first.
>>
>> Oh. ok. Here it is
>> https://lore.kernel.org/lkml/cover.1708072203.git.maciej.wieczor-retman@intel.com/
>>
>> I will rebase it on top of this next revision.
> 
> The resctrl selftest changes are routed through the kselftest repo. Shuah just picked
> up this series you noticed but it is based on the framework changes from Ilpo that
> is already merged. I recommend that you base your next series on the "next" branch
> of the kselftest repo [1].

Sure. Will do.
> 
> Reinette
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

-- 
Thanks
Babu Moger