Received-SPF: pass (google.com: domain of linux-kernel+bounces-82129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240223175116.2005407-1-jbrunet@baylibre.com>
 <20240223175116.2005407-7-jbrunet@baylibre.com>
 <a828b4f7-282b-4b83-9a64-04557edf9b6a@sirena.org.uk>
User-agent: mu4e 1.10.8; emacs 29.1
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>, Liam Girdwood
 <lgirdwood@gmail.com>, alsa-devel@alsa-project.org,
 linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/6] ASoC: meson: axg-fifo: use FIELD helpers
Date: Mon, 26 Feb 2024 19:15:41 +0100
In-reply-to: <a828b4f7-282b-4b83-9a64-04557edf9b6a@sirena.org.uk>
Message-ID: <1j4jdvdr5l.fsf@starbuckisacylon.baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


On Mon 26 Feb 2024 at 15:42, Mark Brown <broonie@kernel.org> wrote:

> [[PGP Signed Part:Undecided]]
> On Fri, Feb 23, 2024 at 06:51:12PM +0100, Jerome Brunet wrote:
>
>> Use FIELD_GET() and FIELD_PREP() helpers instead of doing it manually.
>
> This breaks the build for me:
>
> /build/stage/linux/sound/soc/meson/axg-fifo.c: In function =E2=80=98axg_f=
ifo_pcm_hw_para
> ms=E2=80=99:
> /build/stage/linux/sound/soc/meson/axg-fifo.c:149:28: error: implicit dec=
laratio
> n of function =E2=80=98FIELD_PREP=E2=80=99 [-Werror=3Dimplicit-function-d=
eclaration]
>   149 |                            FIELD_PREP(CTRL0_INT_EN, irq_en));
>       |                            ^~~~~~~~~~
> /build/stage/linux/sound/soc/meson/axg-fifo.c: In function =E2=80=98axg_f=
ifo_pcm_irq_blo
> ck=E2=80=99:
> /build/stage/linux/sound/soc/meson/axg-fifo.c:207:18: error: implicit dec=
laratio
> n of function =E2=80=98FIELD_GET=E2=80=99 [-Werror=3Dimplicit-function-de=
claration]
>   207 |         status =3D FIELD_GET(STATUS1_INT_STS, status);
>       |                  ^~~~~~~~~
> cc1: all warnings being treated as errors

Ah, I forgot to include <linux/bitfield.h>. Thanks for letting me know.
I'll fix it

It was fine when I tested with ARCH=3Darm64 and the default defconfig so
most likely it got indirectly included.

Could you tell me which ARCH/defconfig triggered this ?

>
> [[End of PGP Signed Part]]


--=20
Jerome