Received-SPF: pass (google.com: domain of linux-kernel+bounces-82141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Tejun Heo <htejun@gmail.com>
Date: Mon, 26 Feb 2024 08:30:40 -1000
From: Tejun Heo <tj@kernel.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: jiangshanlai@gmail.com, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org, allen.lkml@gmail.com,
	kernel-team@meta.com
Subject: Re: [PATCH 12/17] workqueue: Implement disable/enable for (delayed)
 work items
Message-ID: <ZdzY0OZIsRqmi41A@slm.duckdns.org>
References: <20240216180559.208276-1-tj@kernel.org>
 <20240216180559.208276-13-tj@kernel.org>
 <ZdwIoyRllkjnSTAH@boqun-archlinux>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdwIoyRllkjnSTAH@boqun-archlinux>

Hello,

On Sun, Feb 25, 2024 at 07:42:27PM -0800, Boqun Feng wrote:
> > +bool enable_work(struct work_struct *work)
> > +{
> > +	struct work_offq_data offqd;
> > +	unsigned long irq_flags;
> > +
> > +	work_grab_pending(work, 0, &irq_flags);
> > +
> > +	work_offqd_unpack(&offqd, *work_data_bits(work));
> > +	work_offqd_enable(&offqd);
> > +	set_work_pool_and_clear_pending(work, offqd.pool_id,
> > +					work_offqd_pack_flags(&offqd));
> > +	local_irq_enable();
> 
> Maybe
> 	local_irq_restore(irq_flags);
> 
> ?
> 
> Because in a later patch, you make this funciton callable in any
> context, so it may be called with irq disabled.

Yeah, Lai already pointed that out. Will send out an updated patchset later.

Thanks.

-- 
tejun