Received-SPF: pass (google.com: domain of linux-kernel+bounces-82152-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 26 Feb 2024 10:46:54 -0800
From: Isaku Yamahata <isaku.yamahata@linux.intel.com>
To: Yuan Yao <yuan.yao@linux.intel.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
	Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v18 001/121] x86/virt/tdx: Export TDX KeyID information
Message-ID: <20240226184654.GG177224@ls.amr.corp.intel.com>
References: <cover.1705965634.git.isaku.yamahata@intel.com>
 <fed47cd35b32ee66f7ec55bdda6ccab12c139e85.1705965634.git.isaku.yamahata@intel.com>
 <20240201015729.6n5uavy7rxdjtqwc@yy-desk-7060>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240201015729.6n5uavy7rxdjtqwc@yy-desk-7060>

On Thu, Feb 01, 2024 at 09:57:29AM +0800,
Yuan Yao <yuan.yao@linux.intel.com> wrote:

> On Mon, Jan 22, 2024 at 03:52:37PM -0800, isaku.yamahata@intel.com wrote:
> > From: Kai Huang <kai.huang@intel.com>
> >
> > Each TDX guest must be protected by its own unique TDX KeyID.  KVM will
> > need to tell the TDX module the unique KeyID for a TDX guest when KVM
> > creates it.
> >
> > Export the TDX KeyID range that can be used by TDX guests for KVM to
> > use.  KVM can then manage these KeyIDs and assign one for each TDX guest
> > when it is created.
> >
> > Each TDX guest has a root control structure called "Trust Domain Root"
> > (TDR).  Unlike the rest of the TDX guest, the TDR is protected by the
> > TDX global KeyID.  When tearing down the TDR, KVM will need to pass the
> > TDX global KeyID explicitly to the TDX module to flush cache associated
> > to the TDR.
> >
> > Also export the TDX global KeyID for KVM to tear down the TDR.
> >
> > Signed-off-by: Kai Huang <kai.huang@intel.com>
> 
> The variables exported by this patch are used first time in patch 18 IIUC...
> So how about move this one just before the patch 18 ?

With v19, I put those tdx host patches in the first part.
-- 
Isaku Yamahata <isaku.yamahata@linux.intel.com>