Received-SPF: pass (google.com: domain of linux-kernel+bounces-82160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 10:48:52 -0800
From: Isaku Yamahata <isaku.yamahata@linux.intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
	Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v18 007/121] KVM: VMX: Reorder vmx initialization with
 kvm vendor initialization
Message-ID: <20240226184852.GH177224@ls.amr.corp.intel.com>
References: <cover.1705965634.git.isaku.yamahata@intel.com>
 <411a0b38c1a6f420a88b51cabf16ee871d6ca80d.1705965634.git.isaku.yamahata@intel.com>
 <413fd812-a6e6-4aff-860a-fd8cf4654157@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <413fd812-a6e6-4aff-860a-fd8cf4654157@intel.com>

On Thu, Feb 01, 2024 at 05:34:44PM +0800,
Xiaoyao Li <xiaoyao.li@intel.com> wrote:

> > diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
> > index 18cecf12c7c8..443db8ec5cd5 100644
> > --- a/arch/x86/kvm/vmx/main.c
> > +++ b/arch/x86/kvm/vmx/main.c
> > @@ -171,7 +171,7 @@ struct kvm_x86_init_ops vt_init_ops __initdata = {
> >   static int __init vt_init(void)
> >   {
> >   	unsigned int vcpu_size, vcpu_align;
> > -	int cpu, r;
> > +	int r;
> >   	if (!kvm_is_vmx_supported())
> >   		return -EOPNOTSUPP;
> > @@ -182,18 +182,14 @@ static int __init vt_init(void)
> >   	 */
> >   	hv_init_evmcs();
> > -	/* vmx_hardware_disable() accesses loaded_vmcss_on_cpu. */
> > -	for_each_possible_cpu(cpu)
> > -		INIT_LIST_HEAD(&per_cpu(loaded_vmcss_on_cpu, cpu));
> > -
> > -	r = kvm_x86_vendor_init(&vt_init_ops);
> > -	if (r)
> > -		return r;
> > -
> >   	r = vmx_init();
> >   	if (r)
> >   		goto err_vmx_init;
> > +	r = kvm_x86_vendor_init(&vt_init_ops);
> > +	if (r)
> > +		goto err_vendor_init;
> > +
> 
> we cannot simply change the calling order of vmx_init() and
> kvm_x86_vendor_init(). There is dependency between them.
> 
> e.g.,
> 
> kvm_x86_vendor_init()
>   -> ops->hardware_setup()
> 	-> vmx_hardware_setup()
> 
> will update 'enable_ept' based on hardware capability (e.g., if the hardware
> support EPT or not), while 'enable_ept' is used in vmx_init().

I gave up this clean up to drop this patch with v19.
-- 
Isaku Yamahata <isaku.yamahata@linux.intel.com>