Received-SPF: pass (google.com: domain of linux-kernel+bounces-82181-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240223205535.307307-1-jaegeuk@kernel.org> <20240223205535.307307-3-jaegeuk@kernel.org>
In-Reply-To: <20240223205535.307307-3-jaegeuk@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Mon, 26 Feb 2024 11:03:20 -0800
Message-ID: <CACOAw_x1CtXDm5zf+e5y9PZfWY7rCVc5+Cpg6Hr01q3QJSyJ+Q@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: print zone status in string and some log
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 12:56=E2=80=AFPM Jaegeuk Kim <jaegeuk@kernel.org> w=
rote:
>
> No functional change, but add some more logs.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/segment.c | 34 ++++++++++++++++++++++++----------
>  fs/f2fs/super.c   |  1 +
>  2 files changed, 25 insertions(+), 10 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index d4f228e6f771..6d586ae8b55f 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -4912,6 +4912,16 @@ static int sanity_check_curseg(struct f2fs_sb_info=
 *sbi)
>  }
>
>  #ifdef CONFIG_BLK_DEV_ZONED
> +const char *f2fs_zone_status[BLK_ZONE_COND_OFFLINE + 1] =3D {
> +       [BLK_ZONE_COND_NOT_WP]          =3D "NOT_WP",
> +       [BLK_ZONE_COND_EMPTY]           =3D "EMPTY",
> +       [BLK_ZONE_COND_IMP_OPEN]        =3D "IMPLICITE_OPEN",
> +       [BLK_ZONE_COND_EXP_OPEN]        =3D "EXPLICITE_OPEN",
> +       [BLK_ZONE_COND_CLOSED]          =3D "CLOSED",
> +       [BLK_ZONE_COND_READONLY]        =3D "READONLY",
> +       [BLK_ZONE_COND_FULL]            =3D "FULL",
> +       [BLK_ZONE_COND_OFFLINE]         =3D "OFFLINE",
> +};
>
>  static int check_zone_write_pointer(struct f2fs_sb_info *sbi,
>                                     struct f2fs_dev_info *fdev,
> @@ -4928,18 +4938,22 @@ static int check_zone_write_pointer(struct f2fs_s=
b_info *sbi,
>         zone_block =3D fdev->start_blk + (zone->start >> log_sectors_per_=
block);
>         zone_segno =3D GET_SEGNO(sbi, zone_block);
>
> +       /*
> +        * Get # of valid block of the zone.
> +        */
> +       valid_block_cnt =3D get_valid_blocks(sbi, zone_segno, true);
> +
>         /*
>          * Skip check of zones cursegs point to, since
>          * fix_curseg_write_pointer() checks them.
>          */
>         if (zone_segno >=3D MAIN_SEGS(sbi) ||

How about this not to use a wrong segno value for get_valid_blocks()
and not to print a wrong segment info?

    if (zone_segno >=3D MAIN_SEGS(sbi))
        return 0;

    valid_block_cnt =3D get_valid_blocks(sbi, zone_segno, true);

> -           IS_CURSEC(sbi, GET_SEC_FROM_SEG(sbi, zone_segno)))
> +           IS_CURSEC(sbi, GET_SEC_FROM_SEG(sbi, zone_segno))) {
> +               f2fs_notice(sbi, "Open zones: valid block[0x%x,0x%x] cond=
[%s]",
> +                               zone_segno, valid_block_cnt,
> +                               f2fs_zone_status[zone->cond]);
>                 return 0;
> -
> -       /*
> -        * Get # of valid block of the zone.
> -        */
> -       valid_block_cnt =3D get_valid_blocks(sbi, zone_segno, true);
> +       }
>
>         if ((!valid_block_cnt && zone->cond =3D=3D BLK_ZONE_COND_EMPTY) |=
|
>             (valid_block_cnt && zone->cond =3D=3D BLK_ZONE_COND_FULL))
> @@ -4947,8 +4961,8 @@ static int check_zone_write_pointer(struct f2fs_sb_=
info *sbi,
>
>         if (!valid_block_cnt) {
>                 f2fs_notice(sbi, "Zone without valid block has non-zero w=
rite "
> -                           "pointer. Reset the write pointer: cond[0x%x]=
",
> -                           zone->cond);
> +                           "pointer. Reset the write pointer: cond[%s]",
> +                           f2fs_zone_status[zone->cond]);
>                 ret =3D __f2fs_issue_discard_zone(sbi, fdev->bdev, zone_b=
lock,
>                                         zone->len >> log_sectors_per_bloc=
k);
>                 if (ret)
> @@ -4965,8 +4979,8 @@ static int check_zone_write_pointer(struct f2fs_sb_=
info *sbi,
>          * selected for write operation until it get discarded.
>          */
>         f2fs_notice(sbi, "Valid blocks are not aligned with write "
> -                   "pointer: valid block[0x%x,0x%x] cond[0x%x]",
> -                   zone_segno, valid_block_cnt, zone->cond);
> +                   "pointer: valid block[0x%x,0x%x] cond[%s]",
> +                   zone_segno, valid_block_cnt, f2fs_zone_status[zone->c=
ond]);
>
>         ret =3D blkdev_zone_mgmt(fdev->bdev, REQ_OP_ZONE_FINISH,
>                                 zone->start, zone->len, GFP_NOFS);
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 4d03ce1109ad..fc7f1a9fbbda 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4674,6 +4674,7 @@ static int f2fs_fill_super(struct super_block *sb, =
void *data, int silent)
>          * check zoned block devices' write pointer consistency.
>          */
>         if (!f2fs_readonly(sb) && f2fs_sb_has_blkzoned(sbi)) {
> +               f2fs_notice(sbi, "Checking entire write pointers");
>                 err =3D f2fs_check_write_pointer(sbi);
>                 if (err)
>                         goto free_meta;
> --
> 2.44.0.rc0.258.g7320e95886-goog
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel