Received-SPF: pass (google.com: domain of linux-kernel+bounces-82137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 26 Feb 2024 19:25:58 +0100
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: Haitao Huang <haitao.huang@linux.intel.com>
Cc: jarkko@kernel.org, dave.hansen@linux.intel.com, tj@kernel.org, 
	linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, x86@kernel.org, 
	cgroups@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, 
	hpa@zytor.com, sohil.mehta@intel.com, tim.c.chen@linux.intel.com, 
	zhiquan1.li@intel.com, kristen@linux.intel.com, seanjc@google.com, zhanb@microsoft.com, 
	anakrish@microsoft.com, mikko.ylinen@linux.intel.com, yangjie@microsoft.com, 
	chrisyan@microsoft.com
Subject: Re: [PATCH v9 04/15] x86/sgx: Implement basic EPC misc cgroup
 functionality
Message-ID: <7u3intene6yvlkuks5bix3tx27wog3da6ki5w2l5flaod5mjrq@flgmfdd4fbei>
References: <20240205210638.157741-1-haitao.huang@linux.intel.com>
 <20240205210638.157741-5-haitao.huang@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mk6rhzbt6pcubuwj"
Content-Disposition: inline
In-Reply-To: <20240205210638.157741-5-haitao.huang@linux.intel.com>


--mk6rhzbt6pcubuwj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 05, 2024 at 01:06:27PM -0800, Haitao Huang <haitao.huang@linux.intel.com> wrote:
> +static int sgx_epc_cgroup_alloc(struct misc_cg *cg);
> +
> +const struct misc_res_ops sgx_epc_cgroup_ops = {
> +	.alloc = sgx_epc_cgroup_alloc,
> +	.free = sgx_epc_cgroup_free,
> +};
> +
> +static void sgx_epc_misc_init(struct misc_cg *cg, struct sgx_epc_cgroup *epc_cg)
> +{
> +	cg->res[MISC_CG_RES_SGX_EPC].priv = epc_cg;
> +	epc_cg->cg = cg;
> +}

This is a possibly a nit pick but I share it here for consideration.

Would it be more prudent to have the signature like
  alloc(struct misc_res *res, struct misc_cg *cg)
so that implementations are free of the assumption of how cg and res are
stored?


Thanks,
Michal

--mk6rhzbt6pcubuwj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZdzXtAAKCRAGvrMr/1gc
jpdtAP9DWI9U4DslLhCagwW21vXmXhw9bODS8LhGRCej42QUoQEApnC+8dZ4bSk3
Lmoa7gR+DzY5iQz88kGW8UD4FM1+6QI=
=yenn
-----END PGP SIGNATURE-----

--mk6rhzbt6pcubuwj--