Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1507297rbb; Mon, 26 Feb 2024 11:25:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXvvRn+6iCsguELHrCnesHkdznP9GHs+n0NCPjmIJFRlocwaS4a6+ZItry8zVT5MmoApnMOmdnACJdUfWon0Ykr+G/E8ANdcO2YYS6j0Q== X-Google-Smtp-Source: AGHT+IFClgg1cb/TMH2v8cpUaB/wr/y+MxLWCIb6ChmcSq6ahTrKwc+BJAPD/oUDk1lJDteWpPzp X-Received: by 2002:aa7:9a1d:0:b0:6e3:dd91:27f with SMTP id w29-20020aa79a1d000000b006e3dd91027fmr9012030pfj.14.1708975526143; Mon, 26 Feb 2024 11:25:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708975526; cv=pass; d=google.com; s=arc-20160816; b=vYOweXKJd81p3tb4BYWjKQERi79leGqVGAk8j68BBPnQZ8srvraPYm7HxdS4JUm8Ql ObnChbnx/EJ3v1/QKkeZfGfZbF8l2fAV6NMbi8C/2o2VRKc7N3LazxpgawohHeO5cy8Y Cz458Lo1cu0IHuLXjmd8KjYSwK/e61rdWgCcMeEPNi+ZjyhhlvSEyQg7X/hHnG8mLYn3 hb4hUmPHagZIpqNgHK01rnquKvr1UVbLceoWG7oGk6iEcJtKQbcocKd6pJoEb3mtJzq+ HJHG0us/Um8Q1ufu+tASLyUTn2iVu2zmEnmfWW0taiBlNlYeNYKOvTfXX53mB2qxqPyV KvwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=h8cVTp2nofCL/rF78jiA/kEn/KasJbL59buCZntAp68=; fh=WCLPHHe9biV/2Xz3UvWPS48CcQrIiFvdTYcyjizavVU=; b=d8/fvDF9PHLg7hs8r76PJ7yqOZWBf79ckb26pobWPKPgjl7H/JlZI+v3E5AKb46VbD 0SmIsL2w2BJt5OqKQlIsZnmMNIDukj+BCXKrags052Qp02uGSj5z+KmUlJqXE4r1ZpkG +fpI+sWIfsQPaaQpJ1S1flTUHVFMMY80Lku50pzTXMYvG1RmLwvoqMlW5JzatW7GmNjq skETf4YGDS8d028Rdb7TROVMW5ns3gM7I5baGsfwBKtym8VW5xnz1nf+BqkpYgniM3Ix zZQHPRfYf+GPtOY4806V9VCKAsZ58ObkyiNFcitl93IAFR+LNuVCRmbsf7C2ERN/qd41 DYSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VD+ZlOMi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82167-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q12-20020a056a00084c00b006e50d09f13fsi2687878pfk.322.2024.02.26.11.25.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:25:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82167-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VD+ZlOMi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82167-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82167-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BFF1BB27C2B for ; Mon, 26 Feb 2024 18:55:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AACEE12F398; Mon, 26 Feb 2024 18:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VD+ZlOMi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E5F12E1D5; Mon, 26 Feb 2024 18:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708973697; cv=none; b=mZTSW7+VEGjdZvLvXdBoMSJjyS9ZRofBIkc60ZDDfVFFoWRWi2H9C+Ul5mB9trcbfMHYulgPeYX3kLH8RuYB0rQDmR7A5nZwBYJ9zg/NsoGdYrIsvFPoH9wCLH9mo5M6HntAyVW4pDulXSAW8qvBCkfAmP12BuH12MxM5fDuVoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708973697; c=relaxed/simple; bh=5LGD1bbsX0ViNwsdm1xCwt95M1/zjN9a/re3ou5QDek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Do8tdMcIoO6ArH4kQR9dIMDUKNtCUcVAv/eJIuKSGuowC/cOQLy8eS9gc6qox070mdrs6XAVzNYOafoDySyw4zk/fdO5qk+UZ7YJ4aZa1IwLxDGwJmYzAZD0F2T1u8i8SsX2L/Y7tVST6UXAgoc96fme2bkbOOD87cR3BmPFUYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VD+ZlOMi; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4142BC433C7; Mon, 26 Feb 2024 18:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708973697; bh=5LGD1bbsX0ViNwsdm1xCwt95M1/zjN9a/re3ou5QDek=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=VD+ZlOMigOx0gFuFn0DyZNVhZgAbDnaBsEkjTBvsWHViraUaHzWuJoQFuZ5WtoS8O kTkNFq2NuqSd7fcBQy8GRIIwCUPKdmAiydzO3qaKcgd87Y+gpK6nZPsuLBu7g6C77p Ag6ay0Qkq+x6OfB4nosPVtBjcEirDcVsjMz5xVpvRVmfK42Xf1oMPktSgp/cGnVuOE Rf/NDjKqo9wOzgguPdibyhTLDlaAmDxhulXdRo5wCTdzAM9vZ1g5JvQtFaGOAl485L SwYV+sKnX1AJZvjGmgCzbwKXtLIA+mESPCdMJ2xYwFhWG8psUvItEH5q2lEQh019Rb 7i7Y0Vu9AjHrw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id D162CCE0E27; Mon, 26 Feb 2024 10:54:56 -0800 (PST) Date: Mon, 26 Feb 2024 10:54:56 -0800 From: "Paul E. McKenney" To: Zqiang Cc: frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu-tasks: Fix the comments for tasks_rcu_exit_srcu_stall_timer Message-ID: <4a8e281c-de4c-48e6-87dd-a26ec16b5f00@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20240226032439.26359-1-qiang.zhang1211@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226032439.26359-1-qiang.zhang1211@gmail.com> On Mon, Feb 26, 2024 at 11:24:39AM +0800, Zqiang wrote: > The synchronize_srcu() has been removed by commit("rcu-tasks: Eliminate > deadlocks involving do_exit() and RCU tasks") in rcu_tasks_postscan. > This commit therefore fix the comments of tasks_rcu_exit_srcu_stall_timer. > > Signed-off-by: Zqiang Queued, most likely for the v6.10 merge window, thank you! Thanx, Paul > --- > kernel/rcu/tasks.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 78d74c81cc24..d5319bbe8c98 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -150,7 +150,7 @@ static struct rcu_tasks rt_name = \ > > #ifdef CONFIG_TASKS_RCU > > -/* Report delay in synchronize_srcu() completion in rcu_tasks_postscan(). */ > +/* Report delay of scan exiting tasklist in rcu_tasks_postscan(). */ > static void tasks_rcu_exit_srcu_stall(struct timer_list *unused); > static DEFINE_TIMER(tasks_rcu_exit_srcu_stall_timer, tasks_rcu_exit_srcu_stall); > #endif > -- > 2.17.1 >