Received-SPF: pass (google.com: domain of linux-kernel+bounces-82315-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f0280912-6423-494f-8d61-28216551ebb9@datenfreihafen.org>
Date: Mon, 26 Feb 2024 22:00:07 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ieee802154: ca8210: Drop spurious WQ_UNBOUND from
 alloc_ordered_workqueue() call
Content-Language: en-US
To: Tejun Heo <tj@kernel.org>, Alexander Aring <alex.aring@gmail.com>,
 Miquel Raynal <miquel.raynal@bootlin.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <ZcF1El7fn5xkeoB1@slm.duckdns.org>
From: Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <ZcF1El7fn5xkeoB1@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

On 06.02.24 00:53, Tejun Heo wrote:
> Workqueue is in the process of cleaning up the distinction between unbound
> workqueues w/ @nr_active==1 and ordered workqueues. Explicit WQ_UNBOUND
> isn't needed for alloc_ordered_workqueue() and will trigger a warning in the
> future. Let's remove it. This doesn't cause any functional changes.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
>   drivers/net/ieee802154/ca8210.c |   10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2857,19 +2857,13 @@ static int ca8210_interrupt_init(struct
>    */
>   static int ca8210_dev_com_init(struct ca8210_priv *priv)
>   {
> -	priv->mlme_workqueue = alloc_ordered_workqueue(
> -		"MLME work queue",
> -		WQ_UNBOUND
> -	);
> +	priv->mlme_workqueue = alloc_ordered_workqueue("MLME work queue", 0);
>   	if (!priv->mlme_workqueue) {
>   		dev_crit(&priv->spi->dev, "alloc of mlme_workqueue failed!\n");
>   		return -ENOMEM;
>   	}
>   
> -	priv->irq_workqueue = alloc_ordered_workqueue(
> -		"ca8210 irq worker",
> -		WQ_UNBOUND
> -	);
> +	priv->irq_workqueue = alloc_ordered_workqueue("ca8210 irq worker", 0);
>   	if (!priv->irq_workqueue) {
>   		dev_crit(&priv->spi->dev, "alloc of irq_workqueue failed!\n");
>   		destroy_workqueue(priv->mlme_workqueue);

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt