Received-SPF: pass (google.com: domain of linux-kernel+bounces-82327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 21:17:06 +0000
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, haibo.chen@nxp.com,
	lars@metafoo.de, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
Message-ID: <20240226-rectangle-pacifist-633ae3b801c7@spud>
References: <20240226130826.3824251-1-peng.fan@oss.nxp.com>
 <20240226-germinate-anymore-fb85ca9bb226@spud>
 <20240226192055.54b4a6b1@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="tIzW5O2k7AACHYUt"
Content-Disposition: inline
In-Reply-To: <20240226192055.54b4a6b1@jic23-huawei>


--tIzW5O2k7AACHYUt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <conor@kernel.org> wrote:
>=20
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >=20
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 26=
8,
> > > so drop it. =20
> >=20
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
>=20
> I'm missing something. See below...
> >=20
> > Thanks,
> > Conor.
> >=20
> > >=20
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.=
yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > >        - description: normal conversion, include EOC (End of Conversi=
on),
> > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > >            JECH (End of injected Chain).
> > > -      - description: Self-testing Interrupts.
>=20
> Eyes skipped over this maybe?  The 4th interrupt is removed from binding =
here...

Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

--tIzW5O2k7AACHYUt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdz/0gAKCRB4tDGHoIJi
0lBjAP9JFqwqtIY93+4RkbvZhkGC9z9gyCJ3zcEeEwVkVbdwtQD/b5+mCGr5wIUP
J5Jf61KY+mwoafOL2mPfd4RwQNzsvAM=
=h2IV
-----END PGP SIGNATURE-----

--tIzW5O2k7AACHYUt--