Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1593221rbb; Mon, 26 Feb 2024 14:55:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVH9UWmOwDb33VQTr3i537EdCkLCLeapDoDuF4gKrKDc9DYHmUnkxCFeC49Ko1eRcCdkmFa23wf0ev9QTZwcNr1e2VM6ZEBe7iqvN3oVg== X-Google-Smtp-Source: AGHT+IHt7Liovye+MXPjZkOQVT7HfoKt4qiLTqWA15k/JdwCFp8C9+R21GD1xhfOruffAIwmy/nH X-Received: by 2002:a05:6214:1d2d:b0:68f:2a2b:c6e0 with SMTP id f13-20020a0562141d2d00b0068f2a2bc6e0mr567594qvd.64.1708988109011; Mon, 26 Feb 2024 14:55:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708988108; cv=pass; d=google.com; s=arc-20160816; b=iia7o6FjSU/xadbgoo6GKLrGTCnzsC6gz/IRWHF6QIzmXwPmxtQls0xIjUVgOv/LEA VwH6xr8+Fm1MIyuf3XBAgNw953m7uUAwt/VMugm8YDnF/p5ryJD0KGvVnCkWVpcbDbN4 Qz9p5tv+2AlrC740FTPAMOBnF/l7M3UZgFpWj2sET2kEoBj+osdPDDRwGg+4y//k4bBa 3gt+xsZPjfPPX/x9W2H1ZCUVU1CEv+jEvEG8Iwr/2GU5zSsJqMWj+04W7TJ9Glp1igzY WJgaAfVyfYzgD6+vLcIAq05hcjzQjvTYtJ1D0Dnb7wn4T+fa/9qTyJy4bQ45oGhx+7eq wgqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=FLSZZjbkGuZQBSsMMZaQvxQbUuaXEZrEG5l7P7dG3BI=; fh=e+COzAxVZ4jz1C6ETxgGPT4YkH2JLsKpF3/S5d7r5X8=; b=jgZ6yi5Oi+DfpzUg7+HOgOFE6FIP3pXtbkYpy86IsVhVu+/JB2KIJoc3r2+mvB7qGh 1QZaVAE5wuyDZL/Y8LAQ3VOo7ZF+dy7vWj7VrBF/nt/hTsBegvnOVSJOz2skLiGBNNN1 Nv59jxSo6k5gYEOkbICsU7xQryOV3eeXqjtHg/YEzZ4nbrpyOz47bfpbT1+TcTdj9/W1 QVwfjGoW2CBAVVlpnCzVoCSL3qj3TaLg8O0Icg4gtbjY3oEYBxlGA2tuqo4wP74S43fj dUE5rLmqukLLTcd9F7izxigHuMSHA0pZF7OXTHXri8xSWrOCp+CUr3+Vi4zFYYmErfty gNvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=rueVVVg6; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-82426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82426-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id kk6-20020a056214508600b0068f5577223esi6032282qvb.73.2024.02.26.14.55.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 14:55:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=rueVVVg6; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-82426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82426-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BFB5C1C247C4 for ; Mon, 26 Feb 2024 22:55:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93E2E135A49; Mon, 26 Feb 2024 22:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rueVVVg6" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 978C9135407 for ; Mon, 26 Feb 2024 22:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708988099; cv=none; b=cdl55sMUkpAF1oEONBUmBJZ5yA0/iPLWLcm4OkqUU9HGl515AGY9BdZS+MH11AmxG9TkR6ZLg10BLcNTbJZMzZqGFm4hsHMxeS54BXGBI7Qu0cemS65TWhGtZtX18HEdj9IrZNI3QY8j/h5xMQisqgAzcY2GDQZNT0MT25KpFhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708988099; c=relaxed/simple; bh=FLSZZjbkGuZQBSsMMZaQvxQbUuaXEZrEG5l7P7dG3BI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hRiVW21g7W0U2/zn3E6OfhRCeDXOzVlC0re+8Gk8LDVrM+5BOCe0CKmRe4bNrXe26ahFLa+EtzfAcUiHscF/4hqnIhcJHGfIpVqyRyk89FC0LVwlNMNar7HMrkEyfzYkMZhmY6WopVAXJC/mIHtPDqtBY6wkMC5rewqr7hh2pAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rueVVVg6; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-565223fd7d9so1330a12.1 for ; Mon, 26 Feb 2024 14:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708988096; x=1709592896; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FLSZZjbkGuZQBSsMMZaQvxQbUuaXEZrEG5l7P7dG3BI=; b=rueVVVg6lp1Yr4riIyoIksc7/MyUo5Udo1vq1RwuqgLBw+lIrldJUcXay8c57DgEYE 4QjIT4xkv7+xEXKr+Dik0VK9UaX+GY/YANT4nkDcSP+cKzsSEc1QaLrWjxv6UxKu4X78 ct5Zwaxa8sB6ig/GjKiERKfl5lfBwJgt7WO+Sn5rwnHMLZHLmqwZFEKmcgOPdmIVtD0s 261WkQ1ySp5QRxYflJDjrsYFxxhX+3fteMrLK+skhD+5FAuAqMFQLcT0YOl+UbGbk/8s 9FTQNTTZEQLK9J8oYetFoSLcNMGfXzrfRYtrh5KXbdGe0yjAiatUtRc7P/xZqcc/+XWh cTpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708988096; x=1709592896; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FLSZZjbkGuZQBSsMMZaQvxQbUuaXEZrEG5l7P7dG3BI=; b=nPQSV7c7vdRJLNI0/bYfohrhL9Q2ohV/pPJAIWWZfeVlZ/YKouGF7+Dr9yU4+KkpWI ohvDE4Cc5r0A42Vc0cFk9AoqcMfw+b57Y/14vUJ8mwA6qMs/ShKoS0VLYVO5VQ0v23xY 6WKP8ermEnm3x/BbDdwhrrBLpLelGyPFHMYl6bcvn3u2111iJrBdABmDDepQ189p+Pa3 Hj0Pcf2QaXR/Ei2pxxi+EgXUHc/1U9rYLyTVK6uD6wS9BY/lQhADuMOSmfbcwUttT6hP SWlKN2o0jXzgR7U5TNNJE0AcBuqkXxdIZhMeHNVzwubxFjzHABLAfieuR/4eid3YeQ5D 3H8A== X-Forwarded-Encrypted: i=1; AJvYcCXXx7RDi4YG16et59gNu0oClvUj7e4qbJqknVx0HIXuZIfUEmbJliIpApRH4xIvOvQCKLr7fYNMrqTPSzaFx38Z6CK935MGazsgJkYi X-Gm-Message-State: AOJu0Yz3D7oRWUPcF/Pc5xHsSPY71qm3peLS++y0fa5jNod7+9e/GT35 OCbHudDl8s0TqoeWDEgGFmvKng3zImDzJKaVKNn+wfBcyR3aamRn2dMyu9ZNpjj407H1iJfkd2f Drc6GXQ62nf5vx1/EFeZNyT9jA2jksMCKqgua X-Received: by 2002:a50:9e2a:0:b0:565:ad42:b97d with SMTP id z39-20020a509e2a000000b00565ad42b97dmr100252ede.0.1708988095639; Mon, 26 Feb 2024 14:54:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130192638.3557409-2-rdbabiera@google.com> <2024013021-fetal-nifty-38d4@gregkh> In-Reply-To: <2024013021-fetal-nifty-38d4@gregkh> From: RD Babiera Date: Mon, 26 Feb 2024 14:54:44 -0800 Message-ID: Subject: Re: [PATCH v1] usb: typec: altmodes/displayport: add null pointer check for sysfs nodes To: Greg KH Cc: heikki.krogerus@linux.intel.com, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry for the delay, On Tue, Jan 30, 2024 at 3:08=E2=80=AFPM Greg KH wrote: > Why not populate the sysfs nodes after the assigment happens? That's > the normal way to do this, otherwise your change looks odd because: That works a lot better. I must've psyched myself out of touching the current probe sequence and ended up overcomplicating it, sorry about that. Thanks for the guidance, RD