Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1603300rbb; Mon, 26 Feb 2024 15:18:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWQDQD8Fho+pef0UyDETrhkBx1BfxDdUpvpWm/6tNwyNw/sFPVqlcqGpZKmaU6CY38OW0OMwnXeE99NLtZd74M5dcy82mjw9KQ8TtsraQ== X-Google-Smtp-Source: AGHT+IHs0TQpobB9H23zoCYHtAnSPYsyeyxBf2yM/6gaQbcys6cWjCclA4ULWDtlXoM0MB0BATJ4 X-Received: by 2002:a17:903:24c:b0:1da:190c:3481 with SMTP id j12-20020a170903024c00b001da190c3481mr11233534plh.34.1708989538744; Mon, 26 Feb 2024 15:18:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708989538; cv=pass; d=google.com; s=arc-20160816; b=YY264+V7eyBztHqn/pRLVNYAPi7eLdja+oOhOiT534/wYc3CrePkgXrKJYIdd7wyI7 wbig4A8CWyLSbV0PU964LZ6k1QboCID0vLnVr0Hy88CEEikLbTS2wXsBFNYRsIMXd0u0 GxiQLfWXGpt/Rg4g+pER0XVuitQ2EVfd9dHP4Tx9fnjVNJkT0v+hqbGhoMul9863tECu 5ZKb19BM6frNyAzL/n7WfQI9SIN4hD9Xiyzu6a3859famNOYi5jVvg7XfVy6Mb5TJtPs kqBwG068Sne5AmzurXeY9F/TfNiY+eCacd8L+Q+DpGzcTYM4MeHBbhzoDEbb1xIffhkn GQAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g2q7Y6j0wCGTV4GevQ+ES5smo37GThY91C78pWGmQpw=; fh=oNe53FGKmuJik2c5fDuhYK2v0sOn9fVMlkvCz9W1/40=; b=fZoLoRTM13gq0SVAMUlgg1zh0ORGz5878t6eOmBVtBJccLRw8gr71jLfnxtOxf+RKp gTx4DGpSPs4qRQxrpTq4oW7pkqGSr3NxmH6kHm97NLYQdOR7aQyb/y99BSKUUfMD3+uA EUE4fSrZHFyNmPnYw6JKARXn6dn4WObtt2poU6uxdnHzTnP3dNrxMf1jM+MXMNtD+Gmz K9HcPte5/+uaFcmugrmJrU2y86HxcJs37kjxFhcKF5Mfb/7A0BXzcnIPjQ5Az6yAOP/4 GAkxkmRjhsQ1i82Jk63P17ETxYTEXDTSrQ53U6ogELCFFyo+ygGSy+vYMZJauX+g8eyf YOaA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=u2VJUnCp; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82438-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f17-20020a170902ce9100b001dba53ce5c0si319809plg.524.2024.02.26.15.18.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 15:18:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=u2VJUnCp; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82438-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 57EC4285B36 for ; Mon, 26 Feb 2024 23:18:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9838B135A6B; Mon, 26 Feb 2024 23:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="u2VJUnCp" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A488133285; Mon, 26 Feb 2024 23:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708989524; cv=none; b=Jr9xNlIJWrKU2UQ1ZDpKDACgVq2wrkzh9kV8HizRYa/PSLopwhfBve82DUkMXjTvm7XIgJ7gcpACCJx29HLpJLuWHzT2u9dGuKpqQ8qZtuJYlDnhY2xaIyUojb6J/BI6JTAEoC229DCVORA1NBRvMxXXUzRhm+X5jgNrVhrNUs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708989524; c=relaxed/simple; bh=RyR0GnuJRe7THA/MhNcC5QF7CUPey8a/ORFM9KGNV4A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IWdvJmgh+Q5HX7afBn+hpPPZ3KD7C/fWRVSwoxRz4ugZK3OUx31kmwzF6gniS4bZ8g+aOUxjnm6HUSicf7Z1n1PX82c72sbzR10JbvyJwpTeuV0xbheNhGCmRIDvmQ/9t9KDqMwpQRacjTMfkFmpDYyJZKoxoBNXL5p1pSS4Ouw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=u2VJUnCp; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=g2q7Y6j0wCGTV4GevQ+ES5smo37GThY91C78pWGmQpw=; b=u2VJUnCpWA24Cmf1fN0w3E962R QE/KINpYUHDTH1tnNo5Sb7+K7nSN43PB3mvL29YKQNOqOgSOVN0Vik49pUcyV0oGOPMDDPT8uYNJd eznc6DyK3pVvqndBP+0ptOD+lr/RzNqIHuy+azL7oUNwuRCT9svn11R4h8ZrYKdS9c4Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rekFA-008lsR-HI; Tue, 27 Feb 2024 00:18:44 +0100 Date: Tue, 27 Feb 2024 00:18:44 +0100 From: Andrew Lunn To: Julien Panis Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: Add minimal XDP support Message-ID: References: <20240223-am65-cpsw-xdp-basic-v1-1-9f0b6cbda310@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223-am65-cpsw-xdp-basic-v1-1-9f0b6cbda310@baylibre.com> > +static struct sk_buff *am65_cpsw_alloc_skb(struct net_device *ndev, unsigned int len) > +{ > + struct page *page; > + struct sk_buff *skb; > + > + page = dev_alloc_pages(0); You are likely to get better performance if you use the page_pool. When FEC added XDP support, the first set of changes was to make use of page_pool. That improved the drivers performance. Then XDP was added on top. Maybe you can follow that pattern. Andrew