Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1610230rbb; Mon, 26 Feb 2024 15:39:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU3WEHb8uKyhBI+bFqwEQF0knHCKYBASaYF7MYwMNgyiRXp8DG2jUHQhFmXZLiXgJrQ93+7uAAQT90k9KCn+jgoWTUkcZbvgoY9E4URXw== X-Google-Smtp-Source: AGHT+IEGTobevXEex0J0R873o3D6YFD2Eq7zARQIqNeJHvTPMqd3S1leAwiPwZJvQxYF5Sce/4KL X-Received: by 2002:a05:690c:9d:b0:607:9dda:676c with SMTP id be29-20020a05690c009d00b006079dda676cmr719774ywb.18.1708990766668; Mon, 26 Feb 2024 15:39:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708990766; cv=pass; d=google.com; s=arc-20160816; b=mmh87MjLiz+mPMKfwxZMJzjBrFYcPMd4sw0hPVZ6lKfM/ZVHPZu/0Hmhb2OcYYgw0t Nkz+kQe0waK/OBuGp4TTobuHhFH+lOyeprqFHucEwTBC1AEx/8acmdU2SOHlgMw0H8Pg NgQdbydF5QJIoo62K98vPGH3uBUhLob0CPwbpMg1Ij4nOD2g7SA/1KFEEUpDg5TgF+s1 YrqwrqXZP4nz/jROA4PuGM89k83MUjFmIxNC9ofXOqykdU/bYr7aSiNYkfLfidSKEkui xK3HScuGf6pFWweV7FDm5kAmzVtkMDWAHsgcu2N0S+/Oe1CLHRIccEO7T44Qn/VrYTiL 2zoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7Otld8V/bzkJaFDg5xKk0LY1UIWmUWFwWmtXGjOC6yU=; fh=wRoE0omMZs14q0nqz8ODrccinHa92g9OFDeqyVlBmAA=; b=qQfnx0c215nUPjCUcvy0+XFd8ZRyZ1amJb8Yj1SSY8KwIBfc9lCFIfjWhSbA20vK/8 gLl3OwHu72M+GPbNAA5Rmq8dCooOl9+RbB1dP6qRoM0aAd6akk04KWTmSRDcyZS8y68s vqguawfX6Ru3RYU5w3Im1oMn6PjK0oH3I2rr6XTH5T8cYwd9Eq58UnTF02RSNIszG0g4 n8P5lf9KxAhzkx2Kwq7alPp8XnmRQydrBmIq1ou4QBk0baImT4VG1pX3+71DIQkgAhjF e0uvfot4sttqxXNh9RC3pX33LRvBPTadXnDpxNdY+hN4Vu9C5Si6l9dP1UWzQZVLHfbv O1jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=iJfF8cvJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o4-20020ac872c4000000b0042e7e6d5b68si4097124qtp.32.2024.02.26.15.39.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 15:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=iJfF8cvJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-82443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 450831C21D97 for ; Mon, 26 Feb 2024 23:39:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52750135A6B; Mon, 26 Feb 2024 23:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="iJfF8cvJ" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AEC260864; Mon, 26 Feb 2024 23:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708990754; cv=none; b=UstDb94ctG2rEKBmuirEzQCiPUSZ3c33dNxLRYnbQxzP1ny0RYqa7gKZik50D3dv5tnkf9EjqO4I4u86oEWnNeR2kMniWPH2FM2togJTI4PbkbsmGUKsd1ZEytv5L6yF8i0pCHJyuLLAOzwkHL+/kxQtzznvnPrMLTLW72EUuvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708990754; c=relaxed/simple; bh=DC4XPRGfDGkd+lTP0RPnZft98OYBjzRmA203J/eHadU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M8ZqRbk2FejGtmzCPXisOn7D5VRpecw8cpBmNGpaQunJdl7m8brHnBH6F91REsSIm2jNDu2DMAfTLj0ebZ1pt0HnGxizhiSRszutay4x+U1F/yfCMIZV65kBvotmrBL7UlrgvErKSx63VfFMLWURppggcLyMaLKvj1Ca1Ulad8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=iJfF8cvJ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=7Otld8V/bzkJaFDg5xKk0LY1UIWmUWFwWmtXGjOC6yU=; b=iJfF8cvJ/VlmCEUV3k+y55j5+A jkGnLmwMn+4b2kyVoBJ/ZtWI/CW5V/ZkvTFCytF3AwIpxEmkYl+bihY0OvF0ggYrnagtM1bKTjEz+ QwFY7UAe0ZIPxTtz8KS7RSTlC22W6N8L/gj80aLXSljhSBIHboaYRtnTi7ChWqLlFQ9E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rekZ5-008lx7-6g; Tue, 27 Feb 2024 00:39:19 +0100 Date: Tue, 27 Feb 2024 00:39:19 +0100 From: Andrew Lunn To: Sarosh Hasan Cc: Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Prasad Sodagudi , Andrew Halaney , Rob Herring , kernel@quicinc.com, Sneh Shah , Suraj Jaiswal Subject: Re: [PATCH net-next v2] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII Message-ID: References: <20240226094226.14276-1-quic_sarohasa@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094226.14276-1-quic_sarohasa@quicinc.com> On Mon, Feb 26, 2024 at 03:12:26PM +0530, Sarosh Hasan wrote: > Updating link clock rate for different speeds is only needed when > using RGMII, as that mode requires changing clock speed when the link > speed changes. Let's restrict updating the link clock speed in > ethqos_update_link_clk() to just RGMII. Other modes such as SGMII > only need to enable the link clock (which is already done in probe). > > Signed-off-by: Sarosh Hasan Reviewed-by: Andrew Lunn Andrew