Received-SPF: pass (google.com: domain of linux-kernel+bounces-82483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <eaf4ff10-6bf3-4181-8ed0-895fccd2bad4@intel.com>
Date: Mon, 26 Feb 2024 16:49:05 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 0/3] selftests/resctrl: Simplify test cleanup functions
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1708949785.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cover.1708949785.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nzl0K0RJbEV5MGdwU0ZOWnFoNGZKS0xQZnRFRVE4dWhSZEJZSkEyNE5MTHB3?=
 =?utf-8?B?VW4zK29pbHltY3RKM2ZyNDJySDdQVG52U0JCRnhYbEhUcWhXZ1VzOUVkNEZD?=
 =?utf-8?B?Nks3aHU1ZmFMTWtNUFdvU2FZSE1QOERaUmFuaHl2MzRCamxxNFlUakFsQlM1?=
 =?utf-8?B?ZE95ZGNTc2E3V1JLMTFjdVEyd0xYWkZRdzRoUjVERk1NU055MWRGLzQ1cHRt?=
 =?utf-8?B?TFRtR2RSb0hSbjc3eWErbWt6a1lON3N6REIzaCtiT0NFVElFZk9tMDhObjZD?=
 =?utf-8?B?eFUyYU05Q0ZoaVVoa3J2b3J5TC9EZCtlc0J1Vi9uTGg4M2I4REl5Q1lOTGU5?=
 =?utf-8?B?MDFTVXdIK2FwRFNSY0FpbVI4OThrRjdTUWdZRWdTR2ZDVlBJRmxhb0x2SGF4?=
 =?utf-8?B?UmlsakNhTVBRRjhRK0ZwZ3UyblBmb2wrYVh2UWhiU0xEanFzQWRhL3EzUUE4?=
 =?utf-8?B?bGMvb09NRTloL05LQlZJcXQxelhMN2R1WFAyTnFVWU10RC92Q3JZbEhkTVZI?=
 =?utf-8?B?QU50bElrMjJwOVp5dHV2TTJIWlNPSEVRWFl4Z2lWZ0R6Q2JCUjkwckNodTFp?=
 =?utf-8?B?MjZIRXgwa3V4TXhoWm1Da25EZWtwTmZ6ektEa0ppeUxraHAzM2MreXZpWnd0?=
 =?utf-8?B?RG9sZGNBbjhOcFFucFJxeHgzVWVGUy9zYVAyQ3J5RXloMUlKMmlDWDQwTW9B?=
 =?utf-8?B?UEE1c2N1dWRNa2x0SWFjdDhaeERSTHdmSDkrbTJ4Y2ZhUDY1Ny9zSGprVmNO?=
 =?utf-8?B?aC9ncmpNRjE4K0c4SGVMeERqVVY1RE5FWUU2MERJT2trNGJCRmVaM0p4TERn?=
 =?utf-8?B?UzZRbVBhUGxWNkVKTTBMMjFMbWJNYzg1MUI2cytScjJaVi9BWU5VZC9KMzl4?=
 =?utf-8?B?UCtMek5CNHhlaGtEL1Y2d3BvNkxyQnNQcWJDUTJxWHNzV2ZNZWYreDRWNFZh?=
 =?utf-8?B?TmdGNTNSN1ZmL2JjemUwem1vUFBNTFFVSE1SazY2U0FhdUVyNi8rQ2tLbkZx?=
 =?utf-8?B?dGltUEY0ZTBtb1lXWE1Yd2w4SWNMQW5nSldaQkxtc1hvTm52YzRsZEI2RTZT?=
 =?utf-8?B?dGF6K2xoajFuMnBuV1E3a1pnZVVScGhFdmJuTzU1bTYrRjd3OVE0bVRCaDhh?=
 =?utf-8?B?K2l1d0srWjdveVVPVDRPT0dHcnRtelhRa1NqNXlGNC91TWRrS3RRd2RKQTBD?=
 =?utf-8?B?Q1BKMDJSNWVvNUtFT3JLcXFJRHo3WGtaMGR1c0Mrem10Um4xeGxrYjNuTW1t?=
 =?utf-8?B?WlhEdzZjSEZrNk16RW1DcU8vT0Y3dEpMaGRPWEMxSTFzeGhEdDVFOVl6TWY5?=
 =?utf-8?B?RkFSRHIrQ3FuYjZsakdyU1h1Q0NtMU1OQ1RUT2J3STRqcVhUME1BcmRRK1J3?=
 =?utf-8?B?S3JjNWlGYWJiU2RQSU1zRnFjRUtTTlRQekVDNnJzbjgrQU8wT3FKNFcvVjc2?=
 =?utf-8?B?Vk1YS2FPRnZQUjRQNWU3ZSs5U1JGRUZLL1p0YXNJTXpvbEFKdUZLd3lwcXo4?=
 =?utf-8?B?anNGY2FUdk9ORjF2SGZXM3E5WVY5MTNNeXI1dHFsb2dOVnQ4TUdYNnc0cGR1?=
 =?utf-8?B?QXgvUHNyTXBtMTgya3RjbUNkN2NYUXNMMTJjNTlXZU9nOEpiOWJrUFJRSWZj?=
 =?utf-8?B?cnR1M2NaRnJKbkVicDFIQUNJY1lpMjFtQzhiOUV0eitodnFTOWJFTmJCdjdM?=
 =?utf-8?B?bk9OWXI0a1dxc2RieC9Kc21vTFkyQk9KTGE5VUVxVUR6WXYwWnJocGxPM0pX?=
 =?utf-8?B?dit3dk1KamNhNTk1VVJEZjJJb1hpLytYblFDc0pYRGVtWjNrdWJ3L29pRFpV?=
 =?utf-8?B?eTVmRUFxbHBIcUFUNldKUEl5ZXJsWllnSXNORnJTWVFLdFd3V1hwVjJlRkto?=
 =?utf-8?B?dzJuWjhZWUtvVkRxL0EwSHVRTDNHVndPTkR2WStsbnpHQzZHUmxITWY4ZFp6?=
 =?utf-8?B?VHFsdmpieEZuMUJ0cnFPY2h1c29XeUV1QUJBaTk1ZlVSc0RZTXdGbEFpWkJH?=
 =?utf-8?B?SHMrOUtYNnk5NDZTLzdWN1JsSkFFM0xnRE41dnNwVjZ1MG96Q0JjdmdHQmFS?=
 =?utf-8?B?R0pZam9jWTFpYmdQNVZnaWZLSXhIWHJIR2NQQVdyTitZamRlK1RMc1ZQMU40?=
 =?utf-8?B?anZnSUNEWlp0eVROTHJzLzdEdmhvKzhoVUVoTVlXYlBGWlRtcTBGOXpTOExQ?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dcef9397-33f0-40d0-feb8-08dc372de7b3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 00:49:08.1453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0N7nhAMJRdboVdv3QpZVsVC9gISeF/hwWsdIGCUQyaQRG7R5NP7Ccr1HMk9fFgl9HV6CM218w+6CZ4w6BpAUVwEcRvGa5iI6Gv44Nbeyr9Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5182
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/26/2024 5:05 AM, Maciej Wieczor-Retman wrote:
> Cleaning up after tests is implemented separately for individual tests
> and called at the end of each test execution. Since these functions are
> very similar and a more generalized test framework was introduced a
> function pointer in the resctrl_test struct can be used to reduce the
> amount of function calls.
> 
> These functions are also all called in the ctrl-c handler because the
> handler isn't aware which test is currently running. Since the handler
> is implemented with a sigaction no function parameters can be passed
> there but information about what test is currently running can be passed
> with a global variable.
> 
> Series applies cleanly on top of kselftests/next.

Could you please rebase again? This series does not apply cleanly when
I tested with latest kselftest/next at
ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")

With this addressed, for the whole series:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you very much.

Reinette