Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1639211rbb; Mon, 26 Feb 2024 17:00:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWtnDTxCgVptKIc6smR0ePkjKha0KoXLcaR5rS6ZDWZTgu7So05DmWhEY1sjighEFcw0GR7uy3Y0TFzpJHNep1n+a6zGcn24nsrTFJWQw== X-Google-Smtp-Source: AGHT+IGmo0OWPAsdMYYGs4x3WqjXM1NtUWI7JqxZzJ3NDypStABat0Lgga8dE62pbCKFNQVhw7Fx X-Received: by 2002:a05:6402:124b:b0:565:7733:3c58 with SMTP id l11-20020a056402124b00b0056577333c58mr5209594edw.4.1708995639316; Mon, 26 Feb 2024 17:00:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708995639; cv=pass; d=google.com; s=arc-20160816; b=dmIFaVtxZhJCtnHb81iYq1zBsUyu4nIv780mZAriAwSJ3sj9BItffofQ1YnnUjiVnR xdAsYinx8E0P3IrZ4ayO+rt/eHtlwBhtP+TgI0z92ErZZ2mf78Ggc3FSldZL4R5R6S+F myKusvU5VGu42yCGlCj+vgnmypvHXx07JrBRG8c0WEpd2juQtSCuaB1XiX8XtjirtCCO tEYi4PnvkbguQJructTK4y7o4VunmJYv8aBhOCMtXfsvQBligLP1jhbFKO8J9tUFWy8n V5SBGbANZJFMDHmVicSWVTQZGdZ35p3IREq7V5YOlXogrn+jk/ZeSPJrKn5u+C3U+Mpy KQqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=h2maoKK3D5h7KwvJ4omcLtuCA4hceEnE3qUFZIi96vk=; fh=yMf0Kbv45yps+lHOzJSUXPt0yADuv5GnyabFQ/gxS3Y=; b=ItykxoaQ1253DaMpTI8fILEU4iZHh4nEc2yet1F7sn8CKIp1vRBmEjbl6kijXX4LGF E+Qe0AX4gUWX0tLSs3lxYWPxJ9aPULLDZQDZFx/lyXjsUvhxiEffPoqNYUT188popjj5 acZdBzyHjSO6dS9MoGR1zsNSiDfra4rETdXnhpeU+TsemTiMCDS6/5sE08TwI9O+RDrc 7WmSzEb+fkD2s0a5m1bLqJUL0m6bL27JH4XHem8zIX850D6dSfeGU6f/hIUyjygUN2zr nMWzg+oMZuMvNEbSJzAYg/hL228SFHbmU/guGLvF0IEPm30B0/09yMaCEGP1Xu2KRzfc 2vxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ABy4x6rB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id v28-20020a056402175c00b005661825a194si234849edx.160.2024.02.26.17.00.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 17:00:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ABy4x6rB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-82498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CBAB61F22D09 for ; Tue, 27 Feb 2024 01:00:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70E7C4A31; Tue, 27 Feb 2024 01:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ABy4x6rB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906FF1FBB; Tue, 27 Feb 2024 01:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708995628; cv=none; b=YQSLEjSzH1Tr8pTRB1Jgq0jri6R0mec21lTm3+nqIlyikoi5K2INNCzpqbQnrXGTyFj1bFYuVujZ9/WqyK85naFKJIYXcDfC5tVWom+YLcxawTYBUfy2K32dWIUi7zeWiplD8iBb6s2hFy3LBe+DoqtT8FT4cI0opMjsbketJkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708995628; c=relaxed/simple; bh=WUHMokbLfgIQlKeQ/UYNE/AJllDQMsUUuSpCB2Q9IUs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=igUA7Bll+vJVyybPQwmQWwgjFyM2VOOZkwEDOd7P2qFDRteo/CItFSByDx6YGJi3SMZ802k+5ab2CJcuCnZyidV1XCKv4qwFAn2kW+Y1lQS1NjaOZc9XqGDZkAy19BvSzlQrRSu5ZQDiBQNdjbn6oTMMzsX/f8w1JlhTvsNxtgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ABy4x6rB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F74C433C7; Tue, 27 Feb 2024 01:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708995628; bh=WUHMokbLfgIQlKeQ/UYNE/AJllDQMsUUuSpCB2Q9IUs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ABy4x6rBL7/NK/oOYPprxXAegn58ROo7DErl6FKueMFUsbONkuaAlACsY+Wq0aZr4 fDh3f9hdpTOPo6yCXzEBoNeJQcch3qPRhohv1Su5fuWD81xQVKzxA03wg+imlao6hW CBRvjLnD5darj9sXA76ChbBBqFojPMESVZ74Oj01aDNI/THE9StvjvMuEeehQMKMpE UXWi4tki0cLFnfR5ZTkN4IY37gFR6KhoF7B+20ADvk9j2Y9naxJ5/LpzqxiaNjZZHt Oq2QSZmh8gcVISnq1JGnbUE8eWymzB/8jM27cZfdyBr9QDdGwRue/iu8N8iO8hz7ic NJZ9HcxXgmFYA== Date: Mon, 26 Feb 2024 17:00:27 -0800 From: Jakub Kicinski To: Hariprasad Kelam Cc: , , , , , , , Subject: Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom information Message-ID: <20240226170027.6a43f196@kernel.org> In-Reply-To: <20240222171542.12995-1-hkelam@marvell.com> References: <20240222171542.12995-1-hkelam@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 22 Feb 2024 22:45:42 +0530 Hariprasad Kelam wrote: > + if (!ee->len || ((ee->len + ee->offset) > SFP_EEPROM_SIZE)) > + return -EINVAL; Are you sure there's a path thru the core to the driver which would allow len == 0 or the size being larger than when info put in eeprom_len? -- pw-bot: cr