Received-SPF: pass (google.com: domain of linux-kernel+bounces-82540-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 17:36:07 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, <x86@kernel.org>
CC: Dave Hansen <dave.hansen@linux.intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Xiaoyao Li <xiaoyao.li@intel.com>,
	<linux-kernel@vger.kernel.org>, <linux-coco@lists.linux.dev>
Subject: RE: [PATCH v3] virt: tdx-guest: Handle GetQuote request error code
Message-ID: <65dd3c87680e7_1138c729433@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240225224244.2072245-1-sathyanarayanan.kuppuswamy@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240225224244.2072245-1-sathyanarayanan.kuppuswamy@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UltDEvAza9Na9ZvXq9mGKkXO+uIXFL9oovNdmTQq41XS72trhC/vrK1r37+h?=
 =?us-ascii?Q?2H6cqYpbKE/uehQU27jRwl+6Gr6Zvqt97GvEnwCbAANq7s4zW1Yw/EDaLoa1?=
 =?us-ascii?Q?1GD31D9Ka/6vwSQipp97A0zijQw79yLB472Ho5aF4pJOs3orEpYfF0QT9kbr?=
 =?us-ascii?Q?2mUTy/OwncldqR8BFAAndrVAngMftwD2e6dZ+Y0JU+btpsqk39BFtwtkSb8f?=
 =?us-ascii?Q?UlRUyd21erUj6gQ/e7oDJSCCK/Ju+3Eug8fxKmomHlEK6kBQXDellNlIlSwM?=
 =?us-ascii?Q?h/u6QlFfqMOX+j80104RrcKjhWrDJVFMCPQDkIWiEWTivhryPVsVG2WBWDK2?=
 =?us-ascii?Q?lLm8GtHTxE6svZP7NX6IsSCQI4f3U3sxIsv2zm1PiJLQnx2TjebJgMGmgfrE?=
 =?us-ascii?Q?EGCOeyw3TRzod33AMoLK75Wp68ZddOE7mjO1HUg7iCz6krr/dd56CXMlZVDo?=
 =?us-ascii?Q?+AGG7L6oEHjIziV6NtcHkQe+6JsZMT+x6UZ3fVwo7D2T2iAWBwCav/Kzio3F?=
 =?us-ascii?Q?Zchz7e2MHEDZ5bFS6m9pHBB7YzXWhgWPQ67aKPSvgDHZgvomiCPizyaXtsnw?=
 =?us-ascii?Q?9fASO7NZVhBKW6NL9Ne+2rXr5ogKA2N7fmt0mRBXEHchCU/VeWk6tyLYtD5H?=
 =?us-ascii?Q?xa+XVTBuZX7k8XSQp9YDYMKit/9sWEfESTnawmlMpsO9+ybtcU+cs4Oguf8S?=
 =?us-ascii?Q?Zak2KghF0UqFS2EHQbwMygvN/Oq67jthRKSOYQDNR469TAdbI4lYMs2kTHpv?=
 =?us-ascii?Q?ndWIjR/7vZjMWhogXjgiLkQ9gE4OcdKIGL5PUoLwTKGihJkKPyf/NYaRP2R3?=
 =?us-ascii?Q?GMdkl3Dn5U60D2JDmWAQtplPX1SR9vfGOA5dSLV7ujjxbC6W7Egaz28yeVFr?=
 =?us-ascii?Q?3t/hcL24SAwoes2QsP+9yZZ5KCOtaUR/a9j8FyxIYAj/RYssAL4oVx0q/R9U?=
 =?us-ascii?Q?v569M3Cp2NX0MJNUBYSs8Ddx22Dw+nuxf42Ctn9pX/yj5DoxqLvuLQOMDbRg?=
 =?us-ascii?Q?HJr3f/62C3g8QzhYbCj55A1l8Fj4GBAnRHpS3zs14mS9r1kEt2Yt6fMUX8gH?=
 =?us-ascii?Q?Da1GLl0WdPUk1zF398V42DUuOz56WyPl+42LaNKJxCLLBRFFOqduqmdFsG+H?=
 =?us-ascii?Q?V5sEf2s7mO1TkVEky3n1sTymm0zv/vhW7DedKUAvWt9E7EgHrWMNfkTQl5z4?=
 =?us-ascii?Q?6L2UeRPeB/a7oqzPXQgvXKPJZiclO/TXaJ7JMD/CgXfX3mXEnhn1Oh7rXEzg?=
 =?us-ascii?Q?z9CsrfICKI1SowWO6Nd/2BWigxlIz5ice9WLRPlCp2L+E0lolgyaeoHaslPx?=
 =?us-ascii?Q?dXaOr+5ANFMHpbq6GZA6Hr/5p3soUhNqw1teA5ZrZLEIlaR0Ni9CCcSiZyn+?=
 =?us-ascii?Q?y/RcZ9xRMoLkNL5l587tWQhZafQm+8gCHxTqujoqNTdeY1Qo8uChIHFjmd0l?=
 =?us-ascii?Q?ofiQjsTyOtnrDEHgL8Gd69aziRmOBMsDduvR2qcjoSgA/01hVJU1p/bdY3Jx?=
 =?us-ascii?Q?ppdzyNLAvPtuQfkc/0Yphn6wQtNRPLUgHWmDHaXvrkBYKnCG7acH5mcCnPXe?=
 =?us-ascii?Q?NxMWoE2vtrfJdDckoJD6a7Ck7I5JUXXX0b+UlawnJGSMzmGwDndIfv3a7s3V?=
 =?us-ascii?Q?Jw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11ba5a1c-12e3-48ae-bd59-08dc3734797a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 01:36:09.7391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: seJuGJgh/XA8UzABpwucd+MP/3ujD+TgwpvM6jzM4Djghy1JYBvIEmUXnEDDQsyOP2mR8Z5IoDP+6avFh8Y43m6Zq/5AuJvmjrFbO5uf9Ms=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8482
X-OriginatorOrg: intel.com

Kuppuswamy Sathyanarayanan wrote:
> The tdx-guest driver marshals quote requests via hypercall to have a
> quoting enclave sign attestation evidence about the current state of
> the TD. There are 2 possible failures, a transport failure (failure
> to communicate with the quoting agent) and payload failure (a failed
> quote). The driver only checks the former, update it to consider the
> latter payload errors as well.
> 
> Fixes: f4738f56d1dc ("virt: tdx-guest: Add Quote generation support using TSM_REPORTS")
> Reported-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Closes: https://lore.kernel.org/linux-coco/6bdf569c-684a-4459-af7c-4430691804eb@linux.intel.com/T/#u
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Acked-by: Kai Huang <kai.huang@intel.com>

Looks good to me:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

..if you decide you need a debug print here, or to differentiate the
error codes based on transport vs payload error that can be a follow-on
change.