Received-SPF: pass (google.com: domain of linux-kernel+bounces-82547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID:
 <SEZPR06MB695901BB60F786D7E209EAAC96592@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Tue, 27 Feb 2024 09:43:34 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v4 3/6] dt-bindings: net: remove outdated
 hisilicon-femac
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta
 <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240222-net-v4-0-eea68f93f090@outlook.com>
 <20240222-net-v4-3-eea68f93f090@outlook.com>
 <c3f3d276-46a5-4cc7-ab79-e1ca3262abdf@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <c3f3d276-46a5-4cc7-ab79-e1ca3262abdf@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|TYZPR06MB7073:EE_
X-MS-Office365-Filtering-Correlation-Id: 6f542af6-b5fa-4397-40f1-08dc37358703
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9Azh9Ls4VyZk607KbdiOUrRNKNyEx3Iyc79kq5gyvhF6L8sQ4bUWY4M6rTReXrvBoagzJE01lTpSljRP7KH1n8sVcZpiITdVjTrW7iXVwzULiP+2IN6YuyztYBFGQYGJtDAcfHjaznSLwGd6frPW6SPknZTkwufPe/JdwiADA+1AL2ajKEz2ou5LLkWJsnWldDXqD29C68z4qZ9xvKI8TB6x9RwsRkMw9mz+r9m4eRHAd37bB5eBJCA2dflfMiThyIodeYILqkwzdfRH3sjqk4Nrl5rJnCu6CG9tsiuPOG7OpkR7UGPUi1MfMnOTlqCvJ2TnzD3gahx4RldvuEJTjONUJP7k5uYlAw+qJoy+MB11iuYuk98p7f3np4tjeNzmJn2DXnmgPGEDIY7Co7RKHSp3N5rduDtZNly4O9KZyIdIDmpG3KKdY0PCvzrY3FmSWHkzH0wJZkkMNs1fXlhGxxud7cpDB5QAVPHcFZaKIzfxdpk8JfXefO7BycN4GjNCE7/hJgvWpjnA4IzG+1kTXGCgpWOxHRYWSdcH7RvhpY6o5NffKdxNqDQv+HtYH4aN
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajZIY090MTd3OUpPNDBNK2NEbW5wNGM0UmpmcE9ROHp4aHFBTUlWUzdMUWly?=
 =?utf-8?B?RCs5N2FTU1hwTzhaY2NsdmVYZXZCQzUvL2FFWFgwd3lBTkpLeDBjWnBDSk1W?=
 =?utf-8?B?YnVCYWJMWURqcTlQdGoxRDZjaGtXYWxDWk43a0V3M0dFMndPYWY4VmlWc0Fy?=
 =?utf-8?B?bHBTYzhvM0NENFdMT2RMV1lWT0tpWWdwMWJsWHpMbENRUjFSUTlka0JwWjky?=
 =?utf-8?B?dTg2c3lpcnZqMFJJR1liNXMwWVRieEUzVi83OTNHYXQyYjY5cDM2ak51eUJp?=
 =?utf-8?B?a3BVbkZXaTRZU3Z4VDlsTUtob0FjbVMyemVWY1Vkek9zYXRzejlCank4N0tn?=
 =?utf-8?B?aFFlZzc3a3hKU3d2SnlNS2VoYkVZbHhwc0dRUUMzVGoyYVBIS3FnU1M1UzVV?=
 =?utf-8?B?WGlKU01WeVZlRUprN2JKVmQ0Q29zRHFtSU00eG1EYm0zYjZQWCtKYkJZZmli?=
 =?utf-8?B?RnJJVkZhYm1OSkFRN1hDb2dmK1NUQWxJWi9UWm1BdnRQb3NiT2tQbWE4NTFG?=
 =?utf-8?B?bEN3THArcGd5UzlJd05Lam56cWVMcE4xK1hnNFBBbWo1ZGkxcVlyT0d1UDda?=
 =?utf-8?B?bDFPUmNSTzVNY3hod0xBdExDQTkzMThRbTQ1T1lEczI0MkwvVDFpYTlwL2Vp?=
 =?utf-8?B?NjRzczVsdUhLemlqYy91UEN5WDZucHI1RTErUGQ0dExvNEQwbGV4cnB4Zm5j?=
 =?utf-8?B?NEs1R2RDbTFYMGFndlhlYnFHZ1pCaWtzTGtRcUh3eDFwMzdHcWZvQUxCRkd3?=
 =?utf-8?B?Kzd4UUtvaTNvMGpiaUNHbWNIS2wxVHJPL1EyUnJlZU01S3BCYmpWSDMrTjhF?=
 =?utf-8?B?dEo0TWkxMU1xeVFqa3MwUDk1TVJPOWhObEVLaGJEcnlBS2tkN2FxdHNsVzR5?=
 =?utf-8?B?aVR1MlIvNkhSYVprc1ltK0VvVXorZlFLYjdHOS9xeTRkYVE4Kzh4dWU2cmpE?=
 =?utf-8?B?cURiMk5JNGo1UnRUb05vMnJjMEZ5MGJjcUxIaU9TNHN0M1RnN1RCenZVMU1I?=
 =?utf-8?B?NDFEWDlicXh4aGZTNzN1d2NJWjZVa1FCQ3ZUeGZwSUhBYmVUSy8zK0VGdG5t?=
 =?utf-8?B?bGsxQnNOTkZSL0J0N0pUZjZpT3BRU3JJbUdOaEtCZ3F3Q1JGTW1VcFJ4bEx3?=
 =?utf-8?B?dHM0ZEthV1pEbWk2UlB0NmdtTE9GOHJPWHRSK1M2OXR6N2M4Q0xGQStnb3E2?=
 =?utf-8?B?TmRtYlhPNk01NjFoZzVxdWJLUGxPZEFKT3Q0ejUyUEtHS1I1NnVFelJjOER3?=
 =?utf-8?B?bDZpNUVHaDEveU1OY0RDMDRTWG54SmJoeTk0ZWEzK1VoZks0czlwZzV2SkVW?=
 =?utf-8?B?UlJQU2JOTlpYODFxd3ZGdkhZVDRWZS92cjM5eXpzYUNxeFkrbXBHQTJ1V1BI?=
 =?utf-8?B?QWp2aEl3QkVNOHR3MHdvenNkdTRRdEsrbUVEZXkveThrZTFzVUVMQm5aRUZQ?=
 =?utf-8?B?OVUvVnkydmd4Zy9MTGxHMzFLN090NWVVcjZnWkl6cGZFMVpzUk4rMU5yWFpO?=
 =?utf-8?B?YlI3TGY5eGh4N04xOXBQSGlTdVpwSkxQVjVEWVRGK1ZPS0hXeUI2OTRMTGFa?=
 =?utf-8?B?QjlzMndhbDFCWGl2SzMvRloxTDYyM3prbWg3MHVQbm9RSzRDSEt6b2cwVkMv?=
 =?utf-8?B?WVl4ZVBEeFNPVlFSUlAwRHF4SlN4QVNmV0RHZkgxRGZMT25vdUV0bGIzZTE5?=
 =?utf-8?B?elJHUllEbmFSWGtHQ1k3V01yKytVMWh1cGw1U2lkN081TFJHL1oxTXBVZGhk?=
 =?utf-8?Q?AZTh1FxnX0oTBd9KDIfh7wNLJLhJGxpgdbIGi/p?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f542af6-b5fa-4397-40f1-08dc37358703
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 01:43:41.9599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB7073

On 2/26/2024 3:50 PM, Krzysztof Kozlowski wrote:
> On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> The user documented(Hi3516) is not found in current kernel anymore. And
>> it seems this SoC has been EOL for a long time. While at it, Remove this
>> binding entirely due to recent driver changes.
> 
> This removes documented compatibles, which:
> 1. should cause checkpatch issues,
> 2. is not what we want.
> 
> Driver is still there, so first the driver would have to be removed...
> but then why do you add it immediately back? No, it does not work like that.

I has downloaded TRM for this old Hi3519 SoC. So i think with the new
driver, it still works for Hi3519 FEMAC controller. So i'll rewrite
these 3 patches and describe the whole thing in commit logs. i.e. the
old binding is wrong, inconsistent with real hardware, etc..

So you mean conversion to YAML first, in a separate commit. And then do
necessary edition to match the real hardware? I believe Hi3519 FEMAC and
Hi3798MV200 FEMAC are compatible in hardware. So the old binding is
wrong, missing critical hardware resources.

> 
> Best regards,
> Krzysztof
> 

-- 
Best regards,
Yang Xiwen