Received-SPF: pass (google.com: domain of linux-kernel+bounces-82573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ae4c477e-b61f-4816-972a-7e94c9625905@intel.com>
Date: Tue, 27 Feb 2024 10:02:51 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or
 TME
Content-Language: en-US
To: Dave Hansen <dave.hansen@intel.com>, Paolo Bonzini <pbonzini@redhat.com>
CC: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>, Zixi Chen
	<zixchen@redhat.com>, Adam Dunlap <acdunlap@google.com>, "Kirill A .
 Shutemov" <kirill.shutemov@linux.intel.com>, Xiaoyao Li
	<xiaoyao.li@intel.com>, Kai Huang <kai.huang@intel.com>, Dave Hansen
	<dave.hansen@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, "Ingo
 Molnar" <mingo@kernel.org>, <x86@kernel.org>, <stable@vger.kernel.org>
References: <20240131230902.1867092-1-pbonzini@redhat.com>
 <2b5e6d68-007e-48bd-be61-9a354be2ccbf@intel.com>
 <CABgObfa_7ZAq1Kb9G=ehkzHfc5if3wnFi-kj3MZLE3oYLrArdQ@mail.gmail.com>
 <CABgObfbetwO=4whrCE+cFfCPJa0nsK=h6sQAaoamJH=UqaJqTg@mail.gmail.com>
 <CABgObfbUcG5NyKhLOnihWKNVM0OZ7zb9R=ADzq7mjbyOCg3tUw@mail.gmail.com>
 <eefbce80-18c5-42e7-8cde-3a352d5811de@intel.com>
 <CABgObfY=3msvJ2M-gHMqawcoaW5CDVDVxCO0jWi+6wrcrsEtAw@mail.gmail.com>
 <9c4ee2ca-007d-42f3-b23d-c8e67a103ad8@intel.com>
 <CABgObfYttER8yZBTReO+Cd5VqQCpEY9UdHH5E8BKuA1+2CsimA@mail.gmail.com>
 <7e118d89-3b7a-4e13-b3de-2acfbf712ad5@intel.com>
 <3807c397-2eef-4f1d-ae85-4259f061f08e@intel.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <3807c397-2eef-4f1d-ae85-4259f061f08e@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkFKRk83UjRDVll4ZnFWSHU0VVdEczhRZXJGRWltVzUwZkEzdlg0M0x5QVFt?=
 =?utf-8?B?R3R3eklRTGRJRTMrQmhvc2dtNzN4ZjB5ZHpBTFg5TitJVGp4WWNUektsRFFj?=
 =?utf-8?B?VVZUQkdkbTc5UjBhOXV4bFcrelVudDBpOTE0S1F6b2VoblNpbVVSU0I5Tis4?=
 =?utf-8?B?VmhWOWtBbm9WQ0gvR1ZhMDdmMEk4MkNFU1FCZXMyQmdiQlJKbEhLb0ZFNlhP?=
 =?utf-8?B?UjJuaEtKSUtwV1FjZjI0YzM4cHpaWWU1SHl6ZkxsS1E3RUtYNFNRMEh0QVNU?=
 =?utf-8?B?QTA5eXV3TVNKcDdDNy9zbzU0emVRcTErd0dHZlhKV203MGV0VHhtN2FWTVRV?=
 =?utf-8?B?YldSSjV3Q3ArQlRzRFVBZUZ3TnBEcmk4YWwzYnh1NnpLZW5sdURRSkRYOGNJ?=
 =?utf-8?B?QjBNOUlwTmgzMGVGVks0VnJ6RHRKb3JvZGZ5bjNqRVJJdENZckhmeDl4a2Rh?=
 =?utf-8?B?d2NuaFQyRDhNUGo5TlRXUmpHZFppR01tZHNNWDJPNFR5VTNHV25LYTNpaFJC?=
 =?utf-8?B?cGgrNGdldExKTkRxeWt4bFo2TnhCVE1lSGFrUjBJL3BxR0wrQmh5cGx3R1BR?=
 =?utf-8?B?YURtdWtmME1sbDlUbS9DbEg2V3BteVphQmtvY1R4MDdzWDJPSnhjSE01SFZ0?=
 =?utf-8?B?VG5ONzdCUStkTkpTSjhNM2xIZ1RLS0Jhd3g3aDVGLzN4TzFPUnZLekxxMEg3?=
 =?utf-8?B?N1Q1WEkrSS91SDJkS0RBMHhFMnlObWhLY0dYV2VjYTE5S3pSc01tTlZSQVoy?=
 =?utf-8?B?ZDF5MXhSbE0vT1cyeHN4RXNaQmlNWXlyeVg1N3BZZzVjVFQ5b2wvSG9TVFFi?=
 =?utf-8?B?aitDYitHOWUxL3F3SmFlcFVybnl6NEhxZmpUUGUyOUZkUjB5Tkx0U05UVWtv?=
 =?utf-8?B?NjJ4T0tkQVBwL1ozWmJLWVQ3bm5JSkJBb3Y5RVhZVzA0YXQ3RHR6b0FHR3VB?=
 =?utf-8?B?TkthczV6b1RKTWhVU0s4Y3gyT3lkbHRqd0hGaUFZUjJaUHplanFISU5BUnpS?=
 =?utf-8?B?aDhqVTI2SUFyeHI1TXVrNSt5OGhHdmt6V1VVY0xEamdUMW1MNUpVVFU1TU5L?=
 =?utf-8?B?MVdyTWZGa1YzNmxvMnk2YmdvR1owZWc5RjFNZU9ZTEFxL3dlT2xpWUVnVkxW?=
 =?utf-8?B?ZjNON3Axa2xpUTdvODNWSDdCeU5BeEIzM05hWDJUbGVZTS85K2ZaK0N6Z3RP?=
 =?utf-8?B?dUd5RmxSRW9NZC8xK0ZNOWo0VXVoUzFSNnhyY3d5eEN2cVk1dklCOHNLVmdn?=
 =?utf-8?B?dWw2MEVMSmwrNFkwTldHV0p3MStIenlCZHBQdGV6ZERrMS9tNTNoTU42VHQy?=
 =?utf-8?B?NFFXTVJ6UE9Ud2VraDdQT1dWT2R2UXcyNk5WN1F3NmpxM0hiOEFsKy92OWhL?=
 =?utf-8?B?c2hWOFZPTlpaTk9vZ0dpTnFxUFFjd25ESCtpQWhzWGNMWGdoZ1hTUEVXVGtl?=
 =?utf-8?B?L21yUjF4NVMwQ0VrWXlvRUVLN2c2STFzdnFpWnZvQkNQOUQ4RHc2NVA2THlC?=
 =?utf-8?B?c3l6UjJ0UGtTMHVTNTM0cW8rdzZ2K3BhNENHOTRiWG1mRytIL3Y0cDFFY2pv?=
 =?utf-8?B?ZmxaUEx1V2V2UkZudHBjOUN0S0I4L2pwcVlNK0dMbjhVdzlQK0JqUEpRV0ha?=
 =?utf-8?B?Q1JTQ2JicVI4N2hJcUk1U3YxWnpPaTI3ZXdaK2ZWNHpEc0pjVXh3WHd3dGll?=
 =?utf-8?B?UllVdDVVbjFLazFaamQxMWdoVUhZb2NyNGh6RDl0ZDkxTGFzYmsxK1Y2Wkl0?=
 =?utf-8?B?azhzWXhTTmozbGpGY1Vpc0dJVStDSHNBVWNtNHRJY2FRcVBTYUtSZEFMdDB3?=
 =?utf-8?B?ZFFLWDZCQ2lHazRjcDhEanNEZVpPMG10S2U0NzNIZEo0Sm5XR0RIcDJRUCtV?=
 =?utf-8?B?YVdXQWp1NWxIMmlkQnhSUjl0MkRuSnljekpsdGMvcGpDWnIvZ05qR0dyOWNB?=
 =?utf-8?B?MDVyMlNoOHlJaytUdFNNTmtpSkorbWVSbVl3NjlFbWxGcEswL0k4c2RVam1E?=
 =?utf-8?B?S1dxb3Q0YXh2MDdHQjMyQTh2U3M1OFBTcTJNUGsrOXJjR3pzVHk2c3BDaDNI?=
 =?utf-8?B?WXQybmh6c0hnK0V6bU9RUGZVQzNrRjZyZXJPaHFnZTBBRW04MFpvMUlabm1H?=
 =?utf-8?B?M2lJYVJHcUhIZkgrYWcwYUExWU5NV05oVzltQmpOdDhmVHRhRENXK1QvbWVQ?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f57e31e-f6d9-4c38-df5d-08dc37383883
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 02:02:58.6769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QjmL7PID5KXweS7yE1ZodZCgmVNhoy2igkPgS1h1+jfqX9q0hL81OBsINePe3vnfTE6X2rJzpEv44a/LvY8pSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8696
X-OriginatorOrg: intel.com


On 2/27/24 00:21, Dave Hansen wrote:
> On 2/25/24 17:57, Yin Fengwei wrote:
>> On 2/23/24 02:08, Paolo Bonzini wrote:
>>> On Thu, Feb 22, 2024 at 7:07 PM Dave Hansen <dave.hansen@intel.com> wrote:
>>>>> Ping, in the end are we applying these patches for either 6.8 or 6.9?
>>>> Let me poke at them and see if we can stick them in x86/urgent early
>>>> next week.  They do fix an actual bug that's biting people, right?
>>> Yes, I have gotten reports of {Sapphire,Emerald} Rapids machines that
>>> don't boot at all without either these patches or
>>> "disable_mtrr_cleanup".
>> We tried platform other than Sapphire and Emerald. This patchset can fix
>> boot issues on that platform also.
> 
> Fengwei, could you also test this series on the troublesome hardware,
> please?
Sure. I will try it on my env. I just didn't connected your patchset to this
boot issue. :(.


Regards
Yin, Fengwei

> 
>> https://lore.kernel.org/all/20240222183926.517AFCD2@davehans-spike.ostc.intel.com/
> 
> If it _also_ fixes the problem, it'll be a strong indication that it's
> the right long-term approach.
>