Received-SPF: pass (google.com: domain of linux-kernel+bounces-82623-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oneukum@suse.com>,
        syzbot
 <syzbot+28748250ab47a8f04100@syzkaller.appspotmail.com>,
        bvanassche@acm.org, emilne@redhat.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        martin.petersen@oracle.com, syzkaller-bugs@googlegroups.com,
        tasos@tasossah.com, usb-storage@lists.one-eyed-alien.net
Subject: Re: [syzbot] [usb-storage?] divide error in isd200_ata_command
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1cysi4obq.fsf@ca-mkp.ca.oracle.com>
References: <0000000000003eb868061245ba7f@google.com>
	<99b0fb1b-37b3-4da4-8129-e502ed8e479a@suse.com>
	<9bbc5b63-33e3-44de-8bce-4c59dcce5e92@rowland.harvard.edu>
Date: Mon, 26 Feb 2024 21:46:39 -0500
In-Reply-To: <9bbc5b63-33e3-44de-8bce-4c59dcce5e92@rowland.harvard.edu> (Alan
	Stern's message of "Mon, 26 Feb 2024 13:13:01 -0500")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?KUv442u0SwS8bwgJAEQBdnLhUrX2wi58gpvCTrAO4N1QJnizUSSwejt/llIh?=
 =?us-ascii?Q?QOkeuQNf6r4tGq01m8U+Qiq/p9W2Qk0jMScJ5Z6VU3dQczaUbYmQV5TFsmpN?=
 =?us-ascii?Q?qgwoNSN7zlJUWVGJ3BN4JVFB6eUjORvzp6YCZhgkKPTIviJuqKeLa4cUICtm?=
 =?us-ascii?Q?Du1+7NRJ26EAU6EYYH9AxmLlKczm8v3FOq2k4+DTb9xf+AQVc4e9HuY7J80p?=
 =?us-ascii?Q?j0UVLYchuMWiUg+gPZ+a7fHpxzba3otIErUQUT5fnXxnASvN3JS8hWLPIdgj?=
 =?us-ascii?Q?mMiw4MwYXlZYZGsY/YPAC0rd3jBZtwrjWVDWowIfxpx6h9qCOrGlgRsdYATR?=
 =?us-ascii?Q?lTmXiKCl4GKlfMnJfcIgCREHSGEVM2fWApGokpXjqs14Li4LtADKP9pudc2g?=
 =?us-ascii?Q?aEZE+jgCnbv8K8Q+kqqrOrAH2fKE3AXC6y17bOOny9vZI2Q56sAKQn3MqCbr?=
 =?us-ascii?Q?ilfInU6Oxb63SyX09YZB7olrxKhwu8nfwbWfFRBToN+yYsmub8X0/VWW2Jqm?=
 =?us-ascii?Q?xTOktm9+F9qn+XKaQjcFc1Ar/jkit7YIVNDfhbTjZDNzbwWRoKCeOBYZm53a?=
 =?us-ascii?Q?gjcQc2HfIES4Zbg7+9T5tr1Q03WytTCBQKVqjVDMFsGVyDRDbtMwuF2B8CtF?=
 =?us-ascii?Q?8GOmoC28CvV1vXGS4YZHiKvCbFrv3w2p4BTXTrVsK6t2nKEzcxcVFeKTVcyg?=
 =?us-ascii?Q?kK5By75azgw+Ux7ylCoh202p5FSujmt4WPXpC4Czd/RvhTgBHnEoCkPoWgU6?=
 =?us-ascii?Q?wHDUgoJP5lTCjrzmJIKLVZvj7gjZXKNou9uzV+M+to+2P+xfp2kh5QmPTsNj?=
 =?us-ascii?Q?FK3Pt9trMeYGltq4KOOykHz1LayqEQnVDp7QSZBfD40sVRDkKsljeFrDYZ+K?=
 =?us-ascii?Q?l3mgqyW7mahqGztvMb9GWwQDx6L/e7l3wY9MwInPPqGcL/Q31PluXCpcwj27?=
 =?us-ascii?Q?mOBp8jEAfOB95UIsOyeQpdQIDE4AGj1pO+bJROKRDHtbtGEgraGfhjiu3K40?=
 =?us-ascii?Q?fH7mVzUSNv8xy/RqKt8aeUdB8F33qk2JEtiOchfZqbDOeclmHg1dLN/U25RV?=
 =?us-ascii?Q?wpVUhc+cvSdky5mPm8k8dDpwtj+8p++V3J3OKvK5DphpmyL1OEBLqJuiqtIT?=
 =?us-ascii?Q?DTUPc1VNRD7tolBfLr7/SDSryYHfLNC7ySTg5U7I2YYa+LH9rY9wsuAmR75r?=
 =?us-ascii?Q?DB30ZR0c8HBkdEEAkhfQx/SH0rUpXDg1gCcJ71X+kiUbiW9IbOnCsjtk6cS0?=
 =?us-ascii?Q?IqVWmAUQIl6/ZB+4Bt0lBHoQbed59Xd+rQY/JWJFq6dMSj4FSdvm/+R8fzfl?=
 =?us-ascii?Q?8Fd4QPZG9utPAaT+noDLQO76X/8tO0m96oieH8T5CjMSbbZcMAnJCJKUKGdh?=
 =?us-ascii?Q?pwr6dhTmhNwpp8QJDz4YvQmmDfrCWD2jn3m5romvgECjFDz/xSWmn6GBptDd?=
 =?us-ascii?Q?XZDtN+TMiHWtO3Xd/vbGKUZPInFzGUYHCIM82ilQCBvKC+EEZ3CLL+0Xrb21?=
 =?us-ascii?Q?9iZLd/rtAMqzKwzuvqiWULuC9ey8eFL9+KhlNmAg08vEcyy5DfsY9nn55wBH?=
 =?us-ascii?Q?LOfXDt1uWhjssnntAHJU7halkgDQ8Knt6w1MS8zKkDQ/nVapCWZg/bZUClFM?=
 =?us-ascii?Q?Zg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	7pr7VBkzfxokkDibF68/hSpFUv+GQRuZXHrLHK0SOYgWtsIkJBgcS6kPaAMfP+N/WgjbxnXoxRtxh4XD5OLBYWdUzqhIlTtebp4pn9FrTW0kcELErdeRHuOq0UREMMP6Ht5pjF3Bdw0HusBXPKsBOHraoVh3YRZiaApTUCgFdzy0+5uq6dgGkzotnEvPZ7U60uJGv+tWB8udPGh4eXff/vjmxqo0yosKhINAjWqQFKbGx4qNxptngM92e6xQqVfDMjkog3fgVa74q3vt/tU02NLQjHielEjRlQM9BxhVFVABshklcLjf2YKNGeGJVuo9Bj3bn75Qo180wmo0kc5leLYxGgpmpfecF3tduV+kWdX0eJYx41LrSqlmOjYfD5GL4ORKk3zrEH9dtBzwXhEkSHaVDFX8f4q952zfEstu7JsUnLK6BKn7T7l/Zsdx46RSIKHVQ/PP3RyRpOuGuxJIG3kpMdTYgU+gwiIiCgQXq9gyHrk/bGimCQ+EY/bwch6DYO6MD6TJdXseUjg6LOjlVxRNdWoJSFuaZi7SZCsmI/CkDt1ScE0kebF49kxbbY1yeBp4EOd4GWAn/m3R8QqFQtXff3m5BnfQx13eAx0+iBA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 156bc20f-f3d1-4954-f304-08dc373e5551
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 02:46:43.9405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nWv6nKrB4MyHY0fiQXCCcwm6GzovmErls6UpEkCWSWD3+om4spAwZ/6Z9rRY7AQTaDmJLKe4pMaOcgaA8vHed2gCZYNVqp81p3+TzKjuM7g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7314
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0
 mlxlogscore=968 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402270021
X-Proofpoint-ORIG-GUID: 5gPl9eym5V9bJ0vOIvIfF2NUj3pGRlno
X-Proofpoint-GUID: 5gPl9eym5V9bJ0vOIvIfF2NUj3pGRlno


Alan,

>> in isd200_scsi_to_ata() because it must not be called before
>> isd200_get_inquiry_data() has completed.
>
> It can't be; isd200_get_inquiry_data is called by
> isd200_Initialization during probe before any SCSI commands are
> transmitted.

How do we end up with bad inquiry data (or rather bad ATA ID data)?

-- 
Martin K. Petersen	Oracle Linux Engineering