Received-SPF: pass (google.com: domain of linux-kernel+bounces-82629-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Ding, Shenghao" <shenghao-ding@ti.com>
To: Mark Brown <broonie@kernel.org>
CC: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "perex@perex.cz"
	<perex@perex.cz>,
        "13916275206@139.com" <13916275206@139.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
        "bard.liao@intel.com" <bard.liao@intel.com>,
        "mengdong.lin@intel.com"
	<mengdong.lin@intel.com>,
        "yung-chuan.liao@linux.intel.com"
	<yung-chuan.liao@linux.intel.com>,
        "Xu, Baojun" <baojun.xu@ti.com>, "Lu,
 Kevin" <kevin-lu@ti.com>,
        "tiwai@suse.de" <tiwai@suse.de>, "soyer@irl.hu"
	<soyer@irl.hu>,
        "Navada Kanyana, Mukund" <navada@ti.com>
Subject: RE: [EXTERNAL] Re: [PATCH v9] ASoc: tas2783: Add tas2783 codec driver
Thread-Topic: [EXTERNAL] Re: [PATCH v9] ASoc: tas2783: Add tas2783 codec
 driver
Thread-Index: AQHaZWJdzl/3F/uZLk2mYU9psTSIi7EXdCuAgABAqsCAAN4VgIAE745Q
Date: Tue, 27 Feb 2024 02:52:00 +0000
Message-ID: <748cc67e04204e3d95de7891cc13ff4d@ti.com>
References: <20240222074000.659-1-shenghao-ding@ti.com>
 <10f53a13-a0ff-40f9-b089-f5baacdb76b6@linux.intel.com>
 <5c7127256bf54fcd921fc1ec83f3e527@ti.com>
 <ZdjTyccCDoD9QYpi@finisterre.sirena.org.uk>
In-Reply-To: <ZdjTyccCDoD9QYpi@finisterre.sirena.org.uk>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Saturday, February 24, 2024 1:20 AM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>;
> andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com; perex@perex.cz;
> 13916275206@139.com; alsa-devel@alsa-project.org; linux-
> kernel@vger.kernel.org; liam.r.girdwood@intel.com; bard.liao@intel.com;
> mengdong.lin@intel.com; yung-chuan.liao@linux.intel.com; Xu, Baojun
> <baojun.xu@ti.com>; Lu, Kevin <kevin-lu@ti.com>; tiwai@suse.de;
> soyer@irl.hu
> Subject: Re: [EXTERNAL] Re: [PATCH v9] ASoc: tas2783: Add tas2783 codec
> driver
>=20
> On Fri, Feb 23, 2024 at 10:12:49AM +0000, Ding, Shenghao wrote:
> > Hi Pierre-Louis
> >
> > > In the SoundWire spec, the unique_id is *LINK SPECIFIC*, and only
> > > used at the bus level within the context of a link to help avoid
> > > enumeration conflicts
>=20
> > > If you are using the unique_id as a SYSTEM-UNIQUE value to lookup
> > > EFI data, this is a TI-specific requirement that needs to be document=
ed.
> > > That also means you need to double-check for errors so make sure
> > > there are no board configurations where the same unique_id is used
> > > in multiple links, or by devices other than tas2783.
>=20
> > This code only covers the tas2783s sitting in the same bus link. As to
> > cases of the different SWD links, customer will be required to have
> > the secondary development on current code. I'm sure my customers have
> much knowledge to handle this.
>=20
> As Pierre says I think we really should have some sort of defensive
> programming here, even if you're going to leave multi-link systems to fut=
ure
> work people will still have older versions in distributions or whtaever. =
 While
> I'm not sure the consequences of getting things wrong are likely to be th=
at
> bad (I'm expecting bad quality audio) it's also going to be kind of hard =
to
> figure out if we just silently pick the wrong calibration, especially if =
it's
> actually a valid calibration for another device in the system.  Other ven=
dors
> (eg, Cirrus) seem to have figured out a scheme here?
Thanks for your comments, Mark & Pierre. I will discuss with my customers o=
n=20
how to find a compromise between new solution and current solution already=
=20
released to market.