Received-SPF: pass (google.com: domain of linux-kernel+bounces-82712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9a314461-3097-41a6-a264-1b109f30d3ec@amd.com>
Date: Tue, 27 Feb 2024 10:34:28 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 3/4] net: macb: Enable queue disable and WOL
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
 netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240222153848.2374782-1-vineeth.karumanchi@amd.com>
 <20240222153848.2374782-4-vineeth.karumanchi@amd.com>
 <024fd8e1-8d1c-4073-99ff-ae8c5d123baa@lunn.ch>
 <78730bb7-4588-4038-9336-eec6e2635a75@amd.com>
 <8c0efb9a-d92c-4b9b-be75-498d460f67bd@lunn.ch>
From: "Karumanchi, Vineeth" <vineeth.karumanchi@amd.com>
In-Reply-To: <8c0efb9a-d92c-4b9b-be75-498d460f67bd@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OW1oRTF1bVhLQnN4UUYveStuMkgyMlg3MCt6OHdBY1Rua1V5ekFBSmVNby9j?=
 =?utf-8?B?RVNqbFlGaExlL3I1ZEZGbkVMeVB4OFhvRVduWWs3ZFlSTGRSNW8wNnhhMHpE?=
 =?utf-8?B?c0FkOFdwVG1Tb0xkaFNjMlRFNmVOblNrakRQeGpDa085YWM4UXZwdng1Tm1W?=
 =?utf-8?B?MnpubHBBMkV2a25vN252OGY0S05lK2JneGVmNGZLNGhrNStJd1RsRzdRZmVi?=
 =?utf-8?B?eTBKanB1ZUJCTEcyampJZElWa2tRYjRETC84NmxOZnVqNDUrTE5LZkkxYmVN?=
 =?utf-8?B?WWNVSFdneHVuQStucHhqd3Jsc3RWalpyaVppWE9LUmJUd202cmU2VW5YNUpt?=
 =?utf-8?B?aDhCeW9uMS9NTU9WYVl0MUsyeTNIM3FQa3g1L3RpeWNvZk1NaDNQd29ELzc2?=
 =?utf-8?B?ZnZPQ0NDb3BPTVZuU2o3bk5nRk11azMxWnYvNXhzWDYwVjRjY2xzL0tjd2dt?=
 =?utf-8?B?bEhjOVNmZXRONE01SzdVRkJOQk5KZC8rZEVSRDlhdi95VnBkU3hlUC9JemZt?=
 =?utf-8?B?SDh4V0hXOGJtbHVXUWdlZENRa2gvMHk1Tmd0SzZUWS9rUU9pZE94MmtXWGto?=
 =?utf-8?B?TU9mWjZyWU4zYUxJMXJ5cFViTzBnb01SVitXTUw4WHJjdmNxc2YyNWpRd1NJ?=
 =?utf-8?B?SDcrOG1hTWlCY0hyOWJyTU5qNmNaeXdTT0VqOWdiQk9pN3U4STR3ZXY1Z0Js?=
 =?utf-8?B?N0RRclhJZStBU2VUaGMrd21zSEhFekFUemlxSUp1WU11TE10SS9CaVpycHdo?=
 =?utf-8?B?NWJ5TG82M3NURWUxYWlXVSt2T0Q1M04yN3g3ZjkyQmg0WWk4Z3puWFFxQ25a?=
 =?utf-8?B?UFF0TW5Lb09YQmRHVW9oNGRPT2RBeWgwVlcvYnZSNlA4UkRUSnNjcE5ETnFT?=
 =?utf-8?B?Q0k0b3JkT2hXamU1OGRDYmQxbEJtaGRUTzVaUGt3WFBjY0RNTU9FT0lYS0Jx?=
 =?utf-8?B?RVB5WS9xT3BEQjBQbEpjeWRBRjdrczlDYWRNeVhZRkVHeXlNWEN0dDdGbGxq?=
 =?utf-8?B?dmdTb0p5Rzg0aWEwWmdEbUNtM2JtQnlPWmtIWmlTbTd6cDRaY0o3T0xwQkJH?=
 =?utf-8?B?VHAyQ01KYlpQaDJUUUpBUmVkWlF2QzhTS3RGSjhrM01xQytFTHc3OHN2elZh?=
 =?utf-8?B?aXd2YklwdFQ4NUVaTFhLRm5MakxOMXk5ZTFQNSt1cWpVRXNoVnEwUmxGamlV?=
 =?utf-8?B?ZlJGcHM2WWxCbGx3REpTUVRiNklaU0t0bFdTMWpNenVvbWMvZkU4Z3N6R0ZC?=
 =?utf-8?B?cmkyeDF4VjBkUFpVcU5WK0toSVB5UDdRUDA4dll6WG5GeFJwOWQ4WXAzbUhZ?=
 =?utf-8?B?bmdXR3crZ1ovakN0N0hGcHZjb1NoZGxTVWZvUnhocHgxMmR6UWJ0TWdZemFW?=
 =?utf-8?B?MzVaK1R6bUplOVgyWDR6dnQyV0Vyd0Y4cDJPTUVHeFBlYXZXUFBJOUVQVVFk?=
 =?utf-8?B?dzQ5NXB1TmxuZ01jZ29mWmVqSUYyNnQyRExIZ0RudlhCQ2hQeTU3MExWRlFY?=
 =?utf-8?B?Sm9jREY2bmtZMGE2TGZIOXROZWRqckNLSEhOZ09oNURLNGlJRjhITDIyQXpG?=
 =?utf-8?B?MytOTTA2R1RWVWNtdTBsZTJLWE81NkRENUpld1lYK0Ztc0hmbkllUFpRWFdv?=
 =?utf-8?B?UE5tRUxsVG9YWU9DdDYyQmhSMHl2QnQyRUdVd3hNNG4yM0JoQnhQVWw4ZG1t?=
 =?utf-8?B?STdaSXVDbXRsbzEvektQWDNYRkpNeXFRWDNOSkJBVldrTFlOR29veW56MTl3?=
 =?utf-8?B?M1RXU3BjVmJtYm1NY3hxNmZDa3hoM3BmNDVybzU4RTNrSjRJS1l2VDZEOTkr?=
 =?utf-8?B?WmNNbm9VWnVhVVBmYUR3NWZiM1lrMlJlWVBGeU1SR2NGeGp0NkpoQXRoM0pu?=
 =?utf-8?B?enZGdzQwU2tOY253ZDN6U0lVUjFpbk9tWGVrTW1hZ2hYQjI4cmtyRlJGNnhG?=
 =?utf-8?B?S3Njd1R6cG0ydWFjL0YvUzg0TEJTOC9iRkNrRGo2V0hWb0Q0Um16eENJNXk0?=
 =?utf-8?B?K0FrSnk4Z1FkVHVodHZNUnR2Z0NxdEE2cUFQTlJMMis5VEhyalNUa20wZHgw?=
 =?utf-8?B?QUthNHpUTVpiRlhvYzVjV0tBZHZ5OFZMVkM4N1ordnlwRkVJb1VJVlJsbzdX?=
 =?utf-8?Q?IWJZ0VvblF90n9AtNjOL6npG7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ff61490-057e-4597-998e-08dc37519a98
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 05:04:40.8646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6WIlAhSmOehbrZ33f1bIPgXPk3+z9Z5csNHDSoKLwm2yjgtrkDmLe1sGNQuNUTie
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7837

Hi Andrew,

On 2/23/2024 6:56 PM, Andrew Lunn wrote:
>> It is not specific to AMD versions. All Cadence GEM IP versions have the
>> capability, but specific vendors might enable or disable it as per their
>> requirements.
> 
> Do you mean it is an option to synthesizer it or not? So although the
> basic IP licensed from Cadence has it, a silicon vendor could remove
> it?
> 

Regarding that, we are unsure. However, based on observation from all 
previous cadence IP's in AMD Soc's, this feature was available.

>> WOL was previously enabled via the device-tree attribute. Some users might
>> not leverage it.
> 
> This is not typical. If the hardware supports it, we let the end user
> decided if they want to use it or not.
> 
> So if all silicon should have it, enable it everywhere. If there is an
> option to save some gates and leave it out of the silicon, then we do
> need some per device knowledge, or a register which tells us what the
> synthesis options where.
> 

I have looked into all config_debug* registers of multiple versions 
available with us and there is no mention of WOL. I think we can add 
MACB_WOL_CAPS to default_config and advertise in ethtool by default.

Please let me know your suggestions/thoughts.
-- 
???? vineeth