Received-SPF: pass (google.com: domain of linux-kernel+bounces-82737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <eff34df2-fdc1-4ee0-bb8d-90da386b7cb6@intel.com>
Date: Tue, 27 Feb 2024 14:08:23 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or
 TME
Content-Language: en-US
To: Dave Hansen <dave.hansen@intel.com>, Paolo Bonzini <pbonzini@redhat.com>
CC: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>, Zixi Chen
	<zixchen@redhat.com>, Adam Dunlap <acdunlap@google.com>, "Kirill A .
 Shutemov" <kirill.shutemov@linux.intel.com>, Xiaoyao Li
	<xiaoyao.li@intel.com>, Kai Huang <kai.huang@intel.com>, Dave Hansen
	<dave.hansen@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, "Ingo
 Molnar" <mingo@kernel.org>, <x86@kernel.org>, <stable@vger.kernel.org>
References: <20240131230902.1867092-1-pbonzini@redhat.com>
 <2b5e6d68-007e-48bd-be61-9a354be2ccbf@intel.com>
 <CABgObfa_7ZAq1Kb9G=ehkzHfc5if3wnFi-kj3MZLE3oYLrArdQ@mail.gmail.com>
 <CABgObfbetwO=4whrCE+cFfCPJa0nsK=h6sQAaoamJH=UqaJqTg@mail.gmail.com>
 <CABgObfbUcG5NyKhLOnihWKNVM0OZ7zb9R=ADzq7mjbyOCg3tUw@mail.gmail.com>
 <eefbce80-18c5-42e7-8cde-3a352d5811de@intel.com>
 <CABgObfY=3msvJ2M-gHMqawcoaW5CDVDVxCO0jWi+6wrcrsEtAw@mail.gmail.com>
 <9c4ee2ca-007d-42f3-b23d-c8e67a103ad8@intel.com>
 <CABgObfYttER8yZBTReO+Cd5VqQCpEY9UdHH5E8BKuA1+2CsimA@mail.gmail.com>
 <7e118d89-3b7a-4e13-b3de-2acfbf712ad5@intel.com>
 <3807c397-2eef-4f1d-ae85-4259f061f08e@intel.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <3807c397-2eef-4f1d-ae85-4259f061f08e@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2taT1llTW1UZ2VUazBIVExNaWZnYzdyL3p3VXB3Rk1naCtydDdWSGFVbjJs?=
 =?utf-8?B?V0xMeFFnaUxpQ3AvVk10MjRySnNBNTNUY2xTMDc5bmxCcldBRHNVTU5EYlNM?=
 =?utf-8?B?Vk9iWmI3bklsZkRkbXIrSU1udTdSWmg1OUN1VXJNMFBpK005WVZhMFlaUUYz?=
 =?utf-8?B?Yy9ndnpVSjFQaHE3N1pXSkdVUjFrdjRXRFduL1J1ekhvWmxoUkxkZmFja0Ez?=
 =?utf-8?B?Nzc4WWlob2JwT2FWbXhpelpQSlVQbUduV3cza2lvMnBxRDFHT2NpdFV5Um9T?=
 =?utf-8?B?d1crTlhyTnIzdjhPZDBPbndVUDV3Wm5XWmo0a1d0OHVkVG5oVXVsSW5OSFBq?=
 =?utf-8?B?blc2MSs1T3JPNk1qZ3VRaTBHZkxicWZNOWVNLytmWitpaXNrVVNXREgwbGJ6?=
 =?utf-8?B?MUpUQUt1YVJ3aUI1TXNVNGxVNDBwcFRWS2ZKL21VeXJ5SksrdnZFRWZhTzJw?=
 =?utf-8?B?U2NKdTJ0UVdWclVHT1hXdnVWNE1Hcjl5V3h4Wk5pMGNiSHFpdmUwWVFDNTFm?=
 =?utf-8?B?OTBXWUlSb3Jidm9sb2ZzZi83VHBUMEtBYU9OaWpUOElabWUzRW9UWWs2WE1o?=
 =?utf-8?B?VWlFcXJGSEVpN0FTUElZTk1vT09iNXhEZFZJRGs1cFlFVmh4Ulo2cWxGQnZa?=
 =?utf-8?B?akdxTGxDekdodG5CZVByN0RzVGVLYjZpcE9UbTdNbXpXZGhxMmUxVVpKYmpY?=
 =?utf-8?B?SUVJNW9jQ1FLUHZtRzVOZ1pvMHBueHdaVG8xeXgrcVhmakF2blZINnpWakFL?=
 =?utf-8?B?Y1JvR2plTWd1WUZXMGV1dGw3WXhWNFZINTErMVJ1cG1wRURlMDFGMzl5L3Er?=
 =?utf-8?B?dVBNTGhwcG5LOFlKYkY5RDBrcm9zNXYwWTBwT05ONXdGb2pnWGtVWHRxenhP?=
 =?utf-8?B?S3cxd2NTVHFWUmZoa2FTVUM0dDMyRGZtYTlzVmo0ZTdKVksvYUhVTlBXZm9V?=
 =?utf-8?B?b2x5clhmS0VHNUI3cDA5OXpHeXJ6TzJYekJDeEpWbE5jVnRPYzYreDJKMmxY?=
 =?utf-8?B?TFozRWZJK2FETE9wek9DSGhCUGFUQjZaenJaMFRjZ2lGaEprbW5QV1NkVFBF?=
 =?utf-8?B?azNYRk9KNWh1N2ZGVGJZRnlERWloNkFDU0ZJVXM5aEZtVnVsYVFqZ2dTVGV5?=
 =?utf-8?B?UlNJcldOVEhMSll2eFNaQ2JnV3M1anZWU0VPYzlXMHhnUXNkdTZLYVJXcGhn?=
 =?utf-8?B?V1MxWkNZTlVqa1pINVZnNkhGdHZOSzdoN21ZaGNHeTFHVUJGcHg3VkQwNXBO?=
 =?utf-8?B?QXo0Q2hnY09TWmNUQkM4U3BzbkJHRWdyTmJRbllkNXpJd0VCRmIzWG5FVmNY?=
 =?utf-8?B?NkVvUXVHRUQrZCt0TmVGZi94V001TlREa3JJMGtkdlhyRnZlN3NqRkZ3SVlu?=
 =?utf-8?B?N1BYbjZSTWJMMWhwOEtPdmVMS3pkaDl5V3o1MjVwSU9GNUlsVFBHSHJCVHlZ?=
 =?utf-8?B?UWIyUnNUdFNxZTg5TjFDWTNDWkpSV0U4a3pwZU4xcEVWQ25RYytUYXprb3JW?=
 =?utf-8?B?YVdMdlpFZWhacDNhMWZyb3V0aTl4OE9tSUtEbCsxYklQZHlZNU5aK0ZPdjBB?=
 =?utf-8?B?OHY3azhZdWplSmVyL1o1OTZpTUZHZUk0TUtPRWNoZHJQeHVrU1dBWklRMkhw?=
 =?utf-8?B?aktka09MYXJVaXRtOG5sbzZiNkpOYlJZaGpTTXBGaTFwaXN5RDg4MHZkWGZ2?=
 =?utf-8?B?QllsRTlOVjY5RVpXc0JHbVlObVhnbnJWVzE1TytFRVRTNVpwb05iSERPK1A0?=
 =?utf-8?B?TE1PZkJIMUdLRi8rNkZ6M3MwbVdaempSaW1BblVIR1dZc0FwbEZSSjVXVHYx?=
 =?utf-8?B?RFBsYWZwd09xNHNvSE5FV25Da2hRMTR4TDY5Rld3aDRKL3FSZllBSkhSM1Jr?=
 =?utf-8?B?bStlSHpnSU96M3FtenI0ajFGNHoyYm05OWpRa242Q0JrVFFQYW1Xdktwd0Zt?=
 =?utf-8?B?ZjU3ZVh5TzBYYVAzcVpBZGRTZFZnT2xEUnFpVTVGZjdtZWRlNVRZSEVpWXh3?=
 =?utf-8?B?YldHNndjcWZmMEtyQVBDYmJxS3hMWjF3WGdPa0t6N2g4UldhUFBJRjQ3MGtE?=
 =?utf-8?B?MTZJcldDTTNtNERvUml5V0N6ZXNzcnRXSVlWTmgrR1M1OURDY2Z1L01sUnZs?=
 =?utf-8?Q?21+Uyrcr502wbD38q1CtgLd5J?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b84fa9d-e098-4c22-ecc0-08dc375a85c8
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 06:08:31.2345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I4lXiIG//GrQ2Nlne1piXgcGzeT6ZGcFrYYb+4qtFFujQJftkpOxYHGqfO7v4NoVYKfKbPrRME02WVaeltD5+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8450
X-OriginatorOrg: intel.com

Hi Dave,

On 2/27/24 00:21, Dave Hansen wrote:
> On 2/25/24 17:57, Yin Fengwei wrote:
>> On 2/23/24 02:08, Paolo Bonzini wrote:
>>> On Thu, Feb 22, 2024 at 7:07 PM Dave Hansen <dave.hansen@intel.com> wrote:
>>>>> Ping, in the end are we applying these patches for either 6.8 or 6.9?
>>>> Let me poke at them and see if we can stick them in x86/urgent early
>>>> next week.  They do fix an actual bug that's biting people, right?
>>> Yes, I have gotten reports of {Sapphire,Emerald} Rapids machines that
>>> don't boot at all without either these patches or
>>> "disable_mtrr_cleanup".
>> We tried platform other than Sapphire and Emerald. This patchset can fix
>> boot issues on that platform also.
> 
> Fengwei, could you also test this series on the troublesome hardware,
> please?
> 
>> https://lore.kernel.org/all/20240222183926.517AFCD2@davehans-spike.ostc.intel.com/
> 
> If it _also_ fixes the problem, it'll be a strong indication that it's
> the right long-term approach.
I tried your patchset on a Sapphire machine which is the only one broken machine
I can access today. The base commit is 45ec2f5f6ed3 from the latest linus tree.

Without your patchset, the system boot hang.
With your patchset, the system boot successfully.


Regards
Yin, Fengwei