Received-SPF: pass (google.com: domain of linux-kernel+bounces-82739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3c56d7b8-b76d-4210-b431-ee6431775ba7@intel.com>
Date: Tue, 27 Feb 2024 14:14:42 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in
 madvise_free
Content-Language: en-US
To: Barry Song <21cnbao@gmail.com>
CC: Ryan Roberts <ryan.roberts@arm.com>, Lance Yang <ioworker0@gmail.com>,
	David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <mhocko@suse.com>,
	<minchan@kernel.org>, <peterx@redhat.com>, <shy828301@gmail.com>,
	<songmuchun@bytedance.com>, <wangkefeng.wang@huawei.com>,
	<zokeefe@google.com>
References: <CAGsJ_4zera4+bWuXHKjdU3QdiR3sqcUQB3gF08DPD49OCT4S9w@mail.gmail.com>
 <20240226083714.26187-1-ioworker0@gmail.com>
 <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com>
 <CAK1f24mdwjz2J5VmeYSDwb4jMbrXUVCSF_0pOcWSVt1cfa0FhQ@mail.gmail.com>
 <318be511-06de-423e-8216-af869f27f849@arm.com>
 <CAGsJ_4z+0yXUDYwxKNAqYwxAAYpfKpKd2u_dVTDP3b-KPOQT1g@mail.gmail.com>
 <19758162-be5f-4dc4-b316-77b0115d12ce@intel.com>
 <CAGsJ_4wx72KOazANBvnGcjdZse8W9+PW5_fspP9=QuX3X_7msg@mail.gmail.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <CAGsJ_4wx72KOazANBvnGcjdZse8W9+PW5_fspP9=QuX3X_7msg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0hwa004djlWZ0RDeTg2cG1IdWtQV1dlZTlLNDJkQ21lRWo5N1ZHNXVqQmNs?=
 =?utf-8?B?YnVIQjBCc1Rua3hZYzVybU5iZzlXQkVlOU4vMWc2Qkt2UG5PV1hKSG40Y1RM?=
 =?utf-8?B?VEZ4R3pZVFBxQTB5Qitldlp6bG41MERzQzZEbXlJOGxNK3UvU1JtdW5pNVBa?=
 =?utf-8?B?NHUrTWhycURDZkxKL1VjSUVOTGJwaE0rSmQ4VTYxR3ZhZ2hwOHFMbVlmc29u?=
 =?utf-8?B?ZVB1ZTJJdkdEVzlHUXpqYzBaMEFKaUU3eWJPQ0NYVWVxalVzdVJqVndBRWFr?=
 =?utf-8?B?dmhqb0phZFB6eC9MV2I3Uy9YK3pRSTVwT2VOOEYrUE9rWm5pOXpJck03RUdI?=
 =?utf-8?B?WnhobXZETWROVlFqaDlUc0IrdVlZdjR5dU94b0ZUT3dQQldHeFNkNXQzM0lk?=
 =?utf-8?B?bXVhTHY1WCtMQ0lUbWNwWGwvR3B6WThKOUFRRmxvT3pmcmlscDdFZVIwN1RR?=
 =?utf-8?B?d1RBWTl3cWlHVU5KRUdLTXAzNEJqWEEzOHFKSU44cjZrNXd4Vmd3UkwzWFRt?=
 =?utf-8?B?dUh0V3k3OVJLWVhhNkc4U3B4OXA5dXVtUnJLanE3ZjZubEUrMHNtanhnUjRJ?=
 =?utf-8?B?NGlGM2NWeHc3Qlk3UDd4eWtONDVWNCtkc0psVTZmVXR0QU1IT3VPY2YraG9m?=
 =?utf-8?B?SnBYN0JkK2ZFL0VjVENaY010SW5SbFpHai9SZG4yNTVUVnM0S0tqQUdoSlBj?=
 =?utf-8?B?N1BuL1hud215dVcvdTNyVVdTN1pJVDJrQm8xUy9PdU1QYVFCT053QmxmajZt?=
 =?utf-8?B?cGtEU0pGZWE2WjkvSHMxcVZZdmhnQk9FT1Y4a0pCcndKcnM5bWRaNHdpMTVm?=
 =?utf-8?B?MUV1TmJ6bFVpSEhqamxMWWFKQnhTVHJjZnQ5aFNBZEdkd25BWlRPNGFTZ1Ev?=
 =?utf-8?B?RTBkL2tidXpSMjlKTmdicWVHTFkzbVNMUEVPWlVNVFZrd2l5K1NxVmhlQzdZ?=
 =?utf-8?B?clB2OUJFcE9yM0NnYm0vSi9xMkZiNGJTRFVFY3ZVbWpVVEoxUk9XdDl1VnRX?=
 =?utf-8?B?OWhvbzQ3Tk5JUmxLR1dsVnVJa1dhanMzM3dhNjBaV0VVVER5a2tmSTdQVlRH?=
 =?utf-8?B?T1FtbWFGbjVWbnVkKzQ2c0pBeURGWmpUOUVFNDhxUTRTQnE1MVBLY3JsY1lU?=
 =?utf-8?B?TE1yenk1cTcrRU1nUWl5dTlrRlV0MjhTQkltdDJNZHFpZzd0WWdBY0dDK0RW?=
 =?utf-8?B?aVF6R1BscHlvTEVUU3g0K2ZuYjVXOVd5ai8vUWh5U3Jwb2tQSnAyYXNtWm4r?=
 =?utf-8?B?eEsxdWpud3pLc085dEhkaENEVXU3dDhjZVBSaTRGYVcwY2NsdE9zRHYrT05a?=
 =?utf-8?B?dk1ZcmtXU1J4bFIzMXlkdlB4ZS83VDN4aFJLS25CTVYvVk5UeG1RRnJvVGxL?=
 =?utf-8?B?T1IrdE1uNW9Wb0xRSHR2dGxGcWVhUXZWbENZMXVjQzlnQmJZVm44a3VCQURq?=
 =?utf-8?B?T3greksxeEZQb3kyWjhnM2dYaU91TnQ0RWxPRkppbVlCMU4yeXpCbkFobmlw?=
 =?utf-8?B?VjFqSEQvZlQyK0lkTDg2SWZHWmtEby9XNW9WeFRVV3hocnlaeTlpbEF0K1BH?=
 =?utf-8?B?Q2UrTWNlQjVjM25NLzRjMkp2SVlDQ1lBSXZNTUFWYS9XeVphRzc1SUVwb09u?=
 =?utf-8?B?UHJ0MDhTZVlHbEF3Q3E0WDdBd2djZXVsZENsNWpqcGs0eEV1ZnpzNHZTdGdx?=
 =?utf-8?B?b1BMNGtWamh5alZDVnVsQzB5dnYxcHpBenpXSi9lcUlIcnZCOFYyRGNTYVFW?=
 =?utf-8?B?Q1FwcEVGSlhFWjF0VHNkWmU5RnVVYjIxUytzVHV1VGw2TFFTbFl5eCt3cTVT?=
 =?utf-8?B?ekxLNEZZUzhiVXZQWDVLZXBVSXFreGZTRmxQbmwxRWM5bjZRUng3UTVwMVZv?=
 =?utf-8?B?dUoySFFCRUM0bVozdjFlV3o1bEJ3dVFMNVhialRKenB1SDlsLzMvRUJTNUVZ?=
 =?utf-8?B?QWY0ZWZkeDBLZDJyR1RRenRSSlNMdE90M3lPeXMyQ0oxK2x6aGF0VEY3a3M1?=
 =?utf-8?B?U2ZDRjJ3dC9QeHV5alJwUUlXa01qVFczbTZNb0FkdlRZRExrQ3drRTNhMStB?=
 =?utf-8?B?dzVoU0paZktFd2M5WTRUQzZkV3p5NmRwVmE4UmtOUG5obEh6NFgzZmtFMTBa?=
 =?utf-8?B?RU9Bc3QwckRTTmlHSTRZUElDbVFiaG5Fb08yZnVReXdqN3Nnb0FYSkFIby9H?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a8a5a7b4-32ef-4a98-5c48-08dc375b6714
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 06:14:49.1735
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jetsw9LEd9mqEaeS0IO2yVDJrEuANDvpQ3UEKv+hQnySLGkol/H33NPdk6DhdkZNAk+3WjgbkLoGZBR5WkrEdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7171
X-OriginatorOrg: intel.com


On 2/27/24 10:17, Barry Song wrote:
>> Like if we hit folio which is partially mapped to the range, don't split it but
>> just unmap the mapping part from the range. Let page reclaim decide whether
>> split the large folio or not (If it's not mapped to any other range,it will be
>> freed as whole large folio. If part of it still mapped to other range,page reclaim
>> can decide whether to split it or ignore it for current reclaim cycle).
> Yes, we can. but we still have to play the ptes check game to avoid adding
> folios multiple times to reclaim the list.
> 
> I don't see too much difference between splitting in madvise and splitting
> in vmscan.  as our real purpose is avoiding splitting entirely mapped
> large folios. for partial mapped large folios, if we split in madvise, then
> we don't need to play the game of skipping folios while iterating PTEs.
> if we don't split in madvise, we have to make sure the large folio is only
> added in reclaimed list one time by checking if PTEs belong to the
> previous added folio.

If the partial mapped large folio is unmapped from the range, the related PTE
become none. How could the folio be added to reclaimed list multiple times?


Regards
Yin, Fengwei