Received-SPF: pass (google.com: domain of linux-kernel+bounces-82771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Uladzislau Rezki <urezki@gmail.com>
Date: Tue, 27 Feb 2024 07:59:18 +0100
To: Martin Kaiser <martin@kaiser.cx>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] lib/test_vmalloc.c: drop empty exit function
Message-ID: <Zd2IRlYaBLDOVboY@pc636>
References: <20240226191159.39509-1-martin@kaiser.cx>
 <20240226191159.39509-3-martin@kaiser.cx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226191159.39509-3-martin@kaiser.cx>

On Mon, Feb 26, 2024 at 08:11:58PM +0100, Martin Kaiser wrote:
> The module is never loaded successfully. Therefore, it'll never be
> unloaded and we can remove the exit function.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  lib/test_vmalloc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 191b6bd5dff9..d0c0cbe1913d 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -600,12 +600,7 @@ static int vmalloc_test_init(void)
>  	return -EAGAIN; /* Fail will directly unload the module */
>  }
>  
> -static void vmalloc_test_exit(void)
> -{
> -}
> -
>  module_init(vmalloc_test_init)
> -module_exit(vmalloc_test_exit)
>  
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Uladzislau Rezki");
> -- 
> 2.39.2
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki