Received-SPF: pass (google.com: domain of linux-kernel+bounces-82773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6ea0020a-8f4b-44d1-a3b2-7c2905d32772@intel.com>
Date: Tue, 27 Feb 2024 15:02:22 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in
 madvise_free
Content-Language: en-US
To: Barry Song <21cnbao@gmail.com>
CC: Ryan Roberts <ryan.roberts@arm.com>, Lance Yang <ioworker0@gmail.com>,
	David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <mhocko@suse.com>,
	<minchan@kernel.org>, <peterx@redhat.com>, <shy828301@gmail.com>,
	<songmuchun@bytedance.com>, <wangkefeng.wang@huawei.com>,
	<zokeefe@google.com>
References: <CAGsJ_4zera4+bWuXHKjdU3QdiR3sqcUQB3gF08DPD49OCT4S9w@mail.gmail.com>
 <20240226083714.26187-1-ioworker0@gmail.com>
 <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com>
 <CAK1f24mdwjz2J5VmeYSDwb4jMbrXUVCSF_0pOcWSVt1cfa0FhQ@mail.gmail.com>
 <318be511-06de-423e-8216-af869f27f849@arm.com>
 <CAGsJ_4z+0yXUDYwxKNAqYwxAAYpfKpKd2u_dVTDP3b-KPOQT1g@mail.gmail.com>
 <19758162-be5f-4dc4-b316-77b0115d12ce@intel.com>
 <CAGsJ_4wx72KOazANBvnGcjdZse8W9+PW5_fspP9=QuX3X_7msg@mail.gmail.com>
 <3c56d7b8-b76d-4210-b431-ee6431775ba7@intel.com>
 <CAGsJ_4xu1kz5VD-CcNFvP0A1nPKDojV8Gy1HPvNKuQ_RAw=26g@mail.gmail.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <CAGsJ_4xu1kz5VD-CcNFvP0A1nPKDojV8Gy1HPvNKuQ_RAw=26g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjBhbmxyck9ERytOVTFsbzdjMzNDUmFiU1J5U0NzU1FDdCtrRHN6N3JWNHBR?=
 =?utf-8?B?dVJVRmV5TXYyTEQwdjUrNGJ1NExxTUhXaUtjbXZqS3ZKR0RjenRQVEJMc1gy?=
 =?utf-8?B?RHhZOVpEbUlkKzJ1THpuVm80Z2NCWlNFVTNKYzJobXZBOW1OOXFhTFcxVTQ2?=
 =?utf-8?B?ZWs4cm5pNzVOOEJjbVlySTcxOHdPT0JNZXpNQWZ3VTFJcHh2WDFhazZTUFJH?=
 =?utf-8?B?TmtUaWZ2NUx3SFZGczRrOGdWb3hLWWNFalFYNTZFRGIzOHB6NjM2a0tmRFp2?=
 =?utf-8?B?bUdqa1dicUxOZlpnM2gvRUZCUUgyYVlSa3FqbVJTSmt5MU5ybzRIS2o2NlRo?=
 =?utf-8?B?UEdVVXp4OW1wTzM4OUxueWJ0WnJmRVE5SkhCV0xWTkh3eVNpUTlSRDlxOURn?=
 =?utf-8?B?MG96Y3NySVRBZ3lXSEU3K1l6Nmt3aUY0QkZEck9nYjR4c3E1alNsUGN4UE9E?=
 =?utf-8?B?MmtJbVZKOFMzTUNnaWVMa05XYVl2cTQraVlaTWN0d1h6TmMxNTZJVEJvNG5C?=
 =?utf-8?B?bVNCQ2lQbkd0Z0x5YkR5OEllYVFZU1pnU3AzVmhkQ3huNHhvb2ZpSjFTNVJW?=
 =?utf-8?B?d2x3MGVmSDV6TkRaczJmWXBtMW1LdU94dTZEdkFNaVIrMHBCMk1NZ05vaytF?=
 =?utf-8?B?RnBCTnhMOUhTSm5ROU40ZHVkbC96ZHBZd1o1YklBK3hZQmZLcUh5VXNSdU1Y?=
 =?utf-8?B?R3ZWaW9hS1Q0aEpvVGw4d3YwMXQva05sdU85Y2VPbmF3eDRVaVpRTkRiNStQ?=
 =?utf-8?B?MGdnK0plYVNKQ0llUFJjZEtVbzltcGJSNWdXdlJtc29yS2NRRjJNNXF6ZFhl?=
 =?utf-8?B?NGtwN3dCdUV6VGdweEtPMndadVZYWitPZFlic2gzNGtMZ2ExV1pQbVp3U2U0?=
 =?utf-8?B?Q21SUEpaazNPZWlzemdzSlZXZE84eEp6NlhyV0gvMTNDdHVDL0x2bUt4UWdX?=
 =?utf-8?B?Y2hPOGhrdjlWdDNnQm1GbnM4RlowTVRJR2ZaRmR6OU1pWkdsZUtiQWpmVmxa?=
 =?utf-8?B?eGZ0WVhMQ1k2aFk0dm9VNzZJMnA5d21uRU1xSWJmK1lwSTVDMWorR2dhODM1?=
 =?utf-8?B?TzF3UnBtQnlQKzB6NzQwWURPZ2hCZkxwaVBITWhFQkxyYnAweUVPMnl4QnNF?=
 =?utf-8?B?Vnowa3RmaGxPNElwd3hCZGJoL3Q3eVV5NE8veUtsTTAzei9TcitmUENCTDVQ?=
 =?utf-8?B?eUtBRDdWWHBoNUJtbXNhQis0UXN2dWJrc1h4TXcwQTJPVVpSdGhWcXpId2FZ?=
 =?utf-8?B?VHJ3ZjVDcDhPckdXT2NEVlhXYWdXWkRiUS9FL0VoMGUwMkhUL21ZOWxlQ1dU?=
 =?utf-8?B?M0lBS0Z4b2VuakgrM3RZSnhybkl1T24zWUVCWm9uTnRhNXdVUTNGUmZBc0xp?=
 =?utf-8?B?VzFoTUJteXl1bUh4UzQ4bzRKMW1TR0ltQ0M1aVVrV1lWQU9rOHJuL3NPVzBh?=
 =?utf-8?B?UXpnMFBOVkFQNkQwaDR0RlRsZXBveXdKZlBab0NKZTdwT3grL0RiR2xjN1VE?=
 =?utf-8?B?dlVHZlZSZEJ3K21Ib0diajk3amUvdUkwYVRTZG1iZlR6bUY0ajBvbVdZMWZK?=
 =?utf-8?B?NGwzdU1oaXllT0h0cVNnRjJmdVNOSnlIakZhRXdKRG53N2gwM3RXbHZYSWJK?=
 =?utf-8?B?aDVsRWk1RHRuK2x2dDlpQjRvcEhBeklVMURYRSt0dDQxRjNaTVpkUXNGelpV?=
 =?utf-8?B?c1ZMcXZnWlRGR216YlhwUFoyTDMwTStpaXNvZ3FuN0Q2Q3JDUnBEU3FkRkNx?=
 =?utf-8?B?cEswVG9uOTV3UkdLVDRaQllHWXdPZ2FZN1l3djdqOTdWL1Myci9tNXlvRnYr?=
 =?utf-8?B?TjFINmZMUnBSU0owdlFSL1pCQVIzQ2NBbkpzUUVVdURFdXNnYTFXaXY4cEEw?=
 =?utf-8?B?WVU3aGJrcTUzODh3RTBBZ20yTHBLVFFsS2RnbkNwbGxWYTF2MFBrTFlHV0dF?=
 =?utf-8?B?STZQaU5pYXprLzVVdml5N1NDV2NnWkVTNmtrc1EwSmlvR0hKQXJwVnRzSm9v?=
 =?utf-8?B?N0xSTG5jNXlZdHhoUnBpU3FCMUZ4MmI1TXRsU2JCcFo5cDVZSzltdWIwck01?=
 =?utf-8?B?ek5kRlhLenlVamZpcmt6VE1VNU5FQmsxR2RSYkVGenh5SlROamJ6ZkFuTDdn?=
 =?utf-8?B?dGNCUHZHdkYzY1NJeUtLRnNJRGRRVG10SHNsZitRaGpQc0x3UUhTRUZHVlVO?=
 =?utf-8?B?QUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a3814ff-974e-448d-daec-08dc37621077
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 07:02:30.4812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /u5mZ7tfTF6gTsNQl0lcvNNRaIE/6u3yUKLJU8s8agP905iOaqI0J98VTjaKgszk2+3xzKsoEC4U3vsw900lig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8062
X-OriginatorOrg: intel.com


On 2/27/24 14:40, Barry Song wrote:
> On Tue, Feb 27, 2024 at 7:14 PM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
>>
>>
>> On 2/27/24 10:17, Barry Song wrote:
>>>> Like if we hit folio which is partially mapped to the range, don't split it but
>>>> just unmap the mapping part from the range. Let page reclaim decide whether
>>>> split the large folio or not (If it's not mapped to any other range,it will be
>>>> freed as whole large folio. If part of it still mapped to other range,page reclaim
>>>> can decide whether to split it or ignore it for current reclaim cycle).
>>> Yes, we can. but we still have to play the ptes check game to avoid adding
>>> folios multiple times to reclaim the list.
>>>
>>> I don't see too much difference between splitting in madvise and splitting
>>> in vmscan.  as our real purpose is avoiding splitting entirely mapped
>>> large folios. for partial mapped large folios, if we split in madvise, then
>>> we don't need to play the game of skipping folios while iterating PTEs.
>>> if we don't split in madvise, we have to make sure the large folio is only
>>> added in reclaimed list one time by checking if PTEs belong to the
>>> previous added folio.
>>
>> If the partial mapped large folio is unmapped from the range, the related PTE
>> become none. How could the folio be added to reclaimed list multiple times?
> 
> in case we have 16 PTEs in a large folio.
> PTE0 present
> PTE1 present
> PTE2 present
> PTE3  none
> PTE4 present
> PTE5 none
> PTE6 present
> ....
> the current code is scanning PTE one by one.
> while scanning PTE0, we have added the folio. then PTE1, PTE2, PTE4, PTE6...
No. Before detect the folio is fully mapped to the range, we can't add folio
to reclaim list because the partial mapped folio shouldn't be added. We can
only scan PTE15 and know it's fully mapped.

So, when scanning PTE0, we will not add folio. Then when hit PTE3, we know
this is a partial mapped large folio. We will unmap it. Then all 16 PTEs
become none.

If the large folio is fully mapped, the folio will be added to reclaim list
after scan PTE15 and know it's fully mapped.

Regards
Yin, Fengwei

> 
> there are all kinds of possibilities for unmapping.
> 
> so what we can do is recording we have added the folio while scanning PTE0,
> then skipping this folios for all other PTEs.
> 
> otherwise, we can split it while scanning PTE0, then we will meet
> different folios
> afterwards.
> 
>>
>>
>> Regards
>> Yin, Fengwei
> 
> Thanks
> Barry