Received-SPF: pass (google.com: domain of linux-kernel+bounces-82798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 27 Feb 2024 08:23:06 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>, kernel test robot <lkp@intel.com>, 
	Stephen Warren <swarren@wwwdotorg.org>, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, 
	H Hartley Sweeten <hsweeten@visionengravers.com>, kernel@pengutronix.de, 
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 2/3] spi: ppc4xx: Fix fallout from rename in struct
 spi_bitbang
Message-ID: <y2my7hxrpnwg72ols6a5w7n6zqz2yaxtswq4zlv6xpguiyaunm@tguc7ua3ypa5>
References: <20240210164006.208149-5-u.kleine-koenig@pengutronix.de>
 <20240210164006.208149-7-u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xfad3cqeidqpairm"
Content-Disposition: inline
In-Reply-To: <20240210164006.208149-7-u.kleine-koenig@pengutronix.de>


--xfad3cqeidqpairm
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Mark,

On Sat, Feb 10, 2024 at 05:40:07PM +0100, Uwe Kleine-K=F6nig wrote:
> I failed to adapt this driver because it's not enabled in a powerpc
> allmodconfig build and also wasn't hit by my grep expertise. Fix
> accordingly.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402100815.XQXw9XCF-lkp@i=
ntel.com/
> Fixes: 2259233110d9 ("spi: bitbang: Follow renaming of SPI "master" to "c=
ontroller"")
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

This patch made it into v6.8-rc5 as commit
de4af897ddf242aea18ee90d3ad2e21b4e64359c. However 2259233110d9 (i.e. the
commit that renamed "master" to "ctlr" and missed to adapt spi-ppc4xx.c)
isn't in v6.8-rc5 but still waits in next for the merge window.

This patch applied to v6.8-rc5 made the driver fail to build.

Assuming we don't want to have this problem in v6.8, I suggest to revert
de4af897ddf2 and reapply it on top of your next branch.

If you're interested to prevent such problems in the future, there is a
tool in https://github.com/krzk/tools that can catch this type of
problem:

	linux$ ~/gsrc/tools/linux/verify_fixes.sh . v6.8-rc1..de4af897ddf2
	Commit: de4af897ddf2 ("spi: ppc4xx: Fix fallout from rename in struct spi_=
bitbang")
		Fixes tag: Fixes: 2259233110d9 ("spi: bitbang: Follow renaming of SPI "ma=
ster" to "controller"")
		Has these problem(s):
			- Target SHA should be an ancestor of your tree

Thanks to Anthony for reporting this problem (by private mail, so I only
added him to Bcc).

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--xfad3cqeidqpairm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXdjdkACgkQj4D7WH0S
/k5yRwgAgp0i6quBP/xiG9njBGmFgomRMkdjKqKMG3EXt/gymMpcTqs1KdyR20Im
5OV8X9kmzzaWjA4Syqgp9nWcRxdw86X5psp17Bp6YpV5aNcREivDIYg5LXBDGn0U
tPYieP20nrJhmaG62hzM+IAg7XrqwKJ5j2rMnIeXL+Yr0zNNoR8XMuD0xmLJFmht
uXEUvm+FVFPauj9xG+Cab8xT0TBXoFeHKfswfDlunzWUsWGjCxv00Dph48xPGcuO
pU/LL5hzyjthFeJdPSegqAMk6EHxqbSjhw6dDv290y/76lLgEpFfkliPouzdprNK
Gu7reGLuMQRa8OqyQDq6wnLMldd0ew==
=XONH
-----END PGP SIGNATURE-----

--xfad3cqeidqpairm--