Received-SPF: pass (google.com: domain of linux-kernel+bounces-82808-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Subbaraya
 Sundeep Bhatta <sbhatta@marvell.com>,
        Geethasowjanya Akula
	<gakula@marvell.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom
 information
Thread-Topic: [net-next PatchV2] octeontx2-pf: Add support to read eeprom
 information
Thread-Index: AQHaaU+lbCOwZ7NarEOE3SUT7nyDdQ==
Date: Tue, 27 Feb 2024 07:36:16 +0000
Message-ID: 
 <CO6PR18MB4467EA7976DEDD6872D0BC54DE592@CO6PR18MB4467.namprd18.prod.outlook.com>
References: <20240222171542.12995-1-hkelam@marvell.com>
 <20240226170027.6a43f196@kernel.org>
In-Reply-To: <20240226170027.6a43f196@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?aGtFD9xUbkVgqXQgW3vRJ61FaW0cfBviiMAXQ1Kj8U/3QW5JzpGyrWY8RBzN?=
 =?us-ascii?Q?91ap0GOdFJGhfOQNPX1pHsznNNCH7wzfJYfoI0MnPLgTsJXMDum2qQr0Ciec?=
 =?us-ascii?Q?RxIZiPaHWLyLU2q2wldS/pMOzcCMDgA3QCetHhlveiqsykR1iD65oQRM8yq6?=
 =?us-ascii?Q?QjKRymwBsnIPoWcojqimggKRvMNMs1QXnElL+MVgdBdxypZ8337HdtRRShbf?=
 =?us-ascii?Q?uHxGoDRvcYkdsfIsIezTjxBj410frMZk537h7HUbGzxt/9IejfX6AX2FWvBW?=
 =?us-ascii?Q?McRAe/mGZkzGgcumCCK+9lacn8EHF1+o1TAnCnhRJ1Ti4cBctWOCJtplP5RT?=
 =?us-ascii?Q?eLgTmgDWz2JXD45wmNtb4TRzpLG1VgC+q9tFh2D99hsPVqRh08oBy7KsgUnL?=
 =?us-ascii?Q?/WDIqNjm39Nspl7ehUpSW+zhYftKnAJC2XLR6nEn4UAd7QKT5Xpnmv4P5gEW?=
 =?us-ascii?Q?mN+UIvNQ/KorOEDUWskQ+MFdjpdF8MqLY8UmcnqNIKlBzUpg2vPeQD9yjMRl?=
 =?us-ascii?Q?RF2FwDMF3E7H7fY+PSvprUV+Wb72eGLO5Bzp7YWx1H6XMx8r1nLXM91RN9X6?=
 =?us-ascii?Q?BXCbE3V8WPl7j4mTI3wrwucmsm2dAwvI869nVHcWJ2OqGZqYD5HtYBPT+RnL?=
 =?us-ascii?Q?Q9YcRaBeYpDzK/5sGLILYoW7RGuBPdPD7wm2Ptn9D+mDJVwJObLdCViEUwhS?=
 =?us-ascii?Q?B3BUpVzK7qVQZyZ5ZYtES56FnYEh/1BvtwGZEUGEcg6tH20+Jq1uqcH4k7gK?=
 =?us-ascii?Q?RrWrzYm+0MMQwPLNtMcAUXxdod7PTrmxLFWIqiMtrVqz28eXmqRs/x25naV6?=
 =?us-ascii?Q?fvmitwPnxTxxkN4pv9KvPCVQXhK/rBJH8S+XUbMMyIhFZP88KofD53bokNwh?=
 =?us-ascii?Q?o9A7QRbHXjPp1v4+LnH62yBrvxz1URzTY9jHbgB/dCo8hmcJLow5b+LYiLOg?=
 =?us-ascii?Q?yK6BLV3xoWQi3KOEPEK/anScCb4wfy1g1SSJxXUEI9PWDUdhICSQ4y5+aKKY?=
 =?us-ascii?Q?27c4PnPdwCJLKMC6BnmIYE1TMd2TViZY/09UEAieedy0iBg0SkYdmE/hhxC5?=
 =?us-ascii?Q?om/GN2uwAQPkLjESp+hqOir2IDjQdt4jt0VIFm7gNN6MnwXLDJ1OuISdIFBh?=
 =?us-ascii?Q?BueX1PIbSGQNz9ojuk3CGIyQkPxwSv8Sbf4pl1DJRMD/bbapdkEJOWB2wLvv?=
 =?us-ascii?Q?vWil65c7zKxqzu6Ebbfv7V+jqoBRMPphsWwomqAj7bNCwk3txSCEVilRDei9?=
 =?us-ascii?Q?N9duNF4PUm4ESgXahTIJ93YVEt3ZN4ML/y3yIylRVJNFWQjlTcdK7e840tHM?=
 =?us-ascii?Q?096eF9zWRG8h7AMEfqhAoxZz8bTAK4dlsMfk6k0ypYoTzSHFHFphImrlWTP1?=
 =?us-ascii?Q?3/Hxhie3aYVTokBxkU24eqrCZ0Mk24eY6eVUHnJoFxm49vu+oc/PKYImoe27?=
 =?us-ascii?Q?7ixbNlQXWJg2LeHtFoC+FTNjmv/yUU5ILWo4tB1wbw6dEsHKQVg8GxR2c/Jp?=
 =?us-ascii?Q?QNbAXYYvAMZLr3hUMsGo/3sebKLfXHooOHeIMwV5FD9ntJ24RFINzyoEtHHu?=
 =?us-ascii?Q?eEcwb+PsNC2wLjzRsfQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4467.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 018a660e-92d0-4726-451e-08dc3766c836
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2024 07:36:16.4358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i9W8BTVVoUmtY+R4AVjKR2R10cvuQk8TCzPWSt4coI6OqArLgX2hdxUooDyt/QLPxPEhAnE4xRpyVMe0nCCelw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4937
X-Proofpoint-ORIG-GUID: -IUi4Cso-3yI_JWqNuII78k0_NqnZEY4
X-Proofpoint-GUID: -IUi4Cso-3yI_JWqNuII78k0_NqnZEY4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02


> On Thu, 22 Feb 2024 22:45:42 +0530 Hariprasad Kelam wrote:
> > +	if (!ee->len || ((ee->len + ee->offset) > SFP_EEPROM_SIZE))
> > +		return -EINVAL;
>=20
> Are you sure there's a path thru the core to the driver which would allow=
 len
> =3D=3D 0 or the size being larger than when info put in eeprom_len?

 Seems these checks are not necessary,  will remove these checks in next ve=
rsion.

Thanks,
Hariprasad k
> --
> pw-bot: cr