Received-SPF: pass (google.com: domain of linux-kernel+bounces-82908-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7d132b63-7336-4f59-a5f0-5ec37c3c34d3@oracle.com>
Date: Tue, 27 Feb 2024 09:06:19 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: libsas: Fix disk not being scanned in after being
 removed
To: Jason Yan <yanaijie@huawei.com>, yangxingui <yangxingui@huawei.com>,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240221073159.29408-1-yangxingui@huawei.com>
 <d765d2c5-3451-4519-a5e1-9e8f28dcd6b3@oracle.com>
 <cdf241a7-8504-5b87-2d18-d2a971f6ebb9@huawei.com>
 <8dc34f04-943b-26fd-01bc-34fb98803503@huawei.com>
 <b2ab5439-361b-4160-4e73-171026ecc486@huawei.com>
 <8138ab55-1c43-8df1-dafd-95b16b7b3ce4@huawei.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <8138ab55-1c43-8df1-dafd-95b16b7b3ce4@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?T3VvYmxHZC85WHRrVm93T3h4bERhUFRxUlkzOWRXTWJKRk1sVk1vQXd5RlRT?=
 =?utf-8?B?b29SL1dRSldjSnJ4Q3creU1yM1hTbzVCaEZ0STNWN2tqT0I2ekdvSjhLY1V5?=
 =?utf-8?B?bGUxMEFGNFprbTM4ZTJqV0dNWG9Kc01HbHJpWVNyMnVTclJkWWdOSGVIUFhx?=
 =?utf-8?B?NjNqelRmZE5xN1F4NE53SFR4TGFpendYT1dPTmV1dGFvUGcrQlpUMnN6T2tV?=
 =?utf-8?B?WE5IcmRWYzRFZ011Z1VrZTAyZTBBZHEvWjhxMkVTYXB1ZUQ2RnU0Q0lLS05D?=
 =?utf-8?B?WXVYQ3ZEVVg3TWtyR3RqSHhWbERxUmxLT2dFZWh0MldBOTMyc2pwRVBxdW85?=
 =?utf-8?B?dGdtaWpISFkzRVMydmFZVnVDQkNvY3B2UFJNWnVpaGxWakpLbVdUTmk2Zm5F?=
 =?utf-8?B?aEwrMitkVGNLTXgrU3lxUGtaK2d3T1lCWEFzS0l6Q1cwdXBBRnk4TzlDajRw?=
 =?utf-8?B?WkErOVUyZTdNbU5qWURGbXBNVGNBYnZnVnR5amRMTEI0OUxIRlNMcmNDOCtq?=
 =?utf-8?B?M0xXTldLclhrT1V0WkVzbjF5R1NIcnFYK1NyUVJOdFNYdTBLNmhVL0ZGVURa?=
 =?utf-8?B?eHhkTVQ1clIxWE9qWFVtdzNhUDVXemtMYkdmRlh5WXdmVGQrbTFUejFnYjZj?=
 =?utf-8?B?SkVsZDFiblV5TllMZ0JKWWdncHlIemxjRXYwbWhJS0U1TlJMZ3JHbnFmWVRK?=
 =?utf-8?B?RkdCNm9xSUc0QmgyeU5lemoyVlpreEwzWndWTTFSRE1qbHpTVllBTmhqck1o?=
 =?utf-8?B?MTNaSzIwY3RTMXRwZkxsTmZLWFhxZ2FrdWRSRmNUZ2F1a1ZlLy9YRGtkVjBX?=
 =?utf-8?B?QUJwcDYvREprVnNWZ3RINWh4UjRnMHV2R2h6c2w1ZXAzUVBjUXM0WDlzak5Y?=
 =?utf-8?B?MWdjc2JiSnpKbkh5Qis3dkRZNjB6bnNJQkRiaURHSitvRGJZeUNWYTlPRG1z?=
 =?utf-8?B?SkoyVkhXclRvME5JYmhpTERBU01UL1lOdFUzUm1lTkQrQnlMci94dEgyUlpV?=
 =?utf-8?B?V2EvUDB5bDljUWRYbzN0bmtxdHYvUVgwYmhJdjJ6QmJrbmlNMHBTVEVheEd3?=
 =?utf-8?B?QUZ4NTJzQXhZMHB2WEVGdUtVam5tenRKY3p4ZDRDT3hhdThTYWtQeHJuSGhm?=
 =?utf-8?B?cUZEZUJaOVBKdHR1d3FqTkM2a2ZxVzI3aXgrUDZMeTNyWnB5ejk5QlZlaWxV?=
 =?utf-8?B?MndiemxIYnJHT1p2dWV4b1A1ZzVoM09UK0pOOUtjSEtBSzVGWENqQnJrczda?=
 =?utf-8?B?NVFGbHV6dGtpRllGaXRReVRQM2xiOUhpRlJwaHNRdHNSMk55b2c2bzk4bW0w?=
 =?utf-8?B?Y09LaVd6MGt0RUVkcnpKeThReGI2bGdqT01GMm85VTNOWjh5SzlpdGUwVUZQ?=
 =?utf-8?B?NXJWdkNlajVsL0F1VnQvckZZTWxtNHpVN2VXKzlYNkxFc0tNYVVTenU0ZkQy?=
 =?utf-8?B?cC9kZnhBTmFRNXRFWFlWNndVYW5zK1lIMkFBZGxwU1g4TDRjeDhZL3V5UU9s?=
 =?utf-8?B?ZUxBbjJ0WVdOcHk0NkNQcys1V1hiWWI0aHFRQU9FL2dZdnJaSm1ZYUc5TW1x?=
 =?utf-8?B?ZHpxTENjL29naCsxRE9FMW9weHhqRVd1MG9IZ3ZHd3U5Vm4wcnBtQ295VEsz?=
 =?utf-8?B?cDN5eXRxMU9uZ3Y2TkNnSzl4R1NUWGpobXlNMW5qRkwzeDZPdzlnWnBXd1pN?=
 =?utf-8?B?UTNjU2tFQWRqTmdTdUQ0d0lFT0loRjl5cGhFU25lNzZVb2dEbHFONlkwMHRa?=
 =?utf-8?B?bFBIVlpobmU4RjIrOXZIdzZ2UTZmTWFlYVFRWldLRnU5VEJlajgvVlFmamNJ?=
 =?utf-8?B?U0JIOWwvWnhhZlpyckVLV3VPTS9hODdDSUFJZlFYS0pEenp0Q1FVK05OdTMr?=
 =?utf-8?B?N0t1d0JVSWRtUmc5dkNYbUEybGYzSkU5dlFwTlh5ZU4zbmhUOC9ocm5ucWJi?=
 =?utf-8?B?aHhjVVdDRzNEODlHbXVjL2Z1TytxaHFHUVkwYWY0eFdhSWVlK2YxTGNsV2tC?=
 =?utf-8?B?Zi84S1ZMdi9oU3hjOUpjbUgrYWU0aHRIeFZ6S0RQcktmOUZlWE5IVkJtUmZ5?=
 =?utf-8?B?WlRSbURjV3hJalQzN0FPWlpiZFhqQ0p3U1EybGNVNUtJZnJreVdXZWUxVzdD?=
 =?utf-8?B?VllPRjMyeWxJVytrbGJvYnkvOTBFWm1hNStSZmlWR2s4aFdiUzlLU043WXQ0?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	OR62mmCIMbdfxHim9UHUbU0CLCB3RzBI0CbpO8WgfkQSCegKVrdnDfBrauZcv6gFnmRp7nNEOEUFcNs7wlO261AQxLhY/EtAqHg+QfCa4OuFtKfiPQWbCdzio+kYE6priM4HBTimCfRFYRshAoVZgTbCUEdX48Uni+gPySVj/fh67oPIAy1a7bmv2rCrQqfv7NYMWRCatRyaMOpjGXhDTH2wxUyS2fOk7uR4prgFVu0Fpo7/1n0LRIThpeTec1vGNqm6tCKW3A/DIiHdvXD0ojKFsDNC6hgjROEPOcjotvXFkbq7EvcRc0P4j3AS+IBfkSlnbE0BeEyYQcCrawbzgoPidFBtQtGQA5z9zlli05R+OyxLctjYBP8YXm7ba7h+kO4vW1wlhPy6gQQ8Kc6oWiBLcd3h6g5EWh36a3NzivfyEH+lPdK1uPnYmuL5WxgNZZoMWndC/LQMcA8OwMEaEc6teBZ4ZZV1XCZ60Il+foJVBwaf0y/St3pBXnqfVsSEajLaRea0c73utYGhD3iLuwnHqgE9xwFmaNFz3XdsbBbs5n6hYXoebQ/6xbnW/3lUuxUF3qUaQCvwCD+pKI5iyPwADDHudJQhwAIAxxfyPLo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c81791e-7267-4cae-e905-08dc37735e8c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 09:06:22.8728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wTemxVUmNddQ/9SUhPMTzZ7ZUlX/Z2PgdO5/B5r3ILlZNOnMIfHmnyn2Y95GwT/kqNPuWZmOaad0+Yn8kjQr9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7721
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 bulkscore=0
 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402270071
X-Proofpoint-GUID: o1Z27VFmxh5Ez1qhNHrIVuaoIt8r0zBh
X-Proofpoint-ORIG-GUID: o1Z27VFmxh5Ez1qhNHrIVuaoIt8r0zBh

On 27/02/2024 07:16, Jason Yan wrote:
>>>
>>> Can we directly set phy->negotiated_linkrate = SAS_PHY_DISABLED here? 
>>> For an empty PHY the other variables means nothing, so why bother get 
>>> and update them?
>> The value of the negotiated link rate has two possible values ​​in the 
>> current processing branch: SAS_LINK_RATE_UNKNOWN and SAS_PHY_DISABLED, 
>> and both come from disc_resp. If we do not use disc_resp, but set a 
>> fixed value SAS_PHY_DISABLED for it, it may not be appropriate.

But we know that the phy is disabled, right? It's our phy, isn't it?

Thanks,
John