Received-SPF: pass (google.com: domain of linux-kernel+bounces-82994-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kunwu Chan <chentao@kylinos.cn>
To: manivannan.sadhasivam@linaro.org
Cc: chentao@kylinos.cn,
	linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	mhi@lists.linux.dev
Subject: Re: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller
Date: Tue, 27 Feb 2024 17:55:47 +0800
Message-Id: <20240227095547.160357-1-chentao@kylinos.cn>
In-Reply-To: <20240227051236.GA2587@thinkpad>
References: <20240227051236.GA2587@thinkpad>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=8bit
Content-Transfer-Encoding: quoted-printable

Thanks for the reply.
> > On Wed, Feb 21, 2024 at 04:59:37PM +0800, Kunwu Chan wrote:
> > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> > to simplify the creation of SLAB caches.
> >=20
>=20
> There are multiple instances of kmem_cache_create() in this driver. Cou=
ld you
> change them also?

Sure, I'll change all of them if possible in v2 patch.

>=20
> - Mani
>=20
> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> > ---
> >  drivers/bus/mhi/ep/main.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> > index 65fc1d738bec..7b61d384b2b6 100644
> > --- a/drivers/bus/mhi/ep/main.c
> > +++ b/drivers/bus/mhi/ep/main.c
> > @@ -1493,9 +1493,7 @@ int mhi_ep_register_controller(struct mhi_ep_cn=
trl *mhi_cntrl,
> >  		goto err_destroy_ev_ring_el_cache;
> >  	}
> > =20
> > -	mhi_cntrl->ring_item_cache =3D kmem_cache_create("mhi_ep_ring_item"=
,
> > -							sizeof(struct mhi_ep_ring_item), 0,
> > -							0, NULL);
> > +	mhi_cntrl->ring_item_cache =3D KMEM_CACHE(mhi_ep_ring_item, 0);
> >  	if (!mhi_cntrl->ev_ring_el_cache) {
> >  		ret =3D -ENOMEM;
> >  		goto err_destroy_tre_buf_cache;
> > --=20
> > 2.39.2
> >=20
> >=20
>=20
> --=20
> =E0=AE=AE=E0=AE=A3=E0=AE=BF=E0=AE=B5=E0=AE=A3=E0=AF=8D=E0=AE=A3=E0=AE=A9=
=E0=AF=8D =E0=AE=9A=E0=AE=A4=E0=AE=BE=E0=AE=9A=E0=AE=BF=E0=AE=B5=E0=AE=AE=
=E0=AF=8D
>=20
 Thanks,
	Kunwu.Chan