Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1821366rbb; Tue, 27 Feb 2024 02:08:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWl0y6UMgBm63rhpavnOSFFYHPdi5syUl4XYWFE1BDB2u4h/QPPXVUGCmDX2YN4Gcm9jG9LXrclKZKRYUJQ5usD7NQ1zgjAHJHO6HS1CQ== X-Google-Smtp-Source: AGHT+IHV7oIlS/4lApxi1Lt2e/qnxGX3BV8EhtYBrizUwVrzfxzZSYuUpoU0DiEL7GrDmD87MCiQ X-Received: by 2002:a17:906:6701:b0:a3e:d7fe:4c4d with SMTP id a1-20020a170906670100b00a3ed7fe4c4dmr6211474ejp.57.1709028523247; Tue, 27 Feb 2024 02:08:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709028523; cv=pass; d=google.com; s=arc-20160816; b=MfqMQ2ZzHQTdBtxqXvJBdbtQkwGpWEKdbrKCIRCQO0oJ/euBF+LrMk69gfug/2tX7U ZNiUaJl6Qj2qN1JGGDparlu9jRoeMkoseyIAw/19gz9XoxEfwgZRVvGVL4SdW1PcSC1Q rM2w1ahZ9v6zC3/fMyj0Pa260BKPsZ3bKw6H5sZkY4N7U9paBwuFCfkh2ry7Qdg7ssvN Kad3q6WjVk6UWY3TeaZxuIvStUlcgmujdpAE1J2U+syx7DR0ZwDD23H02QO82NSHktXQ ixff0puwO3EJGpUYPJg9SExp4lNMXistXGsgrr7S3BLH3QhpGG4EDu70WnJQ6nUlK5wT ViDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=ooc5SS3j03ORm6wAIXAzAUPoc8fJQ9XOTzT5/SJVA8Y=; fh=Ms13nVzZ3DR/vLoewdJDrXhAC4cqcs0nCsqmmNM+4Jc=; b=RbCSXfnNKQYZrS2V8Cgc3c3iwfWly9ei37FkaUcLtYwy7iMzjt5UeWLED8Vn0ydk88 QI12G5gixnL92lHEI7ZkyFy2zt9AU63+wdagISQEjEi9XJR4YruR8Txn/qbXdbX/gVWN iO+MvA91mR+ankyb+zbHFnVpp9ZUc7u4UjDMpEHG/qwQFUeH2fbZ2jwJ/TNIW/Gmd4ua uYtVISy0bRJLgHZYYKiKixcbANxpHoCa7uAL9/KQCd20qnOuEGLOxRh1QhHuBFg1FcS8 pgNu2lzpVDQ+u/iPuedQIKXkImuMwQcaN2Nq/axfEiBxxz0vFiKl21Snzk0KszSpoCwM 7+sg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MeRFFber; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-83008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83008-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ah18-20020a1709069ad200b00a4309fb085esi595287ejc.281.2024.02.27.02.08.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 02:08:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MeRFFber; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-83008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83008-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 08E121F2684A for ; Tue, 27 Feb 2024 10:08:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CBBA137C48; Tue, 27 Feb 2024 10:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MeRFFber" Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148961369BF for ; Tue, 27 Feb 2024 10:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028504; cv=none; b=lhC3Y7b7uNqQdjTRqrnJOpILLZMTiA6/KUxNUL1Np8nAEUoSGnVHrPCEeFru55VxmlOKoEVPJBpbJTd0EEVDIopMJO1KR45WbiujtWVVjQSRcEABAv2BjSjGX9UyJtuW2jcVHgE5wcc5Mkp0ZEvTwFPhXm8SN4uEy5KU3uk4qJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709028504; c=relaxed/simple; bh=OI4MKF6CdNpT7v2xjTJZcmr2tJKCwXVfHLHQP+OK1IM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ekpN+SN8pV3FjKg8eZ3VSWTpVZJM9OScNyWrZeOjj7rjXlL0xJSZgMPPXS29OGvv4w6AE1rOpBpId/jYZu1M2XRWUQxwjCOAFL2+jwreWVic2GbYECxamnKiZPKDqJ4HhIh8pyYPOeCTHfgXeIpxr8k7njNzUcKdvynvasUyNyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MeRFFber; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5661b7b1f51so1824377a12.2 for ; Tue, 27 Feb 2024 02:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709028501; x=1709633301; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ooc5SS3j03ORm6wAIXAzAUPoc8fJQ9XOTzT5/SJVA8Y=; b=MeRFFberdKlzYsgoyxeKcHQ6ozmK+MMplb95efJQew4W7qlKcZkZ87JD40yTy3n+zQ D0Vt+gMzHUCNV40OmTJSGr+8j8wwITJGtUJn14jzkduNHBS1QpA3coTb64w4mWGESBmj Zpr+aJQSxt+A+9peqfq8F5e/n5ZX0TCexE+CFfjTUi2VBMO7QAdmqwelRhEIokO6z4R3 xaMCZpStaj7ps2qupOCuDkyebY1uayxr4yM9rSFovwHWGdPsGKDfokNVQ9Our8XmLws3 XMzJI8yW34J2QFtpeE9ST2ds/8xDW3zu3iYNFGsPK2WE/pm/ZVhIZM747utN1qaSC28b gZEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709028501; x=1709633301; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ooc5SS3j03ORm6wAIXAzAUPoc8fJQ9XOTzT5/SJVA8Y=; b=BLWEaceJEnPzkigOiX3ieYdMgpEmB1c8YAo3jlxObrdYZiLH9phulZwTNM71alwj/r GOGrUu7hYi06biGGGcxJw9U6FzZdS73dPx3MJI7G5sRO8YRMoAd7HX3NzpTnvV1p8DDS 4talEOYWqPG5PUYaG/FrYO2OU/zMvyzL8shB2Ri/x4iYgQzmWEvCawFjfWuI7cLvsE7r p8wcpQQVSFklSfcpy5o8dO/AqclTbD2ye34sLUNOX4oHrL9KPkTa87Rh0NAKqjROU+6y fDYt2UC7vb5cwkDM7mRJObtx7lS9RsRKn5nYC7flfIxNoIFgXqhsRPpMLkqpvziPlLD4 ww4Q== X-Forwarded-Encrypted: i=1; AJvYcCWQAEaRCiLrSQQe9Vf5A1jZZ2nLlyEvutF3qFboGGizevGJJ/v1pJSf7BErC2KznmuGHHyLcxrEeSCPCBPhp8tAxXrJ9STm9pT+GOob X-Gm-Message-State: AOJu0YwOfBGiZrV+XFFKiZ8o7nR519Mp2ZwIRRFMGc+oUt7t8cU2M0IB dzBgEHQgZDJ+nOCKJ/56sBxBN33yNtyeSLl2bOGCAMrowkjRM6aqb164jUjtu1g= X-Received: by 2002:a17:906:7d86:b0:a3c:36ae:6c96 with SMTP id v6-20020a1709067d8600b00a3c36ae6c96mr5271008ejo.42.1709028501368; Tue, 27 Feb 2024 02:08:21 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id tb16-20020a1709078b9000b00a43d1968921sm5696ejc.190.2024.02.27.02.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 02:08:20 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 10:08:19 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mtd: spi-nor: Add support for BoHong bh25q128as Content-Language: en-US To: Christian Marangi Cc: Michael Walle , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, David Bauer References: <20240220200325.19089-1-ansuelsmth@gmail.com> <65d9d08f.df0a0220.988bb.3177@mx.google.com> <4d117770-6e0c-412f-ac1a-d9ba84b5b4ba@linaro.org> <65ddac61.5d0a0220.a0c6e.35bf@mx.google.com> From: Tudor Ambarus In-Reply-To: <65ddac61.5d0a0220.a0c6e.35bf@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/24 09:33, Christian Marangi wrote: > On Mon, Feb 26, 2024 at 10:53:34AM +0200, Tudor Ambarus wrote: >> >> >> On 26.02.2024 10:51, Michael Walle wrote: >>> Hi, >>> >>> On Sat Feb 24, 2024 at 12:18 PM CET, Christian Marangi wrote: >>>> The user just tested this and It seems there is a problem in JEDEC id? >>>> >>>> [ 0.726451] spi spi0.0: setup: ignoring unsupported mode bits a00 >>> >>> What SPI controller is used in this case? >>> >>>> [ 0.732850] spi-nor spi0.0: unrecognized JEDEC id bytes: 68 40 18 68 40 18 >>>> [ 0.739725] spi-nor: probe of spi0.0 failed with error -2 >>> >>> And what kernel version is this? This should only happen if the SFDP >>> header is wrong, but according to your dump, it is correct. >>> >> >> I assume the test was done on an older kernel, where the identification >> of the flash based on SFDP is not yet available. > > The test has been done on 5.15 and 6.1. The support for this was > introduced later? Can you point me to the commits so I can backport > them? > Use git blame. 773bbe104497 ("mtd: spi-nor: add generic flash driver")