Received-SPF: pass (google.com: domain of linux-kernel+bounces-83022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 27 Feb 2024 11:21:24 +0100
From: Thorsten Scherer <T.Scherer@eckelmann.de>
To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] siox: Move some complexity into the core
Message-ID: <lkgvr2t4wzw4jkfg523zcek6y2v5l7kj6onw77yffvvs7i2gfy@6ectsjpcg64t>
References: <cover.1708328466.git.u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <cover.1708328466.git.u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?qkyPDPswgYfJYbO6gp5QVccVNINfbdg5HfX4qU/rFYUMkyS2XH8JJVrXRE?=
 =?iso-8859-1?Q?IK9aOz23SBNaitXTQRe5UN7l+TyQyt4ECC0IikyhkdbnykYDAkw7H9qpog?=
 =?iso-8859-1?Q?SefBDl+Del6sv2nstW5YJvU6e7vGLBlkqdmpC+nhlfi8fM75SERcCMORzX?=
 =?iso-8859-1?Q?Jq3Pl4w/92/5ZUPYH6COvxG4vPi0TteIJhhQ6Abl3a17fuwN1W1M9C1R+4?=
 =?iso-8859-1?Q?7IQjrJeA1egncBWuSDyHUN4y9mr7LDPYc00Iowrh/0+WuBSmw2LJxoRrkn?=
 =?iso-8859-1?Q?DuIXSAm8HFdQQqXwqtU1ev86Itu1YFxI9JVfrDPx2698F5zvoil+dppbor?=
 =?iso-8859-1?Q?EGFoWzVAfNzKC78+HovkwrheEFFObOWYaD59BeOw0z5LW6L2lDxN9erU3Y?=
 =?iso-8859-1?Q?FlPh5GeJsLqiHt/FGtWeqsgUd0jfekpB0w6Olb7EBYatZjzyAy/clxBeJs?=
 =?iso-8859-1?Q?nsIvVPca7D6qn/NpHPHkbPRd+Lxbz1mpbaPd02hhmTdu/C6/jxOb0PB1a3?=
 =?iso-8859-1?Q?qSEYgD/VYg162tkqgeiitH3uiW7F2/X/Omu4/Cry6SxEC/Bl9vNEnad4gU?=
 =?iso-8859-1?Q?B18NCzjBkVUC/2TMFxLrCk3APVJBlY7GPdaIs+P4eIF3V2sD9GDBZ+JjNj?=
 =?iso-8859-1?Q?vUxZmuQayu+rIrRrMhars9ItEqEDSelyl5pIiR/xoRzwVjl01EmFiMmPMH?=
 =?iso-8859-1?Q?XExKmJ7Cw8tGT/KDbaR9Ds1dVM74Vwgmhf3+laGjAhMEDZc+pZGWM8XMpU?=
 =?iso-8859-1?Q?ft+PkDDu76D3XYPKJVXFBHrzKu0PyXxiAgpjUVPjAKvZvLUeH7d25pgo/+?=
 =?iso-8859-1?Q?mpYi5Zi5EO73pOmXdpeJ7fsLE4s8kdxUyw0H2ok2wxgk7Q+HJmDUJx/G0E?=
 =?iso-8859-1?Q?tGdne2hygtA3xKkiz+f9a/eRzv614LCR0mRTK2QOLFZc4unq+KMbxoH2bc?=
 =?iso-8859-1?Q?QzN6iaLgb6FVbTFA5H0lBjQB2csumhxAVNk1AuBxyZpYLO2sfbNqMoEBVl?=
 =?iso-8859-1?Q?qZAeMattle4yY+TFYHcMxeKpYypzNShuBYGNAJ0t9AsE7ProqVKA0mOOD+?=
 =?iso-8859-1?Q?Mxi8a6kpFi4TGq0TsubJsN/wum8U/srMSY9UW+XsT7kw6sE7RZTjbttBmE?=
 =?iso-8859-1?Q?vLP1xuS7GVgd7UrL/1NwPO+7OF5S4fz65JM1gbVWR8Zo6vdKahEDZwdlkq?=
 =?iso-8859-1?Q?bamscEn1UVbjUzxUZjFynbDbCs8i9RoTB3Ixdbr1IA6uE6d/NlA/P2uGIb?=
 =?iso-8859-1?Q?wOwASfZUxWaS9rpXkylzcacVhOH8vbv+rJ0shXef/iZX7YAtHwOh2oFzje?=
 =?iso-8859-1?Q?VUU1RrltBc9lrs3vWsrqY7MR+gCUdgLClwihiXC+b4BdHHc4J5fIWs3xnI?=
 =?iso-8859-1?Q?FmO5K3AJJNHb1/QlnLfvVrOFZarl99coPbUb3Y2eIIFCgOR7NBHo5rr3J6?=
 =?iso-8859-1?Q?+5X+pCkCzXcQZvYwKCW+wiPLuk1sq56pSqgEotQfdQMSZw8Z+ql9fQZ9ko?=
 =?iso-8859-1?Q?6JsMEjiw1Ts6ZiwbFGMFED1GQO6xM42Odz6BB7VOfgvL3mh6VKLHmmF4As?=
 =?iso-8859-1?Q?r0Nke0WpICSQBUqh4vqTRtYASGIkAc5voUwRFcdHqNdqj1Ohdy17YdhVun?=
 =?iso-8859-1?Q?sxIsSVFJAxbysUXecZ7ommUC9pTBXj7f+G?=
X-OriginatorOrg: eckelmann.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 85fb7257-3c85-4b9e-4874-08dc377ddb80
X-MS-Exchange-CrossTenant-AuthSource: FR4P281MB3510.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 10:21:27.4953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 62e24f58-823c-4d73-8ff2-db0a5f20156c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pky7cUfQe/oZW/gtstBGjKxJwbc2a9pcSujziCxFcOtLAJz27mC86+FPpJ1Kl31vySjvSbiHXj29ezGXu42Zfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR6P281MB4000

Hello Uwe, Hello Greg,

On Mon, Feb 19, 2024 at 08:46:28AM +0100, Uwe Kleine-K=F6nig wrote:
> Hello,
>=20
> the reference handling in siox is a bit strange. With
> siox_master_alloc() to get a reference on the master that is passed to
> the core calling siox_master_register(). So until siox_master_register()
> is called successfully the driver has to call siox_master_put() in the
> error path, but on remove siox_master_unregister cares for that. While
> that technically works, it's unusual and surprising to use. This serie's
> first patch cleans that up and then introduces devm functions to make it
> even easier to use.
>=20
> A nice (and intended) side effect is that the gpio bus driver gets rid
> of it's remove callback, so I don't have to adapt it for my quest that
> changes the prototype of .remove().

I only compile tested this as I currently do not have access to test
hardware.

The series looks sensible.

Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>

@gregkh: Would you please pick up Uwe's series as well?

Thank you both.

Best regards
Thorsten

> Best regards
> Uwe
>=20
> Uwe Kleine-K=F6nig (4):
>   siox: Don't pass the reference on a master in siox_master_register()
>   siox: Provide a devm variant of siox_master_alloc()
>   siox: Provide a devm variant of siox_master_register()
>   siox: bus-gpio: Simplify using devm_siox_* functions
>=20
>  drivers/siox/siox-bus-gpio.c | 62 ++++++++++++------------------------
>  drivers/siox/siox-core.c     | 45 ++++++++++++++++++++++++++
>  drivers/siox/siox.h          |  4 +++
>  3 files changed, 69 insertions(+), 42 deletions(-)
>=20
>=20
> base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118
> --=20
> 2.43.0
>=20