Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756640AbYABPAS (ORCPT ); Wed, 2 Jan 2008 10:00:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753187AbYABPAG (ORCPT ); Wed, 2 Jan 2008 10:00:06 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:55284 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbYABPAE (ORCPT ); Wed, 2 Jan 2008 10:00:04 -0500 Date: Wed, 2 Jan 2008 20:29:08 +0530 From: Ananth N Mavinakayanahalli To: Ingo Molnar Cc: Quentin Barnes , linux-kernel@vger.kernel.org, Masami Hiramatsu Subject: Re: [PATCH] [CFT] Code clarification patch to Kprobes arch code Message-ID: <20080102145908.GA6527@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20080101151943.GE4434@elte.hu> <20080102044353.GA7027@in.ibm.com> <20080102123355.GB11208@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080102123355.GB11208@elte.hu> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 41 On Wed, Jan 02, 2008 at 01:33:55PM +0100, Ingo Molnar wrote: > > * Ananth N Mavinakayanahalli wrote: > > > > Signed-off-by: Quentin Barnes > > > Signed-off-by: Ingo Molnar > > > Signed-off-by: Thomas Gleixner > > > > Tested on x86. > > > > Acked-by: Ananth N Mavinakayahanalli > > thanks Ananth, i've updated the patch. Hi Ingo, > btw., do you have some script that i could use to test kprobes > functionality? Right now the only time i notice kprobes regressions is > when randconfig picks up CONFIG_NET_TCPPROBE=y which activates kprobes. > > It would be so much nicer if kprobes had some runs-during-bootup kind of > quick self-test, with all the important functionality unit-tested. Like > lib/locking-selftest.c, or CONFIG_RCU_TORTURE_TEST=y. The simplest way to do a basic sanity check is build the kprobes samples/ and try them out. We have one sample each to test kprobes, kretprobes and jprobes. This should serve the purpose. I had posted patches for the same sometime back (http://marc.info/?l=linux-kernel&m=119297044801420&w=2), but they needed some rework to fix a build break on sparc64 (http://marc.info/?l=linux-kernel&m=119735423212298&w=2). I will rebase the patchset against the latest mm and repost soon... Ananth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/