Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1837693rbb; Tue, 27 Feb 2024 02:52:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWEctQfHHTI1QGnoAxkv+hPDKeXot0tddoUNqJJWgtDeP9axeWlBAo81J88T9G9Gaq6nQ8QKM9oM5aIyHYqjHN3pLpTMK4LIGf00qwCdQ== X-Google-Smtp-Source: AGHT+IH9cYipzpixVEj6Ktc8izZKV7DNlCAe2RwtywfCOP5IElnxXQ7cEx6sGOWcq2cvz3eOikGu X-Received: by 2002:a05:620a:2942:b0:787:e332:892b with SMTP id n2-20020a05620a294200b00787e332892bmr1752550qkp.40.1709031169480; Tue, 27 Feb 2024 02:52:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709031169; cv=pass; d=google.com; s=arc-20160816; b=ziHArxobfIYJprhTRGLU8AWtuJ74Uw4Hk1tMmnbJJ7v01+ohlOOERDvV+BD/XuRliz uiJnPKWocLuSNdRCzWp8PWh6ct+GkyvdvXRgUe9DFLTAYaj5fyICw6avMIhJ/TcGhcSU KhrLWpz3Kn7baNQJq6q85UT0yRxPPMPkTpTjjCQL9j68VTbO0noFLpY0DUCH96gw/wBM S1ia5TqQGDjenoqQKiJTL1gbTCj6IcFsLtPIYRGQWpRs1IyneayvLvm8F3JeKAxPKE8R A95eUty5hT6u8kKeKYmqYvbDV4pDI9YLsngOm1zoh6b0Nj84vMT3mKYcEq1eg0/T4uTp //4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date; bh=M14Rk6xyguBUyBiSh3mw1/eMQ6xicgNpulhPM7gLZsI=; fh=m9ru2tV7GABHMs9XyU253CjxsaZcmp/JQx9tOj88kuA=; b=xLp/CuQeCr/jBZU9Smhdls/h6mdFF9GVayKZf8vKAt10Ffwq+ruOQLHYW8L3Kv0BmV EMdgrdPyJmqdlKh9Krpi08mVt1dcHyIoTZ549gpjNOB6AsIZXHqPFug3lJ0PCA0YGFYR dgfTzlTtExyNvVsK/orSm+CDuG8WNn3JlU2cVWh7ZYCft5sudMjmfK/XvDHjTI0zAJjx wPAwW+mTrEi9eHgmcTAqyI+70U41kSCUXvZpC9wKgunbgiAQrUh9f2NvkzAoDMDeRu+G i9+wK4TZ3kv5+tHSxcfC6wL78/CzkM3Wa8gmlLE8FTNULuSIVrJfRY6IDMExSJmStU8P O75Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-83067-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83067-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o3-20020a05620a0d4300b00787e1ec459fsi1313837qkl.710.2024.02.27.02.52.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 02:52:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83067-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-83067-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83067-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 38DDB1C24085 for ; Tue, 27 Feb 2024 10:52:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 271121386D4; Tue, 27 Feb 2024 10:52:17 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3BE61386B2 for ; Tue, 27 Feb 2024 10:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709031136; cv=none; b=huqwk/7OGORDc/+gzhLFQQwUfhwsM5LnVrp56XcReJLp03K+Pnncn3tZDhJ6+xwklB6DQ9LaBCCB8hLh1FVzadTgTRJQZEb8LFVKwDKC2DQ5R2mgQj5RPLNYaX/dYs3DlwKuD8ERwm3Be06x1tnmEu+EC+eXwsjnKrKqY0dF42A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709031136; c=relaxed/simple; bh=xRRex4Qi0WZQQ6T01jIh2u/+oAWLUpko8So4AoPz76Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZvE6XDI95mnIumr9vxeYnau1W2J+xaxwSym49t+YWetk3oL+zbE7SN5uniR62DEnZuUDXg986/ehVscUTI9qSdB1WxqdDcQBxlVcB8zCSLNfiGqqwi3DLl6SYhSB74ENMgEVez/dnov74Hqrw5LxVtjpNILbd7Q21vKfQ66xQ6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92D79FEC for ; Tue, 27 Feb 2024 02:52:52 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 06AED3F6C4 for ; Tue, 27 Feb 2024 02:52:13 -0800 (PST) Date: Tue, 27 Feb 2024 10:52:12 +0000 From: Liviu Dudau To: Faiz Abbas Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch Subject: Re: [PATCH 0/3] Fixes for the komeda driver Message-ID: References: <20240219100915.192475-1-faiz.abbas@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240219100915.192475-1-faiz.abbas@arm.com> Hi Faiz, On Mon, Feb 19, 2024 at 03:39:12PM +0530, Faiz Abbas wrote: > The following patches add fixes to the komeda DPU driver. > > Patch 1 fixes an issue where the crtc always expects both pipelines to > always have remote nodes populated. > > Patch 2 is a cosmetic fix that ensures komeda does not print verbose > pipeline information unless the entire pipeline is actually up. > > Patch 3 adds a 40 bit DMA mask for each pipeline. Sorry for the delay in replying, I was on holiday last week. Patch series looks good, I will push it into drm-misc-next-fixes at the end of the week. Best regards, Liviu > > Amjad Ouled-Ameur (1): > drm/arm/komeda: update DMA mask to 40 bits > > Faiz Abbas (2): > drm/arm/komeda: Fix komeda probe failing if there are no links in the > secondary pipeline > drm/arm/komeda: Move pipeline prints to after the entire pipeline has > been enabled > > .../gpu/drm/arm/display/komeda/komeda_crtc.c | 45 ++++++++++++++----- > .../gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++ > .../gpu/drm/arm/display/komeda/komeda_kms.h | 1 + > .../drm/arm/display/komeda/komeda_pipeline.c | 4 +- > 4 files changed, 41 insertions(+), 13 deletions(-) > > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯