Received-SPF: pass (google.com: domain of linux-kernel+bounces-83071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+a225ee3df7e7f9372dbe@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [dri?] [media?] inconsistent lock state in valid_state (2)
Date: Tue, 27 Feb 2024 18:53:01 +0800
Message-Id: <20240227105301.1525-1-hdanton@sina.com>
In-Reply-To: <00000000000066a91a0612527e6d@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Mon, 26 Feb 2024 16:56:17 -0800
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    d206a76d7d27 Linux 6.8-rc6
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1704b3e2180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master

--- x/drivers/dma-buf/sync_debug.c
+++ y/drivers/dma-buf/sync_debug.c
@@ -107,15 +107,16 @@ static void sync_print_fence(struct seq_
 static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
 {
 	struct list_head *pos;
+	unsigned long flags;
 
 	seq_printf(s, "%s: %d\n", obj->name, obj->value);
 
-	spin_lock_irq(&obj->lock);
+	spin_lock_irqsave(&obj->lock, flags);
 	list_for_each(pos, &obj->pt_list) {
 		struct sync_pt *pt = container_of(pos, struct sync_pt, link);
 		sync_print_fence(s, &pt->base, false);
 	}
-	spin_unlock_irq(&obj->lock);
+	spin_unlock_irqrestore(&obj->lock, flags);
 }
 
 static void sync_print_sync_file(struct seq_file *s,
--