Received-SPF: pass (google.com: domain of linux-kernel+bounces-83083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227024050.244567-1-21cnbao@gmail.com> <61b9dfc9-5522-44fd-89a4-140833ede8af@arm.com>
 <c95215b2-6ec5-4efb-a73b-7be92cda1c83@redhat.com> <CAK1f24mOc+Y_UCA2nSC7VbNQMy0DahULz-6JsEPMqTyoAA+MoA@mail.gmail.com>
 <dbce43b4-cf69-41d0-af6c-fdfc3032fedb@redhat.com> <dc2ac3e5-a354-4447-a7da-26cae0c57b0d@arm.com>
In-Reply-To: <dc2ac3e5-a354-4447-a7da-26cae0c57b0d@arm.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Tue, 27 Feb 2024 18:55:53 +0800
Message-ID: <CAK1f24mr=vkAnmPdAADsyQ3ymofv7SrxwegBPb9tQK2jve98RA@mail.gmail.com>
Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might
 need it
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: David Hildenbrand <david@redhat.com>, Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	Barry Song <v-songbaohua@oppo.com>, Yin Fengwei <fengwei.yin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks, Ryan, Barry, David!

Best,
Lance

On Tue, Feb 27, 2024 at 6:53=E2=80=AFPM Ryan Roberts <ryan.roberts@arm.com>=
 wrote:
>
> On 27/02/2024 10:30, David Hildenbrand wrote:
> > On 27.02.24 11:21, Lance Yang wrote:
> >> On Tue, Feb 27, 2024 at 5:14=E2=80=AFPM David Hildenbrand <david@redha=
t.com> wrote:
> >>>
> >>> On 27.02.24 10:07, Ryan Roberts wrote:
> >>>> On 27/02/2024 02:40, Barry Song wrote:
> >>>>> From: Barry Song <v-songbaohua@oppo.com>
> >>>>>
> >>>>> madvise and some others might need folio_pte_batch to check if a ra=
nge
> >>>>> of PTEs are completely mapped to a large folio with contiguous phys=
cial
> >>>>> addresses. Let's export it for others to use.
> >>>>>
> >>>>> Cc: Lance Yang <ioworker0@gmail.com>
> >>>>> Cc: Ryan Roberts <ryan.roberts@arm.com>
> >>>>> Cc: David Hildenbrand <david@redhat.com>
> >>>>> Cc: Yin Fengwei <fengwei.yin@intel.com>
> >>>>> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> >>>>> ---
> >>>>>    -v1:
> >>>>>    at least two jobs madv_free and madv_pageout depend on it. To av=
oid
> >>>>>    conflicts and dependencies, after discussing with Lance, we pref=
er
> >>>>>    this one can land earlier.
> >>>>
> >>>> I think this will also ultimately be useful for mprotect too, though=
 I haven't
> >>>> looked at it properly yet.
> >>>>
> >>>
> >>> Yes, I think we briefly discussed that.
> >>>
> >>>>>
> >>>>>    mm/internal.h | 13 +++++++++++++
> >>>>>    mm/memory.c   | 11 +----------
> >>>>>    2 files changed, 14 insertions(+), 10 deletions(-)
> >>>>>
> >>>>> diff --git a/mm/internal.h b/mm/internal.h
> >>>>> index 13b59d384845..8e2bc304f671 100644
> >>>>> --- a/mm/internal.h
> >>>>> +++ b/mm/internal.h
> >>>>> @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct fol=
io *folio)
> >>>>>       return (void *)(mapping & ~PAGE_MAPPING_FLAGS);
> >>>>>    }
> >>>>>
> >>>>> +/* Flags for folio_pte_batch(). */
> >>>>> +typedef int __bitwise fpb_t;
> >>>>> +
> >>>>> +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */
> >>>>> +#define FPB_IGNORE_DIRTY            ((__force fpb_t)BIT(0))
> >>>>> +
> >>>>> +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-di=
rty bit. */
> >>>>> +#define FPB_IGNORE_SOFT_DIRTY               ((__force fpb_t)BIT(1)=
)
> >>>>> +
> >>>>> +extern int folio_pte_batch(struct folio *folio, unsigned long addr=
,
> >>>>> +            pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> >>>>> +            bool *any_writable);
> >>>>> +
> >>>>>    void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *fo=
lio,
> >>>>>                                               int nr_throttled);
> >>>>>    static inline void acct_reclaim_writeback(struct folio *folio)
> >>>>> diff --git a/mm/memory.c b/mm/memory.c
> >>>>> index 1c45b6a42a1b..319b3be05e75 100644
> >>>>> --- a/mm/memory.c
> >>>>> +++ b/mm/memory.c
> >>>>> @@ -953,15 +953,6 @@ static __always_inline void __copy_present_pte=
s(struct
> >>>>> vm_area_struct *dst_vma,
> >>>>>       set_ptes(dst_vma->vm_mm, addr, dst_pte, pte, nr);
> >>>>>    }
> >>>>>
> >>>>> -/* Flags for folio_pte_batch(). */
> >>>>> -typedef int __bitwise fpb_t;
> >>>>> -
> >>>>> -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */
> >>>>> -#define FPB_IGNORE_DIRTY            ((__force fpb_t)BIT(0))
> >>>>> -
> >>>>> -/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-di=
rty bit. */
> >>>>> -#define FPB_IGNORE_SOFT_DIRTY               ((__force fpb_t)BIT(1)=
)
> >>>>> -
> >>>>>    static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t f=
lags)
> >>>>>    {
> >>>>>       if (flags & FPB_IGNORE_DIRTY)
> >>>>> @@ -982,7 +973,7 @@ static inline pte_t __pte_batch_clear_ignored(p=
te_t
> >>>>> pte, fpb_t flags)
> >>>>>     * If "any_writable" is set, it will indicate if any other PTE b=
esides the
> >>>>>     * first (given) PTE is writable.
> >>>>>     */
> >>>>
> >>>> David was talking in Lance's patch thread, about improving the docs =
for this
> >>>> function now that its exported. Might be worth syncing on that.
> >>>
> >>> Here is my take:
> >>>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> ---
> >>>    mm/memory.c | 22 ++++++++++++++++++----
> >>>    1 file changed, 18 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/mm/memory.c b/mm/memory.c
> >>> index d0b855a1837a8..098356b8805ae 100644
> >>> --- a/mm/memory.c
> >>> +++ b/mm/memory.c
> >>> @@ -971,16 +971,28 @@ static inline pte_t __pte_batch_clear_ignored(p=
te_t
> >>> pte, fpb_t flags)
> >>>          return pte_wrprotect(pte_mkold(pte));
> >>>    }
> >>>
> >>> -/*
> >>> +/**
> >>> + * folio_pte_batch - detect a PTE batch for a large folio
> >>> + * @folio: The large folio to detect a PTE batch for.
> >>> + * @addr: The user virtual address the first page is mapped at.
> >>> + * @start_ptep: Page table pointer for the first entry.
> >>> + * @pte: Page table entry for the first page.
> >>
> >> Nit:
> >>
> >> - * @pte: Page table entry for the first page.
> >> + * @pte: Page table entry for the first page that must be the first s=
ubpage of
> >> + *               the folio excluding arm64 for now.
> >>
> >> IIUC, pte_batch_hint is always 1 excluding arm64 for now.
> >> I'm not sure if this modification will be helpful?
> >
> > IIRC, Ryan made sure that this also works when passing another subpage,=
 after
> > when cont-pte is set. Otherwise this would already be broken for fork/z=
ap.
> >
> > So I don't think this comment would actually be correct.
>
> Indeed, the spec for the function is exactly the same for arm64 as for ot=
her
> arches. It's just that arm64 can accelerate the implementation by skippin=
g
> forward to the next contpte boundary when the current pte is part of a co=
ntpte
> block.
>
> There is no requirement for pte (or addr or start_ptep) to point to the f=
irst
> subpage of a folio - they can point to any subpage.
>
> pte, addr and start_ptep must all refer to the same entry, but I think th=
at's
> clear from the existing text.
>
>