Received-SPF: pass (google.com: domain of linux-kernel+bounces-83119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240226091325.53986-1-steffen@innosonix.de>
In-Reply-To: <20240226091325.53986-1-steffen@innosonix.de>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 27 Feb 2024 08:22:23 -0300
Message-ID: <CAOMZO5Avrw7L-JxD2wfYUVH24POrJC93Zh+VReZbJDhmO6PCqg@mail.gmail.com>
Subject: Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing
To: =?UTF-8?Q?Steffen_B=C3=A4tz?= <steffen@innosonix.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, 
	Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Russell King <linux@armlinux.org.uk>, 
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Steffen,

On Mon, Feb 26, 2024 at 6:15=E2=80=AFAM Steffen B=C3=A4tz <steffen@innosoni=
x.de> wrote:
>
> As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to
> be filled")
> Marvell 88e6320/21 switches fail to be probed:
>
> ...
> mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfa=
ces
> error creating PHYLINK: -22
> ...
>
> The problem stems from the use of mv88e6185_phylink_get_caps() to get
> the device capabilities. Create a new dedicated phylink_get_caps for the
> 6320 and 6321 to properly support their set of capabilities.
>
> Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be fi=
lled")
> Signed-off-by: Steffen B=C3=A4tz <steffen@innosonix.de>

Thanks for the fix.

Reviewed-by: Fabio Estevam <festevam@gmail.com>