Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1864504rbb; Tue, 27 Feb 2024 03:54:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVioDC8D9PeVQx1daWRls179nEQkzt3ayfjxFy0JKDt/8LRjgbIAtLuGtS0gjHPHLABj6Gpxb08lUaFQG/9DAV2s4SsXDEgPXvrpvB4Yg== X-Google-Smtp-Source: AGHT+IG85xKerrAfFqk8bAsFzahwJiim25aaDqXbPC6xriHWLaSWJQgLWXbhbmceFaXS8rueSdrR X-Received: by 2002:a17:906:b349:b0:a3e:fce7:9393 with SMTP id cd9-20020a170906b34900b00a3efce79393mr5803587ejb.10.1709034885930; Tue, 27 Feb 2024 03:54:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709034885; cv=pass; d=google.com; s=arc-20160816; b=eaBgWXxjEjDFwOHQMzqsM/kumll1qTLtMNIQZAW29NYWXEChSJBguuKrrCa3SOJJGJ AYVPu6QwbKc7aQMotz/lSrRLlcx7MNeEIkWaN9fvAWhmlqoPYs7O1weLZfYwSy1G1taV bIxXelw0DEIAK2xf1pen+nCk+ARdw/I6WFBIQuxnMnEgB/YLoBzzWq3AJZ7P64GlzGMG h1Ld6BLGeb8i6tPhBzkmgeBmohOTqqDkpgNTvwTQE01IU/0hd1C2porJWqgy+Pn6P+wG uFZvI9JyncJDvoW9+GsVzWx0YdyWdcjXbBoy47Fece1TXn0FNr8pl2UozKazq2rb+R2V TAGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-filter; bh=fXF1dOEZbO19a6vXcblB4Cq2Xvv4zWKbK7s9IvVHto4=; fh=mEwba1EvprUlR44oLnLa48Xb8A/G7jP+RRiWqRSOVNw=; b=OprxviW7Nvq1JrdXsfn49aN8Sb09QVknMwSt+WLWfBWHxi8IesEvUOz1b0SrmPzT21 1R/3HihyGRPvi1TiQ/F01iUGQGdhfcEeGi79lRCpKWsxpQPFQrUlZk7cPWIj+BgCIh9h woknojYeiYEaOynFkei6TY3R9WgywI8eTqoifWbB+nh7ruSBjibgyFVkj5qBvambvqc5 y8+M9zwCw1s+t5FshDFqFg/9fVJI6XCw40sxi2rBocjMYCtwd4lJT45ZqhvDmqPT8uaY b/Z3IN+uSKStXT7H/NmerW5R4rYmRZTACV/L+culynar/kFrvdS/F/ZTH4bIbDBV1M+x g6ZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@secunet.com header.s=202301 header.b=uA9GZEu+; arc=pass (i=1 spf=pass spfdomain=secunet.com dkim=pass dkdomain=secunet.com); spf=pass (google.com: domain of linux-kernel+bounces-83147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83147-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m10-20020a1709066d0a00b00a3e61a086b6si685076ejr.847.2024.02.27.03.54.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 03:54:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@secunet.com header.s=202301 header.b=uA9GZEu+; arc=pass (i=1 spf=pass spfdomain=secunet.com dkim=pass dkdomain=secunet.com); spf=pass (google.com: domain of linux-kernel+bounces-83147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83147-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ACD1B1F29B2A for ; Tue, 27 Feb 2024 11:54:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 23E4E13A259; Tue, 27 Feb 2024 11:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="uA9GZEu+" Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE7E1386C3; Tue, 27 Feb 2024 11:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709034878; cv=none; b=bF1XvnzA7qLBVjaH4dmDTG/Jwc5tALPqgJE4M3Yu9/pGBh2h4p0i56bEqOduSyt0aykAtEnXU4lcTJHcAnvlcMJ3nSswJe95IROdpVpn1cidlFGmCi8W/wwrBxP7bvdQJKVNmo0xBVNHjp0A3PR0sAz83KMSgIVMdIkaKh68UWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709034878; c=relaxed/simple; bh=VZ9Rjqf5D/gy+R9Y+MTa3mzy8ZRUWGvxwXfxWHRoepM=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fOx6BgxQn4ML73z6d2Y1bH8DxGu8eCFICLz+RzgcM8OOrHyusdG73PprXYUIdoCp8Z1QdhEnNUI7LI4Mka4evpY2fEsHN6h05YEnu68hTb/oe7XOfAUDXxJZxhfLlVVeRAzkBD/RGEFhrTzca/Osp1dPLYek8nCmGi/TYee7g2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=uA9GZEu+; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 929592074F; Tue, 27 Feb 2024 12:54:33 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vk_j11-XYB_f; Tue, 27 Feb 2024 12:54:33 +0100 (CET) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 1B45020190; Tue, 27 Feb 2024 12:54:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 a.mx.secunet.com 1B45020190 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1709034873; bh=fXF1dOEZbO19a6vXcblB4Cq2Xvv4zWKbK7s9IvVHto4=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=uA9GZEu+DpQUxfnDGpNDsodPd0EF78qy8WLsMHMjMAYdPaZ1lqkZeILFmt6nhpjzt g1EZY/w4XjS4n9afx6nOhaWLbW6xEsVDL5r1iMySw/NW5/B+c4dNmndwUu0/v0uh2z I0sK0o11HsKsV0VONddaOm829d+ZjEO9FxDGhsYp67gimLUHcI6f/TNhqdMjGdWfzw XbpyDYLBAm1lwahRflHIZYKo8f5px0L+b9iLtC979zsK/R2ajn80pltZr7y3HPaCl+ ThXJtu+WmYiEhg6D02zaaez4obzaaBV8yzSZSRI7m/gHy5OjwxJ8N+sfFxK15e0egL 9h1tLh4W9hQog== Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id 0BB7780004A; Tue, 27 Feb 2024 12:54:33 +0100 (CET) Received: from mbx-essen-02.secunet.de (10.53.40.198) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 12:54:32 +0100 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 12:54:32 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 6274B318297D; Tue, 27 Feb 2024 12:54:32 +0100 (CET) Date: Tue, 27 Feb 2024 12:54:32 +0100 From: Steffen Klassert To: Breno Leitao CC: , , , , Herbert Xu , , , Subject: Re: [PATCH net-next] xfrm: Do not allocate stats in the driver Message-ID: References: <20240222144117.1370101-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240222144117.1370101-1-leitao@debian.org> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-02.secunet.de (10.53.40.198) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 On Thu, Feb 22, 2024 at 06:41:17AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the xfrm driver and leverage the network > core allocation. > > Signed-off-by: Breno Leitao Applied to ipsec-next, thanks Breno!